From owner-svn-src-all@FreeBSD.ORG Mon Nov 24 16:32:39 2008 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 6217A1065677; Mon, 24 Nov 2008 16:32:39 +0000 (UTC) (envelope-from pjd@FreeBSD.org) Received: from svn.freebsd.org (svn.freebsd.org [IPv6:2001:4f8:fff6::2c]) by mx1.freebsd.org (Postfix) with ESMTP id 5404C8FC13; Mon, 24 Nov 2008 16:32:39 +0000 (UTC) (envelope-from pjd@FreeBSD.org) Received: from svn.freebsd.org (localhost [127.0.0.1]) by svn.freebsd.org (8.14.3/8.14.3) with ESMTP id mAOGWdY1092112; Mon, 24 Nov 2008 16:32:39 GMT (envelope-from pjd@svn.freebsd.org) Received: (from pjd@localhost) by svn.freebsd.org (8.14.3/8.14.3/Submit) id mAOGWd1X092111; Mon, 24 Nov 2008 16:32:39 GMT (envelope-from pjd@svn.freebsd.org) Message-Id: <200811241632.mAOGWd1X092111@svn.freebsd.org> From: Pawel Jakub Dawidek Date: Mon, 24 Nov 2008 16:32:39 +0000 (UTC) To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org X-SVN-Group: head MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Cc: Subject: svn commit: r185251 - head/tools/regression/fstest/tests X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 24 Nov 2008 16:32:39 -0000 Author: pjd Date: Mon Nov 24 16:32:39 2008 New Revision: 185251 URL: http://svn.freebsd.org/changeset/base/185251 Log: Include TODO messages even if tests succeeds, so we can detect when something suddenly started to work. Modified: head/tools/regression/fstest/tests/misc.sh Modified: head/tools/regression/fstest/tests/misc.sh ============================================================================== --- head/tools/regression/fstest/tests/misc.sh Mon Nov 24 11:23:14 2008 (r185250) +++ head/tools/regression/fstest/tests/misc.sh Mon Nov 24 16:32:39 2008 (r185251) @@ -25,15 +25,19 @@ expect() r=`${fstest} $* 2>/dev/null | tail -1` echo "${r}" | egrep '^'${e}'$' >/dev/null 2>&1 if [ $? -eq 0 ]; then - echo "ok ${ntest}" + if [ -z "${todomsg}" ]; then + echo "ok ${ntest}" + else + echo "ok ${ntest} # TODO ${todomsg}" + fi else if [ -z "${todomsg}" ]; then echo "not ok ${ntest} - tried '$*', expected ${e}, got ${r}" else echo "not ok ${ntest} # TODO ${todomsg}" - todomsg="" fi fi + todomsg="" ntest=`expr $ntest + 1` } @@ -46,30 +50,38 @@ jexpect() r=`jail -s ${s} / fstest 127.0.0.1 /bin/sh -c "cd ${d} && ${fstest} $* 2>/dev/null" | tail -1` echo "${r}" | egrep '^'${e}'$' >/dev/null 2>&1 if [ $? -eq 0 ]; then - echo "ok ${ntest}" + if [ -z "${todomsg}" ]; then + echo "ok ${ntest}" + else + echo "ok ${ntest} # TODO ${todomsg}" + fi else if [ -z "${todomsg}" ]; then echo "not ok ${ntest} - tried '$*', expected ${e}, got ${r}" else echo "not ok ${ntest} # TODO ${todomsg}" - todomsg="" fi fi + todomsg="" ntest=`expr $ntest + 1` } test_check() { if [ $* ]; then - echo "ok ${ntest}" + if [ -z "${todomsg}" ]; then + echo "ok ${ntest}" + else + echo "ok ${ntest} # TODO ${todomsg}" + fi else if [ -z "${todomsg}" ]; then echo "not ok ${ntest}" else echo "not ok ${ntest} # TODO ${todomsg}" - todomsg="" fi fi + todomsg="" ntest=`expr $ntest + 1` }