From owner-freebsd-hackers Tue Mar 27 13:41:25 2001 Delivered-To: freebsd-hackers@freebsd.org Received: from tabby.sonn.com (tabby.sonn.com [206.79.239.6]) by hub.freebsd.org (Postfix) with ESMTP id 5323A37B719 for ; Tue, 27 Mar 2001 13:41:16 -0800 (PST) (envelope-from gersh@tabby.sonn.com) Received: from localhost (gersh@localhost) by tabby.sonn.com (8.9.3/8.9.3) with ESMTP id NAA30279 for ; Tue, 27 Mar 2001 13:46:40 -0800 (PST) Date: Tue, 27 Mar 2001 13:46:40 -0800 (PST) From: Gersh To: freebsd-hackers@FreeBSD.ORG Subject: crash dump speed up patch. Message-ID: MIME-Version: 1.0 Content-Type: MULTIPART/MIXED; BOUNDARY="0-576564399-985729600=:3635" Sender: owner-freebsd-hackers@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG This message is in MIME format. The first part should be readable text, while the remaining parts are likely unreadable without MIME-aware tools. Send mail to mime@docserver.cac.washington.edu for more info. --0-576564399-985729600=:3635 Content-Type: TEXT/PLAIN; charset=US-ASCII Ive writen a quick patch for dev/ata/ata-disk.c:addump under 4.0-stable (03/26/01) which is considerbally faster. I did dumps on a SMP system with 512 megs of ram. Old: 201 seconds. New: 59 seconds. What I could gather from talking to people over irc/email about the problem was that there was a DELAY(1000) in between each printf to deal with problems with serial connections to the debugger. The soultion I came up with simply to display a smaller ammount of printf's the output looks like this: Dump in progress, percentage complete: 10 20 30 40 50 60 70 80 100. Done. The dump_stats() routine probally belongs in some kern/subr_whatever.c and should probally be used in the other dump routines for da/ide etc. Any thoughts or comments ? --0-576564399-985729600=:3635 Content-Type: TEXT/PLAIN; charset=US-ASCII; name="ata-disk.c.patch" Content-Transfer-Encoding: BASE64 Content-ID: Content-Description: Content-Disposition: attachment; filename="ata-disk.c.patch" LS0tIGF0YS1kaXNrLmMub3JpZwlUdWUgTWFyIDI3IDEwOjMxOjU5IDIwMDEN CisrKyBhdGEtZGlzay5jCVR1ZSBNYXIgMjcgMTQ6Mzk6MjQgMjAwMQ0KQEAg LTkxLDYgKzkxLDcgQEANCiBzdGF0aWMgc3RydWN0IGNkZXZzdyBmYWtld2Rk aXNrX2NkZXZzdzsNCiANCiAvKiBwcm90b3R5cGVzICovDQoraW50IGR1bXBf c3RhdHMoaW50LCBpbnQsIGludCAqKTsNCiBzdGF0aWMgdm9pZCBhZF90aW1l b3V0KHN0cnVjdCBhZF9yZXF1ZXN0ICopOw0KIHN0YXRpYyBpbnQzMl90IGFk X3ZlcnNpb24odV9pbnQxNl90KTsNCiANCkBAIC0yNTksNyArMjYwLDcgQEAN CiAgICAgc3RydWN0IGFkX3JlcXVlc3QgcmVxdWVzdDsNCiAgICAgdV9pbnQg Y291bnQsIGJsa25vLCBzZWNzaXplOw0KICAgICB2bV9vZmZzZXRfdCBhZGRy ID0gMDsNCi0gICAgaW50IGVycm9yOw0KKyAgICBpbnQgZXJyb3IsIGxlZnQs IHN0YXRlLCB0b3RhbCwgcGVyY2VudDsNCiANCiAgICAgaWYgKChlcnJvciA9 IGRpc2tfZHVtcGNoZWNrKGRldiwgJmNvdW50LCAmYmxrbm8sICZzZWNzaXpl KSkpDQogCXJldHVybiBlcnJvcjsNCkBAIC0yNzEsOCArMjcyLDEyIEBADQog ICAgIGFkcC0+Y29udHJvbGxlci0+bW9kZVtBVEFfREVWKGFkcC0+dW5pdCld ID0gQVRBX1BJTzsNCiAgICAgYXRhX3JlaW5pdChhZHAtPmNvbnRyb2xsZXIp Ow0KIA0KKyAgICBzdGF0ZSA9IGxlZnQgPSAwOw0KKyAgICB0b3RhbCA9IChj b3VudCAqIERFVl9CU0laRSkgLyAoMTAyNCAqIDEwMjQpOw0KKw0KKyAgICBw cmludGYoIkR1bXAgaW4gcHJvZ3Jlc3MsIHBlcmNlbnRhZ2UgY29tcGxldGU6 ICIpOw0KKw0KICAgICB3aGlsZSAoY291bnQgPiAwKSB7DQotCURFTEFZKDEw MDApOw0KIAlpZiAoaXNfcGh5c2ljYWxfbWVtb3J5KGFkZHIpKQ0KIAkgICAg cG1hcF9lbnRlcihrZXJuZWxfcG1hcCwgKHZtX29mZnNldF90KUNBRERSMSwN CiAJCSAgICAgICB0cnVuY19wYWdlKGFkZHIpLCBWTV9QUk9UX1JFQUQsIFRS VUUpOw0KQEAgLTMwMCw5ICszMDUsMTcgQEANCiAJICAgIGlmICh3ZG9nX3Rp Y2tsZXIpDQogCQkoKndkb2dfdGlja2xlcikoKTsNCiAjZW5kaWYNCi0JICAg IHByaW50ZigiJWxkICIsIChsb25nKShjb3VudCAqIERFVl9CU0laRSkgLyAo MTAyNCAqIDEwMjQpKTsNCi0JfQ0KKwkgICAgbGVmdCsrOw0KKwkgICAgcGVy Y2VudCA9IGxlZnQgKiAxMDAgLyB0b3RhbDsNCiANCisJICAgIC8qDQorCSAg ICAgKiAgUmF0ZSBsaW1pdCBwcmludGYncyB0byByZXBsYWNlIG9sZCBERUxB WSgxMDAwKQ0KKwkgICAgICogIFRoaXMgaXMgZG9uZSBzbyB0aGF0IG9sZCBz bG93IHNlcmlhbCBjb25uZWN0aW9ucw0KKwkgICAgICogIGRvIG5vdCBnZXQg aG9zZWQuDQorCSAgICAgKi8NCisNCisJICAgIGR1bXBfc3RhdHMocGVyY2Vu dCwgdG90YWwsICZzdGF0ZSk7DQorCX0NCiAJYmxrbm8gKz0gaG93bWFueShQ QUdFX1NJWkUsIHNlY3NpemUpOw0KIAljb3VudCAtPSBob3dtYW55KFBBR0Vf U0laRSwgc2Vjc2l6ZSk7DQogCWFkZHIgKz0gUEFHRV9TSVpFOw0KQEAgLTYx OSw0ICs2MzIsOTYgQEANCiAJaWYgKHZlcnNpb24gJiAoMTw8Yml0KSkNCiAJ ICAgIHJldHVybiBiaXQ7DQogICAgIHJldHVybiAwOw0KK30NCisNCitpbnQN CitkdW1wX3N0YXRzKGNvdW50LCB0b3RhbCwgc3RhdGUpDQorCWludCBjb3Vu dDsNCisJaW50IHRvdGFsOw0KKwlpbnQgKnN0YXRlOw0KK3sNCisJc3dpdGNo ICgqc3RhdGUpDQorCXsNCisJICAgIGNhc2UgMDoNCisJCWlmIChjb3VudCA+ IDEwKQ0KKwkJICAgICpzdGF0ZSA9IDEwOw0KKwkgICAgYnJlYWs7DQorDQor CSAgICBjYXNlIDEwOg0KKwkJaWYgKGNvdW50ID4gMjApDQorCQl7DQorCQkg ICAgcHJpbnRmKCIlZCAiLCAqc3RhdGUpOw0KKwkJICAgICpzdGF0ZSA9IDIw OyANCisJCX0NCisJICAgIGJyZWFrOw0KKw0KKwkgICAgY2FzZSAyMDoNCisJ CWlmIChjb3VudCA+IDMwKQ0KKwkJew0KKwkJICAgIHByaW50ZigiJWQgIiwg KnN0YXRlKTsNCisJCSAgICAqc3RhdGUgPSAzMDsgDQorCQl9DQorCSAgICBi cmVhazsNCisNCisJICAgIGNhc2UgMzA6DQorCQlpZiAoY291bnQgPiA0MCkN CisJCXsNCisJCSAgICBwcmludGYoIiVkICIsICpzdGF0ZSk7DQorCQkgICAg KnN0YXRlID0gNDA7IA0KKwkJfQ0KKwkgICAgYnJlYWs7DQorDQorCSAgICBj YXNlIDQwOg0KKwkJaWYgKGNvdW50ID4gNTApDQorCQl7DQorCQkgICAgcHJp bnRmKCIlZCAiLCAqc3RhdGUpOw0KKwkJICAgICpzdGF0ZSA9IDUwOyANCisJ CX0NCisJICAgIGJyZWFrOw0KKw0KKwkgICAgY2FzZSA1MDoNCisJCWlmIChj b3VudCA+IDYwKQ0KKwkJew0KKwkJICAgIHByaW50ZigiJWQgIiwgKnN0YXRl KTsNCisJCSAgICAqc3RhdGUgPSA2MDsgDQorCQl9DQorCSAgICBicmVhazsN CisNCisJICAgIGNhc2UgNjA6DQorCQlpZiAoY291bnQgPiA3MCkNCisJCXsN CisJCSAgICBwcmludGYoIiVkICIsICpzdGF0ZSk7DQorCQkgICAgKnN0YXRl ID0gNzA7IA0KKwkJfQ0KKwkgICAgYnJlYWs7DQorDQorCSAgICBjYXNlIDcw Og0KKwkJaWYgKGNvdW50ID4gODApDQorCQl7DQorCQkgICAgcHJpbnRmKCIl ZCAiLCAqc3RhdGUpOw0KKwkJICAgICpzdGF0ZSA9IDgwOyANCisJCX0NCisJ ICAgIGJyZWFrOw0KKw0KKwkgICAgY2FzZSA4MDoNCisJCWlmIChjb3VudCA+ IDkwKQ0KKwkJew0KKwkJICAgIHByaW50ZigiJWQgIiwgKnN0YXRlKTsNCisJ CSAgICAqc3RhdGUgPSA5MDsgDQorCQl9DQorCSAgICBicmVhazsNCisNCisJ ICAgIGNhc2UgOTA6DQorCQlpZiAoY291bnQgPT0gMTAwKQ0KKwkJew0KKwkJ ICAgICpzdGF0ZSA9IDEwMDsgDQorCQkgICAgcHJpbnRmKCIlZC4gIERvbmUi LCAqc3RhdGUpOw0KKwkJfQ0KKwkgICAgYnJlYWs7DQorDQorCSAgICBkZWZh dWx0Og0KKwkgICAgYnJlYWs7DQorCX0NCisNCisJcmV0dXJuIDA7DQogfQ0K --0-576564399-985729600=:3635-- To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-hackers" in the body of the message