Skip site navigation (1)Skip section navigation (2)
Date:      Thu, 25 Oct 2012 03:20:01 +0000 (UTC)
From:      Eitan Adler <eadler@FreeBSD.org>
To:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-stable@freebsd.org, svn-src-stable-7@freebsd.org
Subject:   svn commit: r242048 - in stable/7/games: bcd caesar
Message-ID:  <201210250320.q9P3K1Hh059992@svn.freebsd.org>

next in thread | raw e-mail | index | archive | help
Author: eadler
Date: Thu Oct 25 03:20:01 2012
New Revision: 242048
URL: http://svn.freebsd.org/changeset/base/242048

Log:
  MFC r241846:
  	bcd isn't installed setuid.
  	caesar isn't installed setuid.
  
  For the archaeologists:
  	it seems this call originally came from NetBSD PR 5970 and 5945
  
  PR:		172566
  Approved by:	cperciva (implicit)

Modified:
  stable/7/games/bcd/bcd.c
  stable/7/games/caesar/caesar.c
Directory Properties:
  stable/7/games/bcd/   (props changed)
  stable/7/games/caesar/   (props changed)

Modified: stable/7/games/bcd/bcd.c
==============================================================================
--- stable/7/games/bcd/bcd.c	Thu Oct 25 03:20:00 2012	(r242047)
+++ stable/7/games/bcd/bcd.c	Thu Oct 25 03:20:01 2012	(r242048)
@@ -133,9 +133,6 @@ main(int argc, char **argv)
 {
 	char cardline[80];
 
-	/* revoke setgid privileges */
-	setgid(getgid());
-
 	/*
 	 * The original bcd prompts with a "%" when reading from stdin,
 	 * but this seems kind of silly.  So this one doesn't.

Modified: stable/7/games/caesar/caesar.c
==============================================================================
--- stable/7/games/caesar/caesar.c	Thu Oct 25 03:20:00 2012	(r242047)
+++ stable/7/games/caesar/caesar.c	Thu Oct 25 03:20:01 2012	(r242048)
@@ -86,9 +86,6 @@ main(int argc, char **argv)
 	char *inbuf;
 	int obs[26], try, winner;
 
-	/* revoke setgid privileges */
-	setgid(getgid());
-
 	if (argc > 1)
 		printit(argv[1]);
 



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201210250320.q9P3K1Hh059992>