From owner-freebsd-fs@FreeBSD.ORG  Tue Jul  9 14:47:47 2013
Return-Path: <owner-freebsd-fs@FreeBSD.ORG>
Delivered-To: freebsd-fs@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115])
 by hub.freebsd.org (Postfix) with ESMTP id 2B95151C
 for <freebsd-fs@freebsd.org>; Tue,  9 Jul 2013 14:47:47 +0000 (UTC)
 (envelope-from rmh.aybabtu@gmail.com)
Received: from mail-qe0-x236.google.com (mail-qe0-x236.google.com
 [IPv6:2607:f8b0:400d:c02::236])
 by mx1.freebsd.org (Postfix) with ESMTP id E835F1453
 for <freebsd-fs@freebsd.org>; Tue,  9 Jul 2013 14:47:46 +0000 (UTC)
Received: by mail-qe0-f54.google.com with SMTP id ne12so3111039qeb.27
 for <freebsd-fs@freebsd.org>; Tue, 09 Jul 2013 07:47:46 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113;
 h=mime-version:sender:in-reply-to:references:date
 :x-google-sender-auth:message-id:subject:from:to:cc:content-type;
 bh=3/yYai+KZlHuI1qUWSKdHZThLZdXYbprL7l25MRLPIM=;
 b=W3zJ6UhEGyzOEhLCKYs34zjHsP8xAN+Km+rtCc0zZ7iYa7K5qJUneHVnnrMSA3mGcQ
 YWOsskAunxaEMYGN+8E07Gp0/PjJ/ERK/bl+vPBS6SOVFJObNzUkEGopa5L9vpMgJEYy
 Tkg++Nj3P1zjBA40JQ4BcZGuwwWBAusDNuqPkcI8GEHvhrmA34q5dzhpTW2mz3/ovmGC
 4p9QtPV7sDWCYE+0gzeQ9HiaLjpaLEVneiKsqq4bgvkTCMnUG1Y4uNFuXeo5rtTWDXae
 Ni4wvBvBoBE3lfblLmq7ebbgE9CnH38VSObkyXO+FBBzvN3YYnazyDKULPkjDlXT2EIm
 QMxg==
MIME-Version: 1.0
X-Received: by 10.224.98.140 with SMTP id q12mr23553911qan.99.1373381266451;
 Tue, 09 Jul 2013 07:47:46 -0700 (PDT)
Sender: rmh.aybabtu@gmail.com
Received: by 10.49.26.193 with HTTP; Tue, 9 Jul 2013 07:47:46 -0700 (PDT)
In-Reply-To: <20130702000732.GA72587@icarus.home.lan>
References: <CAOfDtXM_KJeLLUcsFA0EZOC8ZgSjKiLKuGeeNPQKCcZwcaJbCQ@mail.gmail.com>
 <20130702000732.GA72587@icarus.home.lan>
Date: Tue, 9 Jul 2013 16:47:46 +0200
X-Google-Sender-Auth: FSY9sXeBmiZkKPSdgc-F7QAXl7E
Message-ID: <CAOfDtXNxT+hnS8n+OY6a7n=6UiwgDJo6M3GZx48JgskRKoY=gg@mail.gmail.com>
Subject: Re: Compatibility options for mount(8)
From: Robert Millan <rmh@freebsd.org>
To: Jeremy Chadwick <jdc@koitsu.org>
Content-Type: text/plain; charset=UTF-8
Cc: freebsd-fs@freebsd.org
X-BeenThere: freebsd-fs@freebsd.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: Filesystems <freebsd-fs.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/freebsd-fs>,
 <mailto:freebsd-fs-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-fs>
List-Post: <mailto:freebsd-fs@freebsd.org>
List-Help: <mailto:freebsd-fs-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-fs>,
 <mailto:freebsd-fs-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 09 Jul 2013 14:47:47 -0000

Hi Jeremy,

2013/7/2 Jeremy Chadwick <jdc@koitsu.org>:
> On Tue, Jul 02, 2013 at 01:11:52AM +0200, Robert Millan wrote:
> Minor but are well-justified given quality of code:
>
> 1. Put "n" in alphabetical order/after "l" and not at the end of the
> getopt() string, i.e.:
>
>         while ((ch = getopt(argc, argv, "adF:fLlno:prt:uvw")) != -1)

Will do. Thanks for the correction.

> 2. Please use strncmp().  I know other parts of the same code use strcmp()
> and those should really be improved at some other time, but while you're
> already there you might as well use strncmp() (you'll see others have
> done the same), i.e.:
>
>                         } else if (strncmp(p, "remount", 7) == 0) {

What is the rationale behind this?

> 3. mount(8) man page should reflect these (IMO).  Attached is the diff
> for that; wording based off of some other man pages.

Thank you.

--
Robert Millan