From owner-svn-ports-head@FreeBSD.ORG  Tue Feb  4 20:31:36 2014
Return-Path: <owner-svn-ports-head@FreeBSD.ORG>
Delivered-To: svn-ports-head@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTPS id 958F8FC1;
 Tue,  4 Feb 2014 20:31:36 +0000 (UTC)
Received: from prod2.absolight.net (mx3.absolight.net
 [IPv6:2a01:678:2:100::25])
 (using TLSv1 with cipher ADH-CAMELLIA256-SHA (256/256 bits))
 (No client certificate requested)
 by mx1.freebsd.org (Postfix) with ESMTPS id 528EC17B4;
 Tue,  4 Feb 2014 20:31:36 +0000 (UTC)
Received: from prod2.absolight.net (localhost [127.0.0.1])
 by prod2.absolight.net (Postfix) with ESMTP id E3456BDC64;
 Tue,  4 Feb 2014 21:31:34 +0100 (CET)
Received: from atuin.in.mat.cc (atuin.in.mat.cc [79.143.241.205])
 by prod2.absolight.net (Postfix) with ESMTPA id B9AA3BDC5C;
 Tue,  4 Feb 2014 21:31:34 +0100 (CET)
Received: from localhost (localhost [127.0.0.1])
 by atuin.in.mat.cc (Postfix) with ESMTP id EC378CDADFD7;
 Tue,  4 Feb 2014 21:31:33 +0100 (CET)
Date: Tue, 04 Feb 2014 21:31:32 +0100
From: Mathieu Arnold <mat@FreeBSD.org>
To: Max Brazhnikov <makc@freebsd.org>
Subject: Re: svn commit: r342510 - head/games/cutemaze
Message-ID: <F8B0618EB2ADCB61C5A7F77E@atuin.in.mat.cc>
In-Reply-To: <7443970.95gMSVNHBu@mercury.ph.man.ac.uk>
References: <201402041149.s14BnPX0031911@svn.freebsd.org>
 <3033718.ko1yqU3EN4@mercury.ph.man.ac.uk>
 <36D80F89A7D5FF449E4FCBDF@ogg.in.absolight.net>
 <7443970.95gMSVNHBu@mercury.ph.man.ac.uk>
X-Mailer: Mulberry/4.0.8 (Mac OS X)
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Content-Disposition: inline
Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org,
 ports-committers@freebsd.org
X-BeenThere: svn-ports-head@freebsd.org
X-Mailman-Version: 2.1.17
Precedence: list
List-Id: SVN commit messages for the ports tree for head
 <svn-ports-head.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-ports-head>,
 <mailto:svn-ports-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-ports-head/>
List-Post: <mailto:svn-ports-head@freebsd.org>
List-Help: <mailto:svn-ports-head-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-ports-head>,
 <mailto:svn-ports-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 04 Feb 2014 20:31:36 -0000

+--On 4 f=C3=A9vrier 2014 20:08:50 +0000 Max Brazhnikov <makc@freebsd.org>
wrote:
| On Tue, 04 Feb 2014 17:31:39 +0100 Mathieu Arnold wrote:
|> Most substitutions are right, I mean, in a perl port, I want PERL_VER,
|> and SITE_PERL, and PERL5_MAN3, and... there are a few like QT_BINDIR
|> which shouldn't go in it, but it feels more like having a blacklist than
|> a whitelist.
|=20
| Blacklist can be longer than whitelist :).

Remains to be seen :-)

| I'll think about it. The problem is not specific to Qt ports. I've
| already been beaten when KDE4_VERSION was improperly used for library
| version (just coincidence). In fact, QT_BINDIR could be easily hidden for
| other ports, but I'd like to see general solution.

Well, I was considering removing macros with only 1 and 2 caracters, I
don't remember why I did not.

--=20
Mathieu Arnold