From owner-dev-commits-src-all@freebsd.org Thu Feb 18 10:14:54 2021 Return-Path: Delivered-To: dev-commits-src-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 6951A5321C0; Thu, 18 Feb 2021 10:14:54 +0000 (UTC) (envelope-from rscheff@gmx.at) Received: from mout.gmx.net (mout.gmx.net [212.227.17.21]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "mout.gmx.net", Issuer "TeleSec ServerPass Class 2 CA" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Dh9Yp0fVZz3mw7; Thu, 18 Feb 2021 10:14:53 +0000 (UTC) (envelope-from rscheff@gmx.at) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1613643291; bh=wsdgtuuMjF3w8+x8gBBSNqGVP7kwN+9Fz01QU92ZpDA=; h=X-UI-Sender-Class:From:To:Cc:Subject:Date:In-Reply-To:References; b=VSGaiKKHRMkm4Xsy37O3NXmeOx8SWb6c+xMfjmTPFeMxuGHwYOL4OnSOewtLODbFu wWXl//Dlp9fk5CiBdJckWguTvn4ohJ1WAB1tiN5sU7d4D1QAcOx2PLgdPHf+P0Ixtw Pu+OZUzghWsT0a/Fl5+tIR66S6sSxq4TB3KMTEME= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from [212.95.5.214] ([212.95.5.214]) by msvc-mesg-gmx023.server.lan (via HTTP); Thu, 18 Feb 2021 11:14:51 +0100 MIME-Version: 1.0 Message-ID: From: rscheff@gmx.at To: Navdeep Parhar Cc: dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org, Randall Stewart , src-committers Subject: Re: Re: git: 0a4f851074a3 - main - Fix another pesky missing #ifdef TCPHPTS Content-Type: text/plain; charset=UTF-8 Date: Thu, 18 Feb 2021 11:14:51 +0100 In-Reply-To: References: <202102180627.11I6Rxa4030228@gitrepo.freebsd.org> X-Provags-ID: V03:K1:wFrKxsVDDmXDW0vEHokhfAPyKEwa62/ApO2p0mLOSkWSqhWyRdCmmdH3vwW1MdjHZ+YRj if6fd5j3QvrLTdFInxDC/74kODtiOGg8E45AGG4kOzvjji1fov4jb8IBYJm0z+cQ7YWY2d2a4rzr cI2qrqVsItVx+5So0FV8zsPfGMCAIwa/TlBWGa/BVnl9ChleynRHvRrRbcZvxfyfP5vhnS69JEPy eRqcY+FJX3L8kk7aCm9ymdFdf5acbhk4nRsF/wOdZBjdAOqgxFIxxBiqPKFpKXL7xBwq+D+7+n/k gA= X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:ARKyZyxohp4=:Fi8LpkqpkX1VtNKSIsn8Ok dl8OYqaQfK4yOuUtReO1nCjcd3Xv7CgVuIoIsfpyj5epxGyQqFv38+LVzSimlJFaqqVJ5p4Ac N+MHmOeKkgA67rqdA+gnbWdps6raMQUMUPcdiZHKvo85TADFCmrLoUO0v6DoKVrqb1BPUC0AK nmh81MVlKayh2LHmg2pa5vGl/T8a4EjVpfKy4PzrLGVN4e1gE6Tq3+3YT2cBU6Npz4RnfrbaZ hEsLJ8BcX90M833SZUjDe387TKmGxMWSMvrNCPohSdTLuEvSLNJPJo2GhoA/SIz/koCIuni6u CYjwn9QhnzBbGkOckd8Tw6uwFz7PGPvYf5pcC8uuMZpSCt8jtQmVeLZ2jeGmZg+VPIwCs0OAq H6hHL2mmuyBIN+19NnchnTl+ThyFLb4+eft/AyVBkT+Osd1kLNDzuvC72HuhMaND9ScDa22nc IxYzX+JWJM9COz7keE0m8mCB9hnPRyrFRzejjF7n6zKLb2ZqZcrz6QPSNzTO0IathAbl0Ax3t ec1GwbL/TGw6kTwqHMHPwKXUrxwiXilxocXVvVW8V5DfIZsdsGpqRa0aqIP0tknSkVRInb6L4 jFSiA8YXhXZEY= Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: 4Dh9Yp0fVZz3mw7 X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[] X-BeenThere: dev-commits-src-all@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Commit messages for all branches of the src repository List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 18 Feb 2021 10:14:54 -0000 I remember having added this in the driver to expose the tos byte for tso/= lro operations; interesting that it is unused now. Hope the IP ECN flags are still propagated in the fastpath.... Gesendet mit der GMX Mail App Am 18.02.21 um 09:48 schrieb Navdeep Parhar > I still get build failures in tcp_lro.c for i386/amd64 LINT-NOINET > builds after this. > > --- tcp_lro.o --- > /storage/src/head/sys/netinet/tcp_lro.c:1359:10: error: unused > variable 'iptos' [-Werror,-Wunused-variable] > uint8_t iptos; > ^ > 1 error generated. > *** [tcp_lro.o] Error code 1 > > make[5]: stopped in /storage/obj/storage/src/head/amd64.amd64/sys/LINT-N= OINET > > Regards, > Navdeep > > On Wed, Feb 17, 2021 at 10:28 PM Randall Stewart wrote= : > > > > The branch main has been updated by rrs: > > > > URL: https://cgit.FreeBSD.org/src/commit/?id=3D0a4f851074a3ca74cd4859c= 20e7d9807b2aeca65 > > > > commit 0a4f851074a3ca74cd4859c20e7d9807b2aeca65 > > Author: Randall Stewart > > AuthorDate: 2021-02-18 06:27:30 +0000 > > Commit: Randall Stewart > > CommitDate: 2021-02-18 06:27:30 +0000 > > > > Fix another pesky missing #ifdef TCPHPTS > > --- > > sys/netinet/tcp_lro.c | 2 ++ > > 1 file changed, 2 insertions(+) > > > > diff --git a/sys/netinet/tcp_lro.c b/sys/netinet/tcp_lro.c > > index 199b7f9a79a0..a8e751b67071 100644 > > --- a/sys/netinet/tcp_lro.c > > +++ b/sys/netinet/tcp_lro.c > > @@ -470,6 +470,7 @@ tcp_lro_rx_ipv4(struct lro_ctrl *lc, struct mbuf *= m, struct ip *ip4, > > } > > #endif > > > > +#ifdef TCPHPTS > > static void > > tcp_lro_log(struct tcpcb *tp, struct lro_ctrl *lc, > > struct lro_entry *le, struct mbuf *m, int frm, int32_t tcp= _data_len, > > @@ -520,6 +521,7 @@ tcp_lro_log(struct tcpcb *tp, struct lro_ctrl *lc, > > 0, &log, false, &tv); > > } > > } > > +#endif > > > > static void > > tcp_flush_out_le(struct tcpcb *tp, struct lro_ctrl *lc, struct lro_en= try *le) >