From owner-freebsd-arch@FreeBSD.ORG Mon Apr 7 18:30:23 2008 Return-Path: Delivered-To: freebsd-arch@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id E57C2106566B; Mon, 7 Apr 2008 18:30:22 +0000 (UTC) (envelope-from delphij@delphij.net) Received: from tarsier.delphij.net (delphij-pt.tunnel.tserv2.fmt.ipv6.he.net [IPv6:2001:470:1f03:2c9::2]) by mx1.freebsd.org (Postfix) with ESMTP id 76B3C8FC25; Mon, 7 Apr 2008 18:30:22 +0000 (UTC) (envelope-from delphij@delphij.net) Received: from tarsier.geekcn.org (tarsier.geekcn.org [202.108.54.204]) (using TLSv1 with cipher ADH-CAMELLIA256-SHA (256/256 bits)) (No client certificate requested) by tarsier.delphij.net (Postfix) with ESMTPS id 9A07A28449; Tue, 8 Apr 2008 02:30:21 +0800 (CST) Received: from localhost (tarsier.geekcn.org [202.108.54.204]) by tarsier.geekcn.org (Postfix) with ESMTP id 4016EEBB9FF; Tue, 8 Apr 2008 02:30:21 +0800 (CST) X-Virus-Scanned: amavisd-new at geekcn.org Received: from tarsier.geekcn.org ([202.108.54.204]) by localhost (mail.geekcn.org [202.108.54.204]) (amavisd-new, port 10024) with ESMTP id YZ4AEy+G7u9r; Tue, 8 Apr 2008 02:30:16 +0800 (CST) Received: from LI-Xins-MacBook.local (71.5.7.139.ptr.us.xo.net [71.5.7.139]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by tarsier.geekcn.org (Postfix) with ESMTPSA id 90E2BEBB9C9; Tue, 8 Apr 2008 02:30:15 +0800 (CST) DomainKey-Signature: a=rsa-sha1; s=default; d=delphij.net; c=nofws; q=dns; h=message-id:date:from:reply-to:organization:user-agent: mime-version:to:cc:subject:references:in-reply-to: x-enigmail-version:openpgp:content-type; b=BWk9Hp8qM5d637J1fUwdaXRGh1OYaTgZzE5l6EX0Qfe3OhRmrv4ojqSpXZvbYGKGE tRH/GiJifJQvWcERprTLQ== Message-ID: <47FA6833.8080904@delphij.net> Date: Mon, 07 Apr 2008 11:30:11 -0700 From: LI Xin Organization: The FreeBSD Project User-Agent: Thunderbird 2.0.0.12 (Macintosh/20080213) MIME-Version: 1.0 To: freebsd-arch@freebsd.org References: <20080407181250.6733810656C9@hub.freebsd.org> In-Reply-To: <20080407181250.6733810656C9@hub.freebsd.org> X-Enigmail-Version: 0.95.6 OpenPGP: url=http://www.delphij.net/delphij.asc Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="------------enig0160B57ADC3280A9343DD942" Cc: delphij@FreeBSD.ORG Subject: Re: [src] cvs commit: src/sys/ufs/ufs ufs_gjournal.c X-BeenThere: freebsd-arch@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: d@delphij.net List-Id: Discussion related to FreeBSD architecture List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 07 Apr 2008 18:30:23 -0000 This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enig0160B57ADC3280A9343DD942 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: quoted-printable Picking a random commit: > FreeBSD src repository >=20 > Modified files: > sys/ufs/ufs ufs_gjournal.c=20 > Log: > Correct function name in panic(). > =20 > Reported by: kensmith > =20 > Revision Changes Path > 1.3 +1 -1 src/sys/ufs/ufs/ufs_gjournal.c > _______________________________________________ > cvs-all@freebsd.org mailing list > http://lists.freebsd.org/mailman/listinfo/cvs-all > To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org" >=20 >=20 > Index: src/sys/ufs/ufs/ufs_gjournal.c > diff -u src/sys/ufs/ufs/ufs_gjournal.c:1.2 src/sys/ufs/ufs/ufs_gjournal= =2Ec:1.3 > --- src/sys/ufs/ufs/ufs_gjournal.c:1.2 Mon May 28 00:28:15 2007 > +++ src/sys/ufs/ufs/ufs_gjournal.c Mon Apr 7 18:12:37 2008 > @@ -82,7 +82,7 @@ > cgbno =3D fsbtodb(fs, cgtod(fs, cg)); > } > if ((u_int)ino >=3D fs->fs_ipg * fs->fs_ncg) > - panic("ffs_freefile: range: dev =3D %s, ino =3D %lu, fs =3D %s", > + panic("ufs_gjournal_modref: range: dev =3D %s, ino =3D %lu, fs =3D %= s", > devtoname(dev), (u_long)ino, fs->fs_fsmnt); > if ((error =3D bread(devvp, cgbno, (int)fs->fs_cgsize, NOCRED, &bp)))= { > brelse(bp); Is it suitable to use something like __func__ here? I mean, will the=20 usage of __func__ encouraged practice for base/kernel code or not? Cheers, --=20 Xin LI http://www.delphij.net/ FreeBSD - The Power to Serve! --------------enig0160B57ADC3280A9343DD942 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.7 (Darwin) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org iD8DBQFH+mgzOfuToMruuMARCmFcAJsEWl5kqDgehV1wWWnbZ1Rdu8smqACfSmvG /V3tE/pUv/+lUXj51rQge+w= =8te6 -----END PGP SIGNATURE----- --------------enig0160B57ADC3280A9343DD942--