From owner-cvs-all Sat Apr 20 18:25:59 2002 Delivered-To: cvs-all@freebsd.org Received: from fledge.watson.org (fledge.watson.org [204.156.12.50]) by hub.freebsd.org (Postfix) with ESMTP id AB96F37B41A; Sat, 20 Apr 2002 18:25:54 -0700 (PDT) Received: from fledge.watson.org (fledge.pr.watson.org [192.0.2.3]) by fledge.watson.org (8.11.6/8.11.6) with SMTP id g3L1Pjw95193; Sat, 20 Apr 2002 21:25:45 -0400 (EDT) (envelope-from robert@fledge.watson.org) Date: Sat, 20 Apr 2002 21:25:44 -0400 (EDT) From: Robert Watson X-Sender: robert@fledge.watson.org To: "David O'Brien" Cc: "Andrey A. Chernov" , "Jacques A. Vidrine" , cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/crypto/openssh servconf.c session.c In-Reply-To: <20020420161149.B91386@dragon.nuxi.com> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG On Sat, 20 Apr 2002, David O'Brien wrote: > On Sat, Apr 20, 2002 at 11:02:46AM -0400, Robert Watson wrote: > > > > On Sat, 20 Apr 2002, Andrey A. Chernov wrote: > > > > > On Sat, Apr 20, 2002 at 10:46:22 -0400, Robert Watson wrote: > > > > pain. We've already had updates stalled by >6-8 months because of many > > > > local changes, so that's a problem we need to be very careful to avoid. > > > > > > You know, the only way to avoid that is to submit local changes back to > > > official maintainers, not to lost them every upgrade or like! > > > > And the burden there lies with the people making the local modifications. > > Not quite... or there would be a lot of FreeBSD additions I would have > tossed out in various pieces of code. Once something gets used for a > while, it seems the updater has the responsibility to keep the > additions. I wasn't disagreeing with that. I was asserting that *if* you make a local modification to some piece of imported code of this sort, then *you* should take responsibility for feeding that back to the source of the code. I.e., If I go and start tweaking sshd, I should take some responsibility for attempting to get the tweaks back into the OpenSSH distribution. What I said did not apply to the long-term maintenance of local hacks to the code, although I think the real issue here is that OpenSSH had simply become unmaintainable due to the sheer number of local hacks. While local changes are necessary, as I said in my original e-mail, we need to avoid the gratuitous ones, and make an effort to merge the changes back where possible. Robert N M Watson FreeBSD Core Team, TrustedBSD Project robert@fledge.watson.org NAI Labs, Safeport Network Services To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message