Date: Sun, 16 Aug 2015 10:57:00 -0600 From: Ian Lepore <ian@freebsd.org> To: Matthew Seaman <matthew@FreeBSD.org> Cc: freebsd-stable@freebsd.org, Cy Schubert <cy@FreeBSD.org> Subject: Re: 10.2: ntp update breaks DCF77 clock Message-ID: <1439744220.242.87.camel@freebsd.org> In-Reply-To: <55D03771.9000605@FreeBSD.org> References: <slrnmsunlo.104l.naddy@lorvorc.mips.inka.de> <55D03771.9000605@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sun, 2015-08-16 at 08:10 +0100, Matthew Seaman wrote: > On 15/08/2015 16:46, Christian Weisgerber wrote: > > The ntp code is not very transparent, but I think the root cause > > are the ntp/config.h changes that came with the 4.2.8p3 update. A > > number of previously disabled obscure clock drivers were enabled, > > but crucially CLOCK_RAWDCF was disabled, and this is the PARSE > > subdriver needed to use the popular DCF77 serial receivers. > > > > Frankly, it looks like we used to have a carefully considered > > selection of clock drivers which has been blindly splattered with > > the upstream defaults in the last update. > > Hmmm.... I suggest raising a PR with patches to revert the changes in > the set of enabled clock drivers (or merge with the current list). It's > not going to get you a working DCF77 receiver in a -RELEASE version any > time soon, I'm afraid, as you'll have to wait until the next release for > the changes to percolate down, but having a sensible list of enabled > clock drivers in base is definitely a good move. > I wonder: is there a reason to not enable all (or most of) the refclocks in base and in ports? Well, at least all the ones that build on freebsd... a disturbing number of them fail to compile because they include linux-specific header files. Hmm, I just noticed that we actually compile most of the refclocks, but we don't enable them in the config. It looks like the cost of enabling all the refclocks that compile properly is pretty small... doing so increased the size of ntpd from 745K to 801K for me. I'll attach the diff just to save someone else the trouble of iteratively figuring out which ones won't build, but I think there may be a more-proper way to generate this config by tweaking the autotools stuff. -- Ian
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?1439744220.242.87.camel>