From owner-freebsd-wireless@FreeBSD.ORG Mon Aug 12 17:29:10 2013 Return-Path: Delivered-To: freebsd-wireless@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTP id D6E9281F; Mon, 12 Aug 2013 17:29:10 +0000 (UTC) (envelope-from adrian.chadd@gmail.com) Received: from mail-wg0-x22c.google.com (mail-wg0-x22c.google.com [IPv6:2a00:1450:400c:c00::22c]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 495422EAD; Mon, 12 Aug 2013 17:29:10 +0000 (UTC) Received: by mail-wg0-f44.google.com with SMTP id l18so5618083wgh.11 for ; Mon, 12 Aug 2013 10:29:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:date:message-id:subject :from:to:cc:content-type; bh=LlH2tuKSL6BMPQNcc9gqIIVPJd2YevwzNjmr9654ciU=; b=JfB3ofT3mVKLpIsNF5/11wf2B38ZCx8wiAD0p8gpsqTDbGCzgob22ombwCT7LU49u7 Hn15riW9HbIPpYpZSJdq67LiOQJkfrwEMHP1BU2lL3T4AO+FRhS2yRSPVy5JTaAkp58t LBz7Id8jF/K+pxOv2oUNyau+JDg/H1XdOCkwWkxaQSe6gX0MWmPlLMiImURN8sBK9UJw u10RXcswPjeIdV7ZQM212zSfzLWCTiGhxE7aIg2sOVkyNtP/FEuHjTncZ/LIK49lgOla NxnP8oZXCAGxIqA+IbtPcnwQyB+5jRLIE5kcQhgIFRT2C1heK9tOk0L/V2RRsUrcP4ns Hq+w== MIME-Version: 1.0 X-Received: by 10.180.211.206 with SMTP id ne14mr85128wic.30.1376328548513; Mon, 12 Aug 2013 10:29:08 -0700 (PDT) Sender: adrian.chadd@gmail.com Received: by 10.217.116.136 with HTTP; Mon, 12 Aug 2013 10:29:08 -0700 (PDT) In-Reply-To: <238348209.20130812212328@serebryakov.spb.ru> References: <238348209.20130812212328@serebryakov.spb.ru> Date: Mon, 12 Aug 2013 10:29:08 -0700 X-Google-Sender-Auth: 0YbgY07jjtpttCRWvib7HIqrhdY Message-ID: Subject: Re: ath as AP panics From: Adrian Chadd To: Lev Serebryakov Content-Type: text/plain; charset=ISO-8859-1 Cc: freebsd-wireless@freebsd.org X-BeenThere: freebsd-wireless@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Discussions of 802.11 stack, tools device driver development." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 12 Aug 2013 17:29:10 -0000 Hi, So the if_transmit() change did change a few things. if_start() / *_ENQUEUE() clears m_nextpkt(). I'd like to know where m_nextpkt() is NOT being cleared. How about triggering it quickly - put in a panic there rather than NULL'ing it, then when it immediately panics, do a backtrace? -adrian On 12 August 2013 10:23, Lev Serebryakov wrote: > Hello, Freebsd-wireless. > > r254238 with ath used as AP panics in fragment processing. This patch from > adrian: > > Index: ieee80211_output.c > =================================================================== > --- ieee80211_output.c (revision 254224) > +++ ieee80211_output.c (working copy) > @@ -458,6 +458,16 @@ > m->m_flags &= ~(M_80211_TX - M_PWR_SAV - M_MORE_DATA); > > /* > + * Complain if m->m_nextpkt is set. > + * > + * The caller should've pulled this apart for us. > + */ > + if (m->m_nextpkt != NULL) { > + printf("%s: m_nextpkt not NULL?!\n", __func__); > + m->m_nextpkt = NULL; > + } > + > + /* > * Bump to the packet transmission path. > * The mbuf will be consumed here. > */ > > > replaces panic with lot of debug output and looks like not a solution, but > dirty hack. Now I'm trying r254250 with this patch, but it looks like it > should be same as r254238, as nothing 802.11-related was changed in-between. > > -- > // Black Lion AKA Lev Serebryakov > > _______________________________________________ > freebsd-wireless@freebsd.org mailing list > http://lists.freebsd.org/mailman/listinfo/freebsd-wireless > To unsubscribe, send any mail to "freebsd-wireless-unsubscribe@freebsd.org"