From nobody Fri Feb 28 15:59:06 2025 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4Z4CZ25BSFz5m8fJ; Fri, 28 Feb 2025 15:59:06 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R10" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Z4CZ24Xxtz3vfq; Fri, 28 Feb 2025 15:59:06 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1740758346; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=w253Sf7EY7l9d/1RYa1u1uzptYJfTy68skQBQP+F+hY=; b=rOi1NVA45nEMC9QSxrjWEMRbouBh88NGF1FaTrAlzpjzNUSprhF5gLOhnAP5mW2dAUgO03 wEwFRxkF+w4LhNrRY7D6MAqIJJSMIWoh4eu8bK9/zW4M8RDsfhLxjCJxeWTPap9ZXHDis6 QJH8wKV2iUHVr2PY+K20fQ/8EiuniHytRMxLAGnsUDDnABwHe1nFu/PJGtIjTMUal2W1ja wf+yfhddOQ61yHldUNX58tOgRGmfEbnaw/0w7VwGFgoCWLxa+8Oy33MO3Uy7Pt1J2fq07g k3pAQWC6jEfBG2/YYn/jGK32filOsl8z/1oKNOcqdx+pzo+aVgea5OQrxx2A0A== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1740758346; a=rsa-sha256; cv=none; b=mUzY2IQlCklaOE1VbvkzdMGZCZ5f6uGdk+yPkoJqsxAvwVWeLbY++XWVaoTbD+TQ9v4PpP lq54PzU1yXyBWb4n5OkjCGIt2fJLKjKxC789qQMIYJQWPOackViBXbE+S72eoxouUq28UH W5Hw4t7Da0s9LChK/jUIg1jj56mIX2zzPtgY0MCALSSfZqOoGRuzPGj25AHZjHvhkcB4aX 6iG2D96gkN/X9RQoLuX2NIvbnlsc0IiozqCEQAvNI6DkuPMrDtdr0Bjat21oi00LNp0xc8 5rL4/uSCg/J7c7oEJj5hBnboZu94n/RNffVtWmNKgV+9sQJwdVX9vtWXyH2USA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1740758346; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=w253Sf7EY7l9d/1RYa1u1uzptYJfTy68skQBQP+F+hY=; b=HZJ/ylRdDDP7ZKCIGi9MC25BeR/ZjtfCN7KSO4fAJwDC3Ega7Ze1U0vwE0UAOVPMYAoTHm 9d8lpBthSnZXsEzfKROEehHQG3Yzua6UAgqn2OcuH8Ew+SdM1Id5FYSVNzl2Sq8/ARn/ur zpGXpEggCEK1Qx15ddgOhA+Hx8ZTi8J9ZY28744a57bqeblIIsBJDe9yA3WLtxoCEjVtqj wkAacHTbnPi4rgdfOFHUvzuN3f4mExKZxDwBBOdjjNnXs/O+BVeUPECtpq+JQYV1pID0Ji 45dETjWF0W3KEwSY9RSal+aaSYQWGxk49N5RSfiJJD+3nDUadFZI7oOmuyoB9g== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4Z4CZ2450Xzc7X; Fri, 28 Feb 2025 15:59:06 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 51SFx60q000889; Fri, 28 Feb 2025 15:59:06 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 51SFx6vd000886; Fri, 28 Feb 2025 15:59:06 GMT (envelope-from git) Date: Fri, 28 Feb 2025 15:59:06 GMT Message-Id: <202502281559.51SFx6vd000886@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Cy Schubert Subject: git: 859aa726fb86 - stable/14 - ntp: NULL pointer deref when create_interface() fails List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: cy X-Git-Repository: src X-Git-Refname: refs/heads/stable/14 X-Git-Reftype: branch X-Git-Commit: 859aa726fb8642d8f329c7a34c51356c4eaeae88 Auto-Submitted: auto-generated The branch stable/14 has been updated by cy: URL: https://cgit.FreeBSD.org/src/commit/?id=859aa726fb8642d8f329c7a34c51356c4eaeae88 commit 859aa726fb8642d8f329c7a34c51356c4eaeae88 Author: Cy Schubert AuthorDate: 2025-02-28 15:46:23 +0000 Commit: Cy Schubert CommitDate: 2025-02-28 15:59:00 +0000 ntp: NULL pointer deref when create_interface() fails Fix NULL pointer dereference when create_interface() fails in update_interfaces(). The upstream bug report says a typo was introduced by https://bk.ntp.org/ntp-dev/ntpd/ntp_io.c?PAGE=diffs&REV=66175036PETA6g__fON8oNrjL54Ttw. ep should have been ep2. Fix obtained from upstream bug report. PR: 285065 Upstream bug: https://bugs.ntp.org/show_bug.cgi?id=3939 (cherry picked from commit 628715fdcc9f2226bfe0f4ebe381aaa7761cb6cc) --- contrib/ntp/ntpd/ntp_io.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/contrib/ntp/ntpd/ntp_io.c b/contrib/ntp/ntpd/ntp_io.c index 9d79fe493d9b..12a61ccb1d2c 100644 --- a/contrib/ntp/ntpd/ntp_io.c +++ b/contrib/ntp/ntpd/ntp_io.c @@ -1921,7 +1921,7 @@ update_interfaces( } else { DPRINT_INTERFACE(3, - (ep, "updating ", " new - FAILED")); + (ep2, "updating ", " new - FAILED")); msyslog(LOG_ERR, "cannot bind address %s",