From owner-svn-src-all@freebsd.org Mon Nov 20 16:57:05 2017 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 78D78DF0EC9; Mon, 20 Nov 2017 16:57:05 +0000 (UTC) (envelope-from carpeddiem@gmail.com) Received: from mail-io0-x22e.google.com (mail-io0-x22e.google.com [IPv6:2607:f8b0:4001:c06::22e]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 419E864B56; Mon, 20 Nov 2017 16:57:05 +0000 (UTC) (envelope-from carpeddiem@gmail.com) Received: by mail-io0-x22e.google.com with SMTP id i38so16427794iod.2; Mon, 20 Nov 2017 08:57:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=vizLhdMJBtKlp2/yhy9NSSL6KcnBeC1IP+HKZ6NRD2c=; b=GgHFiij81Qd9TIC/OBYmFAZiQobBGowB4y8z0b32imk/a9zMximLqsZkdxueMFhqdJ 23YLp+8nsHm4ua5YLUYHDi14QESe6jYCsvtT9J6cfGi+xJmUeJY4tQ9rFyJGtwnAHycp VDMbKoJ8CF7OovB3NyUOyrGdYm7/I0IQsa2vikuGucD51dCzuS15R1Pkj0g9yJLPe48g 5SfaIK+JB3YW86+Jo9/fJGlnXI854HM27QIPwE2Qr/ap1V6nDTUCpCRDDBURDpPH/ZVN 5fAoe7+ED4CNoAj57dz2LR7KvSTXuR3dotZXW6pdD/Nqfs5GWxKkAxaIVKzaUag2h0I6 65Pg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc; bh=vizLhdMJBtKlp2/yhy9NSSL6KcnBeC1IP+HKZ6NRD2c=; b=WEhrAux9VW8HpB7zH70XfrMTiepRt5i3mtShZAkPtRQzbKc/qoxcDbo6hoF3uLcGgf 0/Sy5IGHDqLepHK/nTrCa+2iplgWsvCB26kNsQAN6KsnRKlpfYcnH1ABUL+I9JTUU68q As4YSaanQKPnkWaRplPeJqroS56UqAq9dEA8bUCbvOhvp0LkiKShNrnHbe6UE1PIkAD1 HVCofmXsHmHz+vKIrB0ruDSC5nRXfxH2OK282hY87TpSWZRbIhFt4O7Az5qvXePb8LX7 IzkYnxNRnFehvKEMjJVvdHFRs4CPrdDMa0+LmxO2SWiIgr8fBYsAhCaTwXQXRUWuoiav PJBA== X-Gm-Message-State: AJaThX5+3j2WKWdpMa9NJ8ylz6Iw9Gd6pDdRwaRZWH99cMVStQIUNtaX c/ZPHFLb7J07ZKNXOjAJhDj6B/1tttZsmd7BG3Q= X-Google-Smtp-Source: AGs4zMb2oJLM8wa68S7FJCydaShs5dPhpkdjMnAAiAo20E4lLp2zHOujdq+ume4Kpmd9xnTSrbv9K9dHpEWBcTSk0tg= X-Received: by 10.107.164.156 with SMTP id d28mr13072917ioj.257.1511197024349; Mon, 20 Nov 2017 08:57:04 -0800 (PST) MIME-Version: 1.0 Sender: carpeddiem@gmail.com Received: by 10.107.14.208 with HTTP; Mon, 20 Nov 2017 08:56:43 -0800 (PST) In-Reply-To: <20171119173822.J974@besplex.bde.org> References: <201711190031.vAJ0VE9m016670@repo.freebsd.org> <20171119173822.J974@besplex.bde.org> From: Ed Maste Date: Mon, 20 Nov 2017 11:56:43 -0500 X-Google-Sender-Auth: TpakeNVdgLOPkuYoFVCU8fMMwDQ Message-ID: Subject: Re: svn commit: r325988 - head/sys/libkern To: Bruce Evans Cc: src-committers , svn-src-all@freebsd.org, svn-src-head@freebsd.org Content-Type: text/plain; charset="UTF-8" X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 20 Nov 2017 16:57:05 -0000 Hi Bruce, notes on a few of the points you raised (I'll look at others later): On 19 November 2017 at 04:07, Bruce Evans wrote: > > The vendor version is in libc/string. It has been ANSIfied, but the > libkern version has large churning to "optimize" it. It is the libkern > version that should have been optimized, since bcmp is unimportant in > the kernel and in most applications, but applications have a wider range > so a few might benefit from optimizing it. I presume you meant "it is the _libc_ version that should have been optimized", but could also read this as a distinction between optimized and scare-quotes "optimized." > bcmp is actually optimized > in the kernel in support.[sS] for all arches except powerpc and riscv, > so optimizing the kernel MI version of it is especially unimportant. > In libc where MD optimizations are more important, they are also not > done for arm, arm64 and sparc64. This could make a nice small project for someone to take on. > - libc version copyright comment not marked for indent protection using > "/*-" (this has been subverted to have another meaning which I forget). I don't believe there's another meaning. IIRC imp@ has pointed out that it means precisely what you've mentioned above. >> Modified: head/sys/libkern/cmpdi2.c >> Modified: head/sys/libkern/divdi3.c >> Modified: head/sys/libkern/lshrdi3.c > > Like ashrdi3.c (not ANSIfied in libc/quad). Ok, I will update libc/quad to match. > The above declaration was already correctly ANSIfied in libc/gmon. This > unimproves the style by keeping the comment misplaced at the right of the > code where it is a larger style bug than before -- not the line is too long. > ANSIfication in libc/gmon put it on a separate line. Will update the comment along with other mcount tidying. >> Modified: head/sys/libkern/strcmp.c > > The vendor version is in libc/string. It has been ANSIfied, but the commit > that did that also made another style fix. This change catches up with half > of the older change. Will update.