Date: Fri, 16 Sep 2011 17:12:28 -0400 From: Arnaud Lacombe <lacombar@gmail.com> To: pyunyh@gmail.com Cc: freebsd-net@freebsd.org, FreeBSD-Current <freebsd-current@freebsd.org> Subject: Re: Queue drop not accounted ? Message-ID: <CACqU3MXjbc=vy-Miij2K9N%2BMHJWNbWXB7%2Boh3hstzy2-orJDwg@mail.gmail.com> In-Reply-To: <20110916194012.GB9916@michelle.cdnetworks.com> References: <CACqU3MWYa7awOO0x1jPNyXq2gccYAL%2B5wzkE6nOqsNGdP0GyeA@mail.gmail.com> <20110916194012.GB9916@michelle.cdnetworks.com>
next in thread | previous in thread | raw e-mail | index | archive | help
Hi, On Fri, Sep 16, 2011 at 3:40 PM, YongHyeon PYUN <pyunyh@gmail.com> wrote: > On Thu, Sep 15, 2011 at 09:25:19PM -0400, Arnaud Lacombe wrote: >> Hi, >> >> Shouldn't packet freed in IFQ_ENQUEUE() because the queue is full be >> accounted as dropped, cf attached patch ? >> > > Hmm, I think err would be set to ENOBUFS for queue full case and > this err will crease ifq_drops. > oh, yeah, I missed the increment not using the accessors after the branch. A. >> Thanks, >> =A0- Arnaud >
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CACqU3MXjbc=vy-Miij2K9N%2BMHJWNbWXB7%2Boh3hstzy2-orJDwg>