From owner-svn-src-all@freebsd.org Fri Jan 26 05:05:27 2018 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id EECA7EC0C71 for ; Fri, 26 Jan 2018 05:05:26 +0000 (UTC) (envelope-from lists@eitanadler.com) Received: from mail-yw0-x231.google.com (mail-yw0-x231.google.com [IPv6:2607:f8b0:4002:c05::231]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 3B75B83451 for ; Fri, 26 Jan 2018 05:05:26 +0000 (UTC) (envelope-from lists@eitanadler.com) Received: by mail-yw0-x231.google.com with SMTP id x62so3844994ywg.11 for ; Thu, 25 Jan 2018 21:05:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=eitanadler.com; s=0xdeadbeef; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=1C9Nw7EhL0S0azdJIJxDVjGKWIsIat1J8V+httszYyM=; b=IbI2u+/aL/J8qPFsXKOn6jgHl/fMt9oprb5zFPtm4hj7KTxmbzUsFzkDx52+m+Z8dX Fx7dxAXXPa9gB9unNp3dOlmKT7KQHFNMb/6r4IFUxiVfkRF0sARxLwsjwCK7YbQKupP2 J28iotxeeYL2N1VLhhUkV8z3fuvznmjrYDn6g= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd-org.20150623.gappssmtp.com; s=20150623; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=1C9Nw7EhL0S0azdJIJxDVjGKWIsIat1J8V+httszYyM=; b=wv12uHYpETKgkc/aEuUkiMuoZPCCUzeNXLnACfZdzDwM9LolA1gY0y7KuylhnwEiTh R2Ii0Q2JHnGO30gjS+eWKpTY0hvE1vJE4VJGJE0ZCF7KX39CukzfsIlcD2Kq36qACHTP 98KWImQDJTsnDP8Fzbwt0ZBQizDCy0oNkWertGYpNf2OUOVCQd5U3UiCLFzU682gJVNH aCOllCMUEyx1k9GzWEFd2H5leVWyKxuZ4OmGA9hcGlDWjZA5THuyh3GCnxQ1IVHxOxZl 1qWMoyC2ChZSE/ZfPc2zYjKzHa/LYfpmTZnN++a6sTa17WA7Vcl2Rr/27Rws428FaqtJ ef8A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc; bh=1C9Nw7EhL0S0azdJIJxDVjGKWIsIat1J8V+httszYyM=; b=s/06bEbt05qIMpx8aV4aPN2PWlEdnF0YI+N8X0en2Qu6DfsEVdSS22VhH+b/BesB40 njw0FEN/i7/i49myAmiTZaNmbZKC9XOHjpLqVhTc6vxBuGjmJdDyK7WRhJDrjXLM/RS6 AxILXVXkg+GqCW5ILo4n8xXAQgojWPaYsymfup6+wOLRHkfpbFst+7TXaxyFjz0HIeeS WsIh6sQLetrLSpQP3B3hv/5dlHDEMGIpA99bwmEkdFIOO+TV8wiukq9JfAtTpYK31mk0 xk01Qq67N4qGKQdof6WRSjo09yw6ghho9sNCY+Oxl3sTnL/xBj7C+EFKMKOOXpJzKMKM FHHg== X-Gm-Message-State: AKwxyteX3vCZr5jTuOLJejvisGk8n6tqXptmsznH7eJzTpOQ4bP91jiu FMYte9frM5APkLS1cpdWWr9TTI5k+axPRYLUs60Kyg== X-Google-Smtp-Source: AH8x227XssUva6Oq24l+fYC0/iQJ8zb37yg9YQZE9rp7iglJShJFoQreuzhKENZgsPC5GwovUlZZs+Dut367Fp0eXtU= X-Received: by 10.13.228.1 with SMTP id n1mr512540ywe.6.1516943125539; Thu, 25 Jan 2018 21:05:25 -0800 (PST) MIME-Version: 1.0 Sender: lists@eitanadler.com Received: by 10.37.223.203 with HTTP; Thu, 25 Jan 2018 21:04:54 -0800 (PST) In-Reply-To: References: <201801260440.w0Q4efhg008105@repo.freebsd.org> From: Eitan Adler Date: Thu, 25 Jan 2018 21:04:54 -0800 X-Google-Sender-Auth: oiP6ineIZrlH9ESmt5JBB8056y0 Message-ID: Subject: Re: svn commit: r328430 - head/sbin/devd To: Matt Joras Cc: Warner Losh , src-committers , svn-src-all@freebsd.org, svn-src-head@freebsd.org Content-Type: text/plain; charset="UTF-8" X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 26 Jan 2018 05:05:27 -0000 On 25 January 2018 at 21:02, Matt Joras wrote: > On Thu, Jan 25, 2018 at 8:52 PM, Warner Losh wrote: >> >> >> On Thu, Jan 25, 2018 at 9:40 PM, Eitan Adler wrote: >>> >>> Author: eadler >>> Date: Fri Jan 26 04:40:41 2018 >>> New Revision: 328430 >>> URL: https://svnweb.freebsd.org/changeset/base/328430 >>> >>> Log: >>> devd: minor nits >>> >>> - mark usage as noreturn >>> - config does not need a virtual destructor >> >> >> Everything needs a virtual destructor... Please back that part of this >> out... >> >> Warner > Needs? If there's not inheritance there's no _need_ to do it, and it's > arguably superfluous. That being said it's also an arguably > superfluous change to remove it. Yeah, I don't think this needs it. That said, readded in 328431. I removed it originally since it was the only virtual function in config and it seemed out of place. At the least, I went looking for what inherited from it. -- Eitan Adler Source, Ports, Doc committer Bugmeister, Ports Security teams