From owner-cvs-all@FreeBSD.ORG Sun May 2 13:02:57 2004 Return-Path: Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 67DFA16A4CE; Sun, 2 May 2004 13:02:57 -0700 (PDT) Received: from TRANG.nuxi.com (trang.nuxi.com [66.93.134.19]) by mx1.FreeBSD.org (Postfix) with ESMTP id 16EC243D1F; Sun, 2 May 2004 13:02:57 -0700 (PDT) (envelope-from obrien@NUXI.com) Received: from dragon.nuxi.com (obrien@localhost [127.0.0.1]) by TRANG.nuxi.com (8.12.11/8.12.10) with ESMTP id i42K2u3X046536; Sun, 2 May 2004 13:02:56 -0700 (PDT) (envelope-from obrien@dragon.nuxi.com) Received: (from obrien@localhost) by dragon.nuxi.com (8.12.11/8.12.11/Submit) id i42K2ttD046535; Sun, 2 May 2004 13:02:55 -0700 (PDT) (envelope-from obrien) Date: Sun, 2 May 2004 13:02:54 -0700 From: "David O'Brien" To: Michael Nottebrock Message-ID: <20040502200254.GB20371@dragon.nuxi.com> References: <200405021310.i42DAoZM055616@repoman.freebsd.org> <20040502171345.GA20168@dragon.nuxi.com> <200405021932.33696.michaelnottebrock@gmx.net> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200405021932.33696.michaelnottebrock@gmx.net> User-Agent: Mutt/1.4.1i X-Operating-System: FreeBSD 5.2-CURRENT Organization: The NUXI BSD Group X-Pgp-Rsa-Fingerprint: B7 4D 3E E9 11 39 5F A3 90 76 5D 69 58 D9 98 7A X-Pgp-Rsa-Keyid: 1024/34F9F9D5 cc: cvs-ports@freebsd.org cc: cvs-all@freebsd.org cc: ports-committers@freebsd.org Subject: Re: cvs commit: ports/x11/kdebase3 Makefile pkg-message ports/x11/kdebase3/files pkg-message X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list Reply-To: obrien@freebsd.org List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 02 May 2004 20:02:57 -0000 On Sun, May 02, 2004 at 07:32:29PM +0200, Michael Nottebrock wrote: > > > Reported by: obrien > > > > Thank you for fixing this, but why didn't you just leave pkg-message > > where it was? Just because it needs fixing up it doesn't have to live in > > the non-standard files/ directory. Please consider moving that and the > > plists back to the main kdebase3 directory. > > I don't think a pkg-message that really isn't one but a template that > needs to be processed first should be visible, so I'd rather hide it in > ${FILESDIR}. Perhaps I should have renamed it to message-template? > Also, our plist bits aren't standard plists (the real plist is > concatenated from them, depending on build options) and thus don't > belong into the portdir, but into ${FILESDIR}. I TOTALLY disagree with this hiding these standard files in ${FILESDIR}. I've been here 10 years and haven't heard of this as a general rule to follow. It certainly isn't documented in the Porter's Handbook. Look at editors/vim, lang/gcc3[1234], astro/xplanet, audio/fmio, biology/distribfold, databases/py-MySQL, devel/cvsweb, devel/perforce, mail/cyrus-imapd, net/samba, sysutils/webmin, textproc/aspell, extproc/ispell, www/squid, x11/xscreensaver, (total of 133 ports) for examples of ports that tweak, modify and/or add major content to ${TMPPLIST} at build-time. Same for pkg-message. See astro/setiathome/Makefile as a correct example. Obfuscating standard ports files does not benefit users and makes the Ports Collection harder to use than it needs to be. -- -- David (obrien@FreeBSD.org)