From owner-freebsd-java@FreeBSD.ORG  Sun Oct 16 18:51:12 2005
Return-Path: <owner-freebsd-java@FreeBSD.ORG>
X-Original-To: java@freebsd.org
Delivered-To: freebsd-java@FreeBSD.ORG
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 97ED516A420;
	Sun, 16 Oct 2005 18:51:12 +0000 (GMT) (envelope-from past@ebs.gr)
Received: from fly.ebs.gr (fly.ebs.gr [62.103.84.177])
	by mx1.FreeBSD.org (Postfix) with ESMTP id B255B43D53;
	Sun, 16 Oct 2005 18:51:11 +0000 (GMT) (envelope-from past@ebs.gr)
Received: from ebs.gr (root@hal.ebs.gr [10.1.1.2])
	by fly.ebs.gr (8.12.9p1/8.12.9) with ESMTP id j9GIoq9V034906;
	Sun, 16 Oct 2005 21:50:52 +0300 (EEST) (envelope-from past@ebs.gr)
Received: from [10.1.1.200] (pptp.ebs.gr [10.1.1.200])
	by ebs.gr (8.13.3/8.12.11) with ESMTP id j9GIp4qp024900;
	Sun, 16 Oct 2005 21:51:05 +0300 (EEST) (envelope-from past@ebs.gr)
Message-ID: <4352A0F8.9030902@ebs.gr>
Date: Sun, 16 Oct 2005 21:50:32 +0300
From: Panagiotis Astithas <past@ebs.gr>
Organization: EBS Ltd.
User-Agent: Mozilla Thunderbird 1.0.7 (X11/20051008)
X-Accept-Language: en-us, en
MIME-Version: 1.0
To: "Mikhail T." <mi@aldan.algebra.com>
References: <200510161507.j9GF7ACB003843@blue.virtual-estates.net>
In-Reply-To: <200510161507.j9GF7ACB003843@blue.virtual-estates.net>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Cc: java@freebsd.org, phantom@freebsd.org
Subject: Re: JDK should use system's zlib
X-BeenThere: freebsd-java@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Porting Java to FreeBSD <freebsd-java.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-java>,
	<mailto:freebsd-java-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-java>
List-Post: <mailto:freebsd-java@freebsd.org>
List-Help: <mailto:freebsd-java-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-java>,
	<mailto:freebsd-java-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 16 Oct 2005 18:51:12 -0000

Mikhail T. wrote:
> Hello!
> 
> The system's zlib is much newer and better tested on our various
> platforms.
> 
> JDKs should use it instead of building their own. Attached is the
> patch for ready to be dropped into jdk15/files.
> 
> Just to be sure, a wrong header file is not picked up somewhere
> else in the tree, the little diff below prevents the bundled zlib-1.1.3
> from even being extracted:
> 
> Index: Makefile
> ===================================================================
> RCS file: /home/pcvs/ports/java/jdk15/Makefile,v
> retrieving revision 1.94
> diff -U2 -r1.94 Makefile
> --- Makefile	13 Oct 2005 15:19:18 -0000	1.94
> +++ Makefile	16 Oct 2005 15:04:57 -0000
> @@ -307,2 +307,4 @@
>  
>  .include <bsd.port.post.mk>
> +
> +EXTRACT_AFTER_ARGS+=	-x '*/zlib-*/*'
> 
> 
> Please, test... Something like this should also be done to use the
> already installed libjpeg. Yours,

Seems to be working fine in my testing so far. As a side-effect it has 
shaved 52KB off the libzip.so binary and a total of 4MB on a debug 
installation. On a side note: does EXTRACT_AFTER_ARGS really have to go 
to the end of the Makefile?


Cheers,

Panagiotis