From owner-freebsd-net@FreeBSD.ORG  Wed Nov 25 00:10:02 2009
Return-Path: <owner-freebsd-net@FreeBSD.ORG>
Delivered-To: freebsd-net@hub.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id BFCEC1065679
	for <freebsd-net@hub.freebsd.org>; Wed, 25 Nov 2009 00:10:02 +0000 (UTC)
	(envelope-from gnats@FreeBSD.org)
Received: from freefall.freebsd.org (freefall.freebsd.org
	[IPv6:2001:4f8:fff6::28])
	by mx1.freebsd.org (Postfix) with ESMTP id 9590C8FC13
	for <freebsd-net@hub.freebsd.org>; Wed, 25 Nov 2009 00:10:02 +0000 (UTC)
Received: from freefall.freebsd.org (localhost [127.0.0.1])
	by freefall.freebsd.org (8.14.3/8.14.3) with ESMTP id nAP0A2sS069783
	for <freebsd-net@freefall.freebsd.org>; Wed, 25 Nov 2009 00:10:02 GMT
	(envelope-from gnats@freefall.freebsd.org)
Received: (from gnats@localhost)
	by freefall.freebsd.org (8.14.3/8.14.3/Submit) id nAP0A2C2069782;
	Wed, 25 Nov 2009 00:10:02 GMT (envelope-from gnats)
Date: Wed, 25 Nov 2009 00:10:02 GMT
Message-Id: <200911250010.nAP0A2C2069782@freefall.freebsd.org>
To: freebsd-net@FreeBSD.org
From: dfilter@FreeBSD.ORG (dfilter service)
Cc: 
Subject: Re: bin/118987: commit references a PR
X-BeenThere: freebsd-net@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
Reply-To: dfilter service <dfilter@FreeBSD.ORG>
List-Id: Networking and TCP/IP with FreeBSD <freebsd-net.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-net>,
	<mailto:freebsd-net-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-net>
List-Post: <mailto:freebsd-net@freebsd.org>
List-Help: <mailto:freebsd-net-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-net>,
	<mailto:freebsd-net-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 25 Nov 2009 00:10:02 -0000

The following reply was made to PR bin/118987; it has been noted by GNATS.

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: bin/118987: commit references a PR
Date: Wed, 25 Nov 2009 00:01:12 +0000 (UTC)

 Author: will
 Date: Wed Nov 25 00:00:57 2009
 New Revision: 199770
 URL: http://svn.freebsd.org/changeset/base/199770
 
 Log:
   Make ``ifconfig -l ether'' only list interfaces that speak Ethernet.
   
   PR:		118987
   Approved by:	ken (mentor)
 
 Modified:
   head/sbin/ifconfig/ifconfig.c
 
 Modified: head/sbin/ifconfig/ifconfig.c
 ==============================================================================
 --- head/sbin/ifconfig/ifconfig.c	Tue Nov 24 22:37:04 2009	(r199769)
 +++ head/sbin/ifconfig/ifconfig.c	Wed Nov 25 00:00:57 2009	(r199770)
 @@ -147,7 +147,7 @@ main(int argc, char *argv[])
  	struct ifaddrs *ifap, *ifa;
  	struct ifreq paifr;
  	const struct sockaddr_dl *sdl;
 -	char options[1024], *cp;
 +	char options[1024], *cp, *namecp = NULL;
  	const char *ifname;
  	struct option *p;
  	size_t iflen;
 @@ -294,7 +294,7 @@ main(int argc, char *argv[])
  			sdl = (const struct sockaddr_dl *) ifa->ifa_addr;
  		else
  			sdl = NULL;
 -		if (cp != NULL && strcmp(cp, ifa->ifa_name) == 0)
 +		if (cp != NULL && strcmp(cp, ifa->ifa_name) == 0 && !namesonly)
  			continue;
  		iflen = strlcpy(name, ifa->ifa_name, sizeof(name));
  		if (iflen >= sizeof(name)) {
 @@ -308,16 +308,32 @@ main(int argc, char *argv[])
  			continue;
  		if (uponly && (ifa->ifa_flags & IFF_UP) == 0)
  			continue;
 -		ifindex++;
  		/*
  		 * Are we just listing the interfaces?
  		 */
  		if (namesonly) {
 +			if (namecp == cp)
 +				continue;
 +			if (afp != NULL) {
 +				/* special case for "ether" address family */
 +				if (!strcmp(afp->af_name, "ether")) {
 +					if (sdl == NULL ||
 +					    sdl->sdl_type != IFT_ETHER ||
 +					    sdl->sdl_alen != ETHER_ADDR_LEN)
 +						continue;
 +				} else {
 +					if (ifa->ifa_addr->sa_family != afp->af_af)
 +						continue;
 +				}
 +			}
 +			namecp = cp;
 +			ifindex++;
  			if (ifindex > 1)
  				printf(" ");
  			fputs(name, stdout);
  			continue;
  		}
 +		ifindex++;
  
  		if (argc > 0)
  			ifconfig(argc, argv, 0, afp);
 _______________________________________________
 svn-src-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/svn-src-all
 To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org"