From owner-svn-src-all@freebsd.org Thu Aug 13 15:25:36 2015 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 946559A0B6C for ; Thu, 13 Aug 2015 15:25:36 +0000 (UTC) (envelope-from pfg@FreeBSD.org) Received: from nm19-vm0.bullet.mail.bf1.yahoo.com (nm19-vm0.bullet.mail.bf1.yahoo.com [98.139.213.162]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4E83727D for ; Thu, 13 Aug 2015 15:25:36 +0000 (UTC) (envelope-from pfg@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1439479533; bh=qiG4bYX7Xhp+hrcxaMo7R2OWnyHgbMFGhg00cicDNhU=; h=Date:From:To:CC:Subject:References:In-Reply-To:From:Subject; b=ncm0bRRhLH80xUe7qU9CQzk7fFdgopH25ItRs0HHr4go3bFdMaCYPd8jLy98E2fSpAZFK+NDhyisxCl6fJIM8K+4sF9PxbIfIWa91Yr+HG37I0LqBHxTt+axGqPNMGg9a4YBgdm/UI/ou2Re8jrT5bYmE/8hLNlBjTM5g2rFa1JdFJp3RUp5yuMDOcBiiQOWvBtuB1ivqLUMIQAR8+8yyY2/3YGhaMnOoua4kxqiqEnTgn7rMY/oYmBPLRdQnbnQXWdNwvt4hIaWn7ViRaOb6KItFWPqOJ99EJUJxLvV+ORg5d3YdvpsSmntKtioOEaD8TvId4AD8t6mPQP1vB0RRQ== Received: from [98.139.170.181] by nm19.bullet.mail.bf1.yahoo.com with NNFMP; 13 Aug 2015 15:25:33 -0000 Received: from [98.139.211.205] by tm24.bullet.mail.bf1.yahoo.com with NNFMP; 13 Aug 2015 15:25:33 -0000 Received: from [127.0.0.1] by smtp214.mail.bf1.yahoo.com with NNFMP; 13 Aug 2015 15:25:33 -0000 X-Yahoo-Newman-Id: 710734.59902.bm@smtp214.mail.bf1.yahoo.com X-Yahoo-Newman-Property: ymail-3 X-YMail-OSG: fdkqyS8VM1nIQ5xRy7G.Y.BseQuyoev4XT8byom95mih8Z2 3pqwPLwBjorRgfSaDGuuj3d9s01hNIT9U2G6oWokj88Tahk.7HuwfuqdjVVN EDAUuuo4WhkEJtDJuC1Q6FcaLaeKrw.DpE5WpciyWu.4lElZcNbFCd4UxjDh pBmkMf07.xxVWpHRG_Wf47oXwSoO9HkyxKz9Zg7pxOTpCYJx6dOlUs9EtWbw e6dgLlKO_vNLvn4HSPNZ.i2vUErhd0fF9kQ1dCcHjR3VCvgMyUaYukf9sFp2 3gzDPXMbMfVk1xaBACd7BqTFsBsHSNwKtP7j1afybbGn4j3HRLenxHMCEqkU xxk2nJ4J3auB8cLPGM7M72LOXzfRs.ZbVKZtLY4QPApuPjKAZ7XaXjASIA2v bqdYPKSg1WSFOIpI_9MU573ssccu1qjqtM6KhE3H31VNOU9LvCw3v5A8PhF6 6qBbhXNxtxRqoQCwf5dUrLVB.nDryCVJpVgZwHCknhtCVsrGken9IkGSNRQd y5EdU0ykIKHBGeB3q4eaEpSGhM7SihTTU X-Yahoo-SMTP: xcjD0guswBAZaPPIbxpWwLcp9Unf Message-ID: <55CCB6F2.7080008@FreeBSD.org> Date: Thu, 13 Aug 2015 10:25:38 -0500 From: Pedro Giffuni Organization: FreeBSD Project User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: araujo@FreeBSD.org, David Chisnall CC: "src-committers@freebsd.org" , "svn-src-all@freebsd.org" , "svn-src-head@freebsd.org" Subject: Re: svn commit: r286715 - head/lib/libc/string References: <201508130231.t7D2VOhc069855@repo.freebsd.org> <20150813134548.U1375@besplex.bde.org> <0CFBA0CC-FEEE-40CE-BC47-065613C64293@FreeBSD.org> In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-Content-Filtered-By: Mailman/MimeDel 2.1.20 X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 13 Aug 2015 15:25:36 -0000 FWIW; I think the posix manpage is in the right direction. For a more detailed discussion about replacing bcopys you may read Ted Unangst's blog post[1], but of course OpenBSD is not FreeBSD. I honesly would sepnd much time in bcopy, it is one of those things that will stay in FreeBSD for a long while. I would focus on strtoq() and strtouq() which carry this *comical* notice in stdlib.h : /* Deprecated interfaces, to be removed in FreeBSD 6.0. */ Cheers, Pedro. [1] http://www.tedunangst.com/flak/post/memcpy-vs-memmove On 13/08/2015 02:56 a.m., Marcelo Araujo wrote: > Hi David, > > So it means, this commit here was right already: > https://svnweb.freebsd.org/base?view=revision&revision=286651 > > Although I made a mistake with the date. > > > All the best. > > 2015-08-13 15:24 GMT+08:00 David Chisnall >: > > On 13 Aug 2015, at 08:11, Marcelo Araujo > wrote: > > > > The bcopy() was removed in IEEE Std 1003.1-2008 and it is marked > as LEGACY in IEEE Std 1003.1-2004. However, BSD has its > implementation before IEEE Std 1003.1-2001. > > > > In my understood it is obsolete on POSIX, but not truly obsolete > for FreeBSD. > > So I believe, this patch now address it in the correct way. > > Its use should be strongly discouraged in FreeBSD (or, ideally, > replaced with the macro from the POSIX man page). LLVM does a > load of optimisations for memmove and memcpy - using bcopy is a > really good way of bypassing all of these. > > David > > > > > -- > > -- > Marcelo Araujo (__) > araujo@FreeBSD.org \\\'',) > http://www.FreeBSD.org \/ \ ^ > Power To Server. .\. /_)