From owner-freebsd-hackers@freebsd.org Tue Apr 7 18:46:45 2020 Return-Path: Delivered-To: freebsd-hackers@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 5F54027952D for ; Tue, 7 Apr 2020 18:46:45 +0000 (UTC) (envelope-from driesm.michiels@gmail.com) Received: from mail-wm1-x335.google.com (mail-wm1-x335.google.com [IPv6:2a00:1450:4864:20::335]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 48xbwh05B2z44mV; Tue, 7 Apr 2020 18:46:43 +0000 (UTC) (envelope-from driesm.michiels@gmail.com) Received: by mail-wm1-x335.google.com with SMTP id z7so2785379wmk.1; Tue, 07 Apr 2020 11:46:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:references:in-reply-to:subject:date:message-id :mime-version:content-transfer-encoding:content-language :thread-index; bh=DEHC0ugzf3DiWb1tvqYSXXLOm80h0dNjziNBT2Z/gUk=; b=ndD8heQaVK+I47zbqj8sRHZod1M52+DLrtn9eZ2X3EDpb8dkR6qaDPZVlczR6Q14+g WxmyGDpX5M+8XpJFekK5gAgE/JQzQPMOlbNtiv7Z7qed6KgGUITrzpdZtf+XoWk9wO6p dp1jC+5igM0BU/9t4iHcF+tF+QF+tPo154RWOY2AvP1xmciPJv63TbmEfyi6XSHAl4/D ruzWsNC3ty14z8WSSau6K8dnMSk7kTIyAjiZarSYvweo3sRxyQbSP7Wpz0eVDi3kMEiw saTRjpVCUcGnsxRL36gf+RY+i7h3oyzQ8wKTKys9ZXfGZBTUFBv/h70zTZrUVeeaGQaK ZETg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:references:in-reply-to:subject:date :message-id:mime-version:content-transfer-encoding:content-language :thread-index; bh=DEHC0ugzf3DiWb1tvqYSXXLOm80h0dNjziNBT2Z/gUk=; b=T30v0UsVsHN7EfHO3qs0KjhgoSyNOACN0o+Ysyrw3EHXMNnS+GL6e7iHaV3Qel81TH J0+EuwDDsgrOysSJci49hKY+lMWyyu0F/YaduoahMZFrjeO/jmlBSP8yr6UfV70xM8Lh 6grlzfZFtBhPoHrvB9qt6xAinAd+92qPGsKEeukyr/jDPTBt0jpLoYkc0U7xJcjdzDdp 27mGECGtremWAVbMOBayW6a3GQhJw2EJ/IiSKxzKGL3CuhUM+p1EBCKNaEgCrRxxVMU2 tUR0EGhQZamu4NZjs0XGMwQRnoBYI8DGHe5SmD2P7Oas5/V/RRpBgV0bTq9Vu/N9k9lD 8gHA== X-Gm-Message-State: AGi0PuZ4yVFXS0BhmsP7kNsuxrxXMCdvSKh1N2YdA2ohHrdkImLw88J9 UR2JWg6YpHSKpZha1FXGwDU= X-Google-Smtp-Source: APiQypLDcvjItbsl24+MA9qvgX2yCWVicEof2OVP0iKz0YQdztIo13znnRyo9xt/8aXsc4aKF6qxzA== X-Received: by 2002:a7b:c219:: with SMTP id x25mr640091wmi.23.1586285202268; Tue, 07 Apr 2020 11:46:42 -0700 (PDT) Received: from DRIESPC (ptr-8sijbm5kgljykh4y3mp.18120a2.ip6.access.telenet.be. [2a02:1811:2505:1601:306e:6ddd:5afc:6ee1]) by smtp.gmail.com with ESMTPSA id b199sm3993728wme.23.2020.04.07.11.46.41 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Tue, 07 Apr 2020 11:46:41 -0700 (PDT) From: To: "'Rodney W. Grimes'" , Cc: , "'Andrey V. Elsukov'" , "'Neel Chauhan'" References: <202004071735.037HZ1mK093414@gndrsh.dnsmgr.net> In-Reply-To: <202004071735.037HZ1mK093414@gndrsh.dnsmgr.net> Subject: RE: Committing one ipfw(8) userland patch Date: Tue, 7 Apr 2020 20:46:41 +0200 Message-ID: <00c101d60d0c$e1331bc0$a3995340$@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Mailer: Microsoft Outlook 16.0 Content-Language: nl-be Thread-Index: AQJMSIb2S0Wl9yENYOtRzVjLofK+1KeBf96w X-Rspamd-Queue-Id: 48xbwh05B2z44mV X-Spamd-Bar: -- Authentication-Results: mx1.freebsd.org; dkim=pass header.d=gmail.com header.s=20161025 header.b=ndD8heQa; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (mx1.freebsd.org: domain of driesmmichiels@gmail.com designates 2a00:1450:4864:20::335 as permitted sender) smtp.mailfrom=driesmmichiels@gmail.com X-Spamd-Result: default: False [-3.00 / 15.00]; RCVD_VIA_SMTP_AUTH(0.00)[]; TO_DN_SOME(0.00)[]; R_SPF_ALLOW(-0.20)[+ip6:2a00:1450:4000::/36:c]; FREEMAIL_FROM(0.00)[gmail.com]; RCPT_COUNT_FIVE(0.00)[5]; RCVD_COUNT_THREE(0.00)[3]; DKIM_TRACE(0.00)[gmail.com:+]; DMARC_POLICY_ALLOW(-0.50)[gmail.com,none]; FROM_EQ_ENVFROM(0.00)[]; IP_SCORE(0.00)[ip: (-8.99), ipnet: 2a00:1450::/32(-2.36), asn: 15169(-0.43), country: US(-0.05)]; MIME_TRACE(0.00)[0:+]; FREEMAIL_ENVFROM(0.00)[gmail.com]; ASN(0.00)[asn:15169, ipnet:2a00:1450::/32, country:US]; TAGGED_FROM(0.00)[]; DWL_DNSWL_NONE(0.00)[gmail.com.dwl.dnswl.org : 127.0.5.0]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; R_DKIM_ALLOW(-0.20)[gmail.com:s=20161025]; MID_RHS_MATCH_FROM(0.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; MIME_GOOD(-0.10)[text/plain]; IP_SCORE_FREEMAIL(0.00)[]; TO_MATCH_ENVRCPT_SOME(0.00)[]; FROM_NO_DN(0.00)[]; RCVD_IN_DNSWL_NONE(0.00)[5.3.3.0.0.0.0.0.0.0.0.0.0.0.0.0.0.2.0.0.4.6.8.4.0.5.4.1.0.0.a.2.list.dnswl.org : 127.0.5.0]; RCVD_TLS_ALL(0.00)[] X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 07 Apr 2020 18:46:45 -0000 > -----Original Message----- > From: owner-freebsd-hackers@freebsd.org hackers@freebsd.org> On Behalf Of Rodney W. Grimes > Sent: dinsdag 7 april 2020 19:35 > To: lev@freebsd.org > Cc: freebsd-hackers@freebsd.org; Andrey V. Elsukov ; > Neel Chauhan > Subject: Re: Committing one ipfw(8) userland patch > > > On 07.04.2020 11:28, Andrey V. Elsukov wrote: > > > > >> I have one patch for the ipfw userland tool: > > >> https://reviews.freebsd.org/D24234 > > >> > > >> This patch adds the src-ip4/dst-ip4 and src-ipv4/dst-ipv4 aliases > > >> for src-ip/dst-ip commands respectively in IPFW. > > >> > > >> Could someone please commit this patch? > > > > > > Can you describe what is the benefit to have all these aliases, when > > > after adding the rule you will still see other name. I think this > > > makes it more confusing. > > I think, {src|dst}-ip without version should exist only for backward > > compatibility and, maybe, produce warnings. > > But that is not what this review does. I would be in support of changing the > "official" names to src-ip4/dst-ip4/src-ip6/dst-ip6 and making src-ip/dst-ip a > backwards compatible alias. > > > > > Why? symmetry & consistency. And equal length of fields in rules for > > different versions, too :-) > > > > Also, there are confusion with me/me4/me6. When `src-ip` is really > > `src-ip4`, what does `me` mean? `me4`? or `me4 OR me6`? > > The parts of the rule are not cross applied so this is a non-question, > me4 with a src-ip6 matches 0 packets no mater what the values are. Currently only me and me6 are implemented, given your comment above does that mean that "me" should only match IPv4 packets? If that was the intend, it is not what I'm observing with my ruleset that uses "me" as destination keyword. IPv6 works fine with it. You can find my IPFW ruleset in the review https://reviews.freebsd.org/D24021. > > One could write syntax checkers to flag this NOP condition. > > > -- > > // Lev Serebryakov > -- > Rod Grimes rgrimes@freebsd.org > _______________________________________________ > freebsd-hackers@freebsd.org mailing list > https://lists.freebsd.org/mailman/listinfo/freebsd-hackers > To unsubscribe, send any mail to "freebsd-hackers-unsubscribe@freebsd.org"