From owner-freebsd-bugs@freebsd.org Tue Jul 17 01:53:12 2018 Return-Path: Delivered-To: freebsd-bugs@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 3FE8C104A0BD for ; Tue, 17 Jul 2018 01:53:12 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mailman.ysv.freebsd.org (mailman.ysv.freebsd.org [IPv6:2001:1900:2254:206a::50:5]) by mx1.freebsd.org (Postfix) with ESMTP id BBA678E75F for ; Tue, 17 Jul 2018 01:53:11 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: by mailman.ysv.freebsd.org (Postfix) id 75D3C104A0BC; Tue, 17 Jul 2018 01:53:11 +0000 (UTC) Delivered-To: bugs@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 4E33D104A0BB for ; Tue, 17 Jul 2018 01:53:11 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.ysv.freebsd.org (mxrelay.ysv.freebsd.org [IPv6:2001:1900:2254:206a::19:3]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "mxrelay.ysv.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id D1AF88E75E for ; Tue, 17 Jul 2018 01:53:10 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mxrelay.ysv.freebsd.org (Postfix) with ESMTPS id 238F818FB0 for ; Tue, 17 Jul 2018 01:53:10 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id w6H1rAaF062696 for ; Tue, 17 Jul 2018 01:53:10 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id w6H1rAvQ062694 for bugs@FreeBSD.org; Tue, 17 Jul 2018 01:53:10 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: bugs@FreeBSD.org Subject: [Bug 229818] apm(8) The total battery percentage is incorrect for multiple batteries Date: Tue, 17 Jul 2018 01:53:10 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: new X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: CURRENT X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: kd-dev@pm.me X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: bugs@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: bug_id short_desc product version rep_platform op_sys bug_status bug_severity priority component assigned_to reporter attachments.mimetype attachments.created Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 17 Jul 2018 01:53:12 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D229818 Bug ID: 229818 Summary: apm(8) The total battery percentage is incorrect for multiple batteries Product: Base System Version: CURRENT Hardware: Any OS: Any Status: New Severity: Affects Only Me Priority: --- Component: kern Assignee: bugs@FreeBSD.org Reporter: kd-dev@pm.me Attachment #195185 text/plain mime type: Created attachment 195185 --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=3D195185&action= =3Dedit Produce the total battery percentage from the capacity totals rather than t= he other percentages The total "Remaining battery life" field is the average of the per-battery "Remaining battery life" fields, rather than the percentage of the remaining battery life relative to the maximum battery life. Contrived expected output: APM version: 1.2 APM Management: Disabled AC Line status: off-line Battery Status: high Remaining battery life: 50% Remaining battery time: 4:00:00 Number of batteries: 2 Battery 0: Battery Status: high Remaining battery life: 100% Remaining battery time: 3:00:00 Battery 1: Battery Status: low Remaining battery life: 20% Remaining battery time: 1:00:00 Contrived example output: APM version: 1.2 APM Management: Disabled AC Line status: off-line Battery Status: high Remaining battery life: 60% Remaining battery time: 4:00:00 Number of batteries: 2 Battery 0: Battery Status: high Remaining battery life: 100% Remaining battery time: 3:00:00 Battery 1: Battery Status: low Remaining battery life: 20% Remaining battery time: 1:00:00 The included patch changes the way that value is generated to be from the sum-totals of the current and last-full battery capacities. This replaces the current behavior of averaging the percentages produced from each battery. The included patch was tested on an amd64 version of FreeBSD 12.0-CURRENT r336075. It builds and runs without any warnings nor errors. --=20 You are receiving this mail because: You are the assignee for the bug.=