Date: Thu, 26 Dec 2013 23:41:08 +0100 From: John Marino <freebsd.contact@marino.st> To: Baptiste Daroussin <bapt@FreeBSD.org> Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, Eitan Adler <eadler@freebsd.org>, ports-committers@freebsd.org Subject: Re: svn commit: r337624 - head/games/daimonin-music Message-ID: <52BCB084.3040504@marino.st> In-Reply-To: <20131226223743.GV40122@ithaqua.etoilebsd.net> References: <201312262215.rBQMF1ZF002032@svn.freebsd.org> <20131226223743.GV40122@ithaqua.etoilebsd.net>
next in thread | previous in thread | raw e-mail | index | archive | help
On 12/26/2013 23:37, Baptiste Daroussin wrote: > On Thu, Dec 26, 2013 at 10:15:01PM +0000, John Marino wrote: >> Author: marino >> Date: Thu Dec 26 22:15:01 2013 >> New Revision: 337624 >> URL: http://svnweb.freebsd.org/changeset/ports/337624 >> > The port itself is still wrong, NO_CHECKSUM is still being used, while > bsd.port.mk specifically says it is not to be used inside a port, so this should > either be fixed or the port should remain broken. > I saw later this PR: http://www.freebsd.org/cgi/query-pr.cgi?pr=170052 It is taken by eadler@. The patch itself is no longer good but at least there was some attempt to fix it. I did not know NO_CHECKSUM was internal use only. It built fine in poudriere, which is where I tested it. Is eadler going to follow up? or at least release the PR? John
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?52BCB084.3040504>