From nobody Sun Sep 29 03:58:13 2024 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4XGVmQ2b2nz5YGjV; Sun, 29 Sep 2024 03:58:14 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R11" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4XGVmQ0j6hz4ZwR; Sun, 29 Sep 2024 03:58:14 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1727582294; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=TqcNr42g6CMC5GTdXJkPkrJlocJgyZTHe8LwzcGreok=; b=a1FS9dk3JAT+2PZixPbaYG2FM19mt8vrX6AfgU9hIFw/TDXmZkrzHO2cgJf01+Hj25vOTo LW67+LkRvD4PDmitGBmk61hfv9HUvJ/e7vVJycYsXAfHBm0hT8Zk2w0+/pYHcAEoz51FP3 9bjuM7aD3r1QJ/SqEoEtcZbURCX3+vgfnJvzbOh7S94jVa8p1BW/UyH4/GIcsDWPeKOJV4 P27dIh3gWygMZeTscBf38C9TuuW57DWp7dTnr3DFzX5ahfC5Qy5npaDUym3AEHr3knLMXp P0wlGgGbfVCHLqFYOim6SfGxeI494nAWhPDNreRG8ygvfEnw+6Jng9QRIl28WQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1727582294; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=TqcNr42g6CMC5GTdXJkPkrJlocJgyZTHe8LwzcGreok=; b=mug3VI6NX1uDUt/xayrS06C4XhY2L4FfJJtDkODqm7GX05m064IVymJfDXwaCKYyr6jwZG 9ovO4kT2mmoEQX8gu0FL8bsA0f/8bnOmuNhHVLu1EZbtm55YAEO50rrASdN9fhamw9NmzX UKzCBhZuGT98JlY1I4auquphvjGvpBX+TXM1syb9gXBGl1ct4J+k0jWnDZR/XJsCOW6gFQ +hAJctgsniCmS5APr6CNI77iWAVXELaAtSt+oZ/ZfYpeTdBtA+rvB3qJDS9ZyDOqVVZa6A e93QPrum29JxVtVEuA5Q/6kTrNOIGVX8pcT3rUjEyGjtQ1/xmQXmbPbRFxBqpg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1727582294; a=rsa-sha256; cv=none; b=W7KKirEUQu2DvHb5oo4GFkZ8TaXsr/zo5CTPVlBhJ2es/CwzfI7Nt4ufqAMFzgsErSNgQi JWy8kLv8aH+hpKaLNP8tYi9fCL29EKwYTNKpG6thoZ0jQnMC6iWrD0YcAY7ciEisX3/oz2 NhVVTgVoMRqju5O1U8F1/g+xvy/MkCFEEjGBJsvsL1cy63SAMKyAvjQW5mS4mqQ1dvSRDs jql6wtrwq0A05flKdOBvuoTj8hUbGYatD4qjAUe+hNe774dbIy53E/R90ST2teG6LpEhVG bYdhHetskJgVYeRhsRlDy+qpY+enp9RloeQUYolk/nS0lkJOUjQ0qlmahAbRRA== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4XGVmQ0Fxrzt6T; Sun, 29 Sep 2024 03:58:14 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 48T3wDRR062888; Sun, 29 Sep 2024 03:58:13 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 48T3wDcp062884; Sun, 29 Sep 2024 03:58:13 GMT (envelope-from git) Date: Sun, 29 Sep 2024 03:58:13 GMT Message-Id: <202409290358.48T3wDcp062884@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Kevin Bowling Subject: git: 61e8ea9c6b2f - stable/13 - e1000: drop NEEDGIANT on em_sysctl_reg_handler uses List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: kbowling X-Git-Repository: src X-Git-Refname: refs/heads/stable/13 X-Git-Reftype: branch X-Git-Commit: 61e8ea9c6b2f186267ad1745a6d8c3b9f1793790 Auto-Submitted: auto-generated The branch stable/13 has been updated by kbowling: URL: https://cgit.FreeBSD.org/src/commit/?id=61e8ea9c6b2f186267ad1745a6d8c3b9f1793790 commit 61e8ea9c6b2f186267ad1745a6d8c3b9f1793790 Author: Kevin Bowling AuthorDate: 2024-09-22 04:04:38 +0000 Commit: Kevin Bowling CommitDate: 2024-09-29 03:57:42 +0000 e1000: drop NEEDGIANT on em_sysctl_reg_handler uses These are simple singular diagnostic register reads (cherry picked from commit c11a0649b97281699e39d0fc82818f235c1dfb87) --- sys/dev/e1000/if_em.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/sys/dev/e1000/if_em.c b/sys/dev/e1000/if_em.c index 873f06cc272f..156a5640a06e 100644 --- a/sys/dev/e1000/if_em.c +++ b/sys/dev/e1000/if_em.c @@ -4435,11 +4435,11 @@ em_add_hw_stats(struct e1000_softc *sc) CTLFLAG_RD, &sc->watchdog_events, "Watchdog timeouts"); SYSCTL_ADD_PROC(ctx, child, OID_AUTO, "device_control", - CTLTYPE_UINT | CTLFLAG_RD | CTLFLAG_NEEDGIANT, + CTLTYPE_UINT | CTLFLAG_RD, sc, E1000_CTRL, em_sysctl_reg_handler, "IU", "Device Control Register"); SYSCTL_ADD_PROC(ctx, child, OID_AUTO, "rx_control", - CTLTYPE_UINT | CTLFLAG_RD | CTLFLAG_NEEDGIANT, + CTLTYPE_UINT | CTLFLAG_RD, sc, E1000_RCTL, em_sysctl_reg_handler, "IU", "Receiver Control Register"); SYSCTL_ADD_UINT(ctx, child, OID_AUTO, "fc_high_water", @@ -4457,11 +4457,11 @@ em_add_hw_stats(struct e1000_softc *sc) queue_list = SYSCTL_CHILDREN(queue_node); SYSCTL_ADD_PROC(ctx, queue_list, OID_AUTO, "txd_head", - CTLTYPE_UINT | CTLFLAG_RD | CTLFLAG_NEEDGIANT, sc, + CTLTYPE_UINT | CTLFLAG_RD, sc, E1000_TDH(txr->me), em_sysctl_reg_handler, "IU", "Transmit Descriptor Head"); SYSCTL_ADD_PROC(ctx, queue_list, OID_AUTO, "txd_tail", - CTLTYPE_UINT | CTLFLAG_RD | CTLFLAG_NEEDGIANT, sc, + CTLTYPE_UINT | CTLFLAG_RD, sc, E1000_TDT(txr->me), em_sysctl_reg_handler, "IU", "Transmit Descriptor Tail"); SYSCTL_ADD_ULONG(ctx, queue_list, OID_AUTO, "tx_irq", @@ -4477,11 +4477,11 @@ em_add_hw_stats(struct e1000_softc *sc) queue_list = SYSCTL_CHILDREN(queue_node); SYSCTL_ADD_PROC(ctx, queue_list, OID_AUTO, "rxd_head", - CTLTYPE_UINT | CTLFLAG_RD | CTLFLAG_NEEDGIANT, sc, + CTLTYPE_UINT | CTLFLAG_RD, sc, E1000_RDH(rxr->me), em_sysctl_reg_handler, "IU", "Receive Descriptor Head"); SYSCTL_ADD_PROC(ctx, queue_list, OID_AUTO, "rxd_tail", - CTLTYPE_UINT | CTLFLAG_RD | CTLFLAG_NEEDGIANT, sc, + CTLTYPE_UINT | CTLFLAG_RD, sc, E1000_RDT(rxr->me), em_sysctl_reg_handler, "IU", "Receive Descriptor Tail"); SYSCTL_ADD_ULONG(ctx, queue_list, OID_AUTO, "rx_irq",