Date: Thu, 13 Apr 2017 16:06:28 +0200 From: Emanuel Haupt <ehaupt@FreeBSD.org> To: Dmitry Marakasov <amdmi3@amdmi3.ru> Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r438383 - in head/audio: . schism schismtracker Message-ID: <20170413160628.b1fff75fc5513333eb42b33a@FreeBSD.org> In-Reply-To: <20170413092634.GB47519@hades.panopticon> References: <201704121630.v3CGUZ7f023880@repo.freebsd.org> <20170412173502.GA88685@hades.panopticon> <f1c63624-3bcd-76e1-c89b-d7bed0d4725f@FreeBSD.org> <20170413092634.GB47519@hades.panopticon>
next in thread | previous in thread | raw e-mail | index | archive | help
Dmitry Marakasov <amdmi3@amdmi3.ru> wrote: > * Emanuel Haupt (ehaupt@FreeBSD.org) wrote: > > > >> Author: ehaupt > > >> Date: Wed Apr 12 16:30:34 2017 > > >> New Revision: 438383 > > >> URL: https://svnweb.freebsd.org/changeset/ports/438383 > > >> > > >> Log: > > >> - Rename audio/schism for better naming > > >> - Add .desktop files for tracker and editor > > >> - Provide icons > > > > > > Nice! But it's missing MOVED entry. Also WWW should be updated to > > > http://schismtracker.org/ > > > > See r438384. I've deliberately committed it (less than 10 seconds > > later) separately because this commit log contains information > > that does not concern ports/MOVED (icons/dekstop). > > There's no reason why commits to MOVED must not include other changes. > Separating actual move and MOVED change is a bad approach IMO. The reason why I prefer it separate is that ports/MOVED and the actual port change is in a different section of the tree. If it is committed together and someone is looking at the svn log of ports/MOVED he's going to see all the unrelated rest (Add .desktop files...). I like it that way, you like it the other way. Neither is "bad" it's just a different style.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20170413160628.b1fff75fc5513333eb42b33a>