From owner-freebsd-questions@FreeBSD.ORG  Sun Jul  4 23:29:10 2004
Return-Path: <owner-freebsd-questions@FreeBSD.ORG>
Delivered-To: freebsd-questions@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id EEBBB16A4CE; Sun,  4 Jul 2004 23:29:10 +0000 (GMT)
Received: from auk1.snu.ac.kr (auk1.snu.ac.kr [147.46.100.31])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id 9743A43D48; Sun,  4 Jul 2004 23:29:10 +0000 (GMT)
	(envelope-from stopspam@users.sourceforge.net)
Received: from [147.46.44.181] (stopspam@users.sourceforge.net) by 
          auk1.snu.ac.kr (Terrace Internet Messaging Server) 
          with ESMTP id 2004070508:29:00:443399.24099.2892671920
          for <freebsd-stable@freebsd.org>; 
          Mon, 05 Jul 2004 08:29:00 +0900 (KST) 
Message-ID: <40E892C3.7060704@users.sourceforge.net>
Date: Mon, 05 Jul 2004 08:29:07 +0900
From: Rob <stopspam@users.sourceforge.net>
User-Agent: Mozilla/5.0 (X11; U; FreeBSD i386; en-US; rv:1.7) Gecko/20040703
X-Accept-Language: en-us, en
MIME-Version: 1.0
To: freebsd-stable@freebsd.org, freebsd-questions@freebsd.org
References: <200407041407.i64E7lUO028658@bunrab.catwhisker.org>
	<20040704165557.GC14695@ip.net.ua> <200407041136.54692.kstewart@owt.com>
In-Reply-To: <200407041136.54692.kstewart@owt.com>
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Transfer-Encoding: 7bit
X-TERRACE-SPAMMARK: NO       (SR:2.26)                     
  (by Terrace)                                                   
Subject: Re: -STABLE build appears broken after ipfilter 3.4.35 MFC
X-BeenThere: freebsd-questions@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: User questions <freebsd-questions.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-questions>,
	<mailto:freebsd-questions-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-questions>
List-Post: <mailto:freebsd-questions@freebsd.org>
List-Help: <mailto:freebsd-questions-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-questions>,
	<mailto:freebsd-questions-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 04 Jul 2004 23:29:11 -0000

Kent Stewart wrote:
> On Sunday 04 July 2004 09:55 am, Ruslan Ermilov wrote:
> 
>>On Sun, Jul 04, 2004 at 07:07:47AM -0700, David Wolfskill wrote:
>>
>>>[I sent a copy of this information under separate cover to Darren
>>>Reed a little while ago.  dhw]
> 
> 
> Darren's 1741 UTC to ip_fil.h fix lets it build on my test system.

I cvsup'ed against cvsup.freebsd.org. The kernel build still fails:

[...]
/usr/src/sys/modules/ipfilter/../../contrib/ipfilter/netinet/ip_fil.c: In function `send_ip':
/usr/src/sys/modules/ipfilter/../../contrib/ipfilter/netinet/ip_fil.c:1325: void value not ignored as it ought to be
*** Error code 1

----

Reason for this seems:

In contrib/ipfilter/netinet/ip_fil.c:1325, there is

	if (fr_makefrip(hlen, ip, &frn) == 0)

and in contrib/ipfilter/netinet/ip_fil.h:633, it has

	extern  void	fr_makefrip __P((int, ip_t *, fr_info_t *));


A void-function cannot be tested against a return value!

Rob