From owner-svn-src-all@FreeBSD.ORG Sat Dec 27 20:56:07 2014 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id A5EB7974; Sat, 27 Dec 2014 20:56:07 +0000 (UTC) Received: from st11p02mm-asmtp002.mac.com (st11p02mm-asmtpout002.mac.com [17.172.220.237]) (using TLSv1.2 with cipher DHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 7A92D3F5; Sat, 27 Dec 2014 20:56:07 +0000 (UTC) Received: from fukuyama.hsd1.ca.comcast.net (unknown [73.162.13.215]) by st11p02mm-asmtp002.mac.com (Oracle Communications Messaging Server 7.0.5.33.0 64bit (built Aug 27 2014)) with ESMTPSA id <0NH90030SE51O720@st11p02mm-asmtp002.mac.com>; Sat, 27 Dec 2014 20:55:51 +0000 (GMT) X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:5.13.68,1.0.33,0.0.0000 definitions=2014-12-27_02:2014-12-24,2014-12-27,1970-01-01 signatures=0 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 suspectscore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=7.0.1-1412080000 definitions=main-1412270229 Content-type: text/plain; charset=us-ascii MIME-version: 1.0 (Mac OS X Mail 8.1 \(1993\)) Subject: Re: svn commit: r276297 - head/sys/arm/broadcom/bcm2835 From: Rui Paulo In-reply-to: <201412271352.sBRDqY6M098448@svn.freebsd.org> Date: Sat, 27 Dec 2014 12:55:48 -0800 Content-transfer-encoding: quoted-printable Message-id: References: <201412271352.sBRDqY6M098448@svn.freebsd.org> To: Luiz Otavio O Souza X-Mailer: Apple Mail (2.1993) Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 27 Dec 2014 20:56:07 -0000 On Dec 27, 2014, at 05:52, Luiz Otavio O Souza wrote: >=20 > Author: loos > Date: Sat Dec 27 13:52:33 2014 > New Revision: 276297 > URL: https://svnweb.freebsd.org/changeset/base/276297 >=20 > Log: > On interrupt handler, save the actual data read from mbox. The = previous > macro wasn't needed and was being used with swapped arguments which = always > give the same result (0) defeating the overflow check. >=20 > On initialization, do not use bcm_mbox_intr() to read the pending = messages, > with the new semaphore based implementation this will lead to = semaphore > being incremented on the channels that contain pending data and will = make > the first read for that channel return stale data. >=20 > This fixes the hang that happens on boot while initializing the = cpufreq on > Raspberry Pi. Thanks! -- Rui Paulo