From owner-cvs-all@FreeBSD.ORG Sun Oct 31 04:34:45 2004 Return-Path: Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id B25CD16A4CF; Sun, 31 Oct 2004 04:34:45 +0000 (GMT) Received: from aslan.scsiguy.com (mail.scsiguy.com [63.229.232.106]) by mx1.FreeBSD.org (Postfix) with ESMTP id 0E08C43D31; Sun, 31 Oct 2004 04:34:45 +0000 (GMT) (envelope-from gibbs@scsiguy.com) Received: from caspian.scsiguy.com (caspian.scsiguy.com [63.229.232.105]) by aslan.scsiguy.com (8.12.11/8.12.11) with ESMTP id i9V4Yhjk044263; Sat, 30 Oct 2004 22:34:43 -0600 (MDT) (envelope-from gibbs@scsiguy.com) Date: Sat, 30 Oct 2004 22:35:58 -0700 From: "Justin T. Gibbs" To: Matthew Jacob , Bruce M Simpson , src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org Message-ID: In-Reply-To: <20041031035037.59607.qmail@web21422.mail.yahoo.com> References: <20041031035037.59607.qmail@web21422.mail.yahoo.com> X-Mailer: Mulberry/3.1.6 (Linux/x86) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Content-Disposition: inline Subject: Re: cvs commit: src/sys/pci if_vr.c X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 31 Oct 2004 04:34:45 -0000 > Shouldn't an API for adding or removing ISR's be responsible for > handling just such a race condition? bus_teardown_intr() already has these semantics, but you have to know to use it and that it should only be called without locks held since it may sleep waiting for another CPU to leave your interrupt handler. The code that was added to this driver shouldn't be necessary if the ISR is properly deregistered during suspend, detach, etc. -- Justin