From owner-cvs-all  Mon Dec 21 23:02:25 1998
Return-Path: <owner-cvs-all@FreeBSD.ORG>
Received: (from majordom@localhost)
          by hub.freebsd.org (8.8.8/8.8.8) id XAA09709
          for cvs-all-outgoing; Mon, 21 Dec 1998 23:02:25 -0800 (PST)
          (envelope-from owner-cvs-all@FreeBSD.ORG)
Received: from godzilla.zeta.org.au (godzilla.zeta.org.au [203.26.10.9])
          by hub.freebsd.org (8.8.8/8.8.8) with ESMTP id XAA09700;
          Mon, 21 Dec 1998 23:02:21 -0800 (PST)
          (envelope-from bde@godzilla.zeta.org.au)
Received: (from bde@localhost)
	by godzilla.zeta.org.au (8.8.7/8.8.7) id SAA25754;
	Tue, 22 Dec 1998 18:02:09 +1100
Date: Tue, 22 Dec 1998 18:02:09 +1100
From: Bruce Evans <bde@zeta.org.au>
Message-Id: <199812220702.SAA25754@godzilla.zeta.org.au>
To: cvs-all@FreeBSD.ORG, cvs-committers@FreeBSD.ORG, obrien@FreeBSD.ORG,
        shmit@kublai.com, wosch@cs.tu-berlin.de
Subject: Re: cvs commit: src/contrib/top display.c
Sender: owner-cvs-all@FreeBSD.ORG
Precedence: bulk

>> You committed a new feature 10 hours after it was posted to
>> -current. A new record! But this gives nobody a real change to comment
>> the patch ...
>
>That's probably for the best, given the heat people get over stupid
>trivial changes (especially ones that are reasonable, like this one). :-)

The implementation wasn't reasonable.  top attempts to keep machine-dependent
features separate and screen coordinates in "layout.h", but the patch
splats everything in the middle of display.c.

I have already complained to the committer.

Bruce

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message