Date: Wed, 27 Mar 2013 22:57:34 -0400 From: Eitan Adler <eadler@freebsd.org> To: Alexey Dokuchaev <danfe@freebsd.org> Cc: svn-ports-head@freebsd.org, Max Brazhnikov <makc@freebsd.org>, svn-ports-all@freebsd.org, ports-committers@freebsd.org Subject: Re: svn commit: r315222 - in head: devel/qdevelop games/warmux graphics/xaos math/qtiplot multimedia/minitube print/hplip textproc/qstardict Message-ID: <CAF6rxgkipVS-gneKbOO-zFyUm=W3AeffBDGd2EegcUt8iXufDw@mail.gmail.com> In-Reply-To: <20130328025321.GC72629@FreeBSD.org> References: <201303251359.r2PDxIXf035701@svn.freebsd.org> <20130328025321.GC72629@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 27 March 2013 22:53, Alexey Dokuchaev <danfe@freebsd.org> wrote: > On Mon, Mar 25, 2013 at 01:59:18PM +0000, Max Brazhnikov wrote: >> New Revision: 315222 >> URL: http://svnweb.freebsd.org/changeset/ports/315222 >> >> - Remove OPTIONS_DEFINE, if it contains only global options > > Can you elaborate on this one? Given that there is no clear policy, > personally I've been always including OPTIONS_DEFINE, even if just for, say, > DOCS. Options such as IPV6, DOCS, EXAMPLES, and NLS are generally set globally (e.g., OPTIONS_UNSET= NLS) and not per port. As such, it can reduce user annoyance if the dialog box is not shown for such options. -- Eitan Adler Source, Ports, Doc committer Bugmeister, Ports Security teams
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAF6rxgkipVS-gneKbOO-zFyUm=W3AeffBDGd2EegcUt8iXufDw>