From owner-freebsd-current Tue Jan 27 10:25:06 1998 Return-Path: Received: (from majordom@localhost) by hub.freebsd.org (8.8.8/8.8.8) id KAA05515 for current-outgoing; Tue, 27 Jan 1998 10:25:06 -0800 (PST) (envelope-from owner-freebsd-current@FreeBSD.ORG) Received: from smtp01.primenet.com (smtp01.primenet.com [206.165.6.131]) by hub.freebsd.org (8.8.8/8.8.8) with ESMTP id KAA05488 for ; Tue, 27 Jan 1998 10:25:03 -0800 (PST) (envelope-from tlambert@usr01.primenet.com) Received: (from daemon@localhost) by smtp01.primenet.com (8.8.8/8.8.8) id LAA14770; Tue, 27 Jan 1998 11:24:52 -0700 (MST) Received: from usr01.primenet.com(206.165.6.201) via SMTP by smtp01.primenet.com, id smtpd014739; Tue Jan 27 11:24:50 1998 Received: (from tlambert@localhost) by usr01.primenet.com (8.8.5/8.8.5) id LAA07024; Tue, 27 Jan 1998 11:24:46 -0700 (MST) From: Terry Lambert Message-Id: <199801271824.LAA07024@usr01.primenet.com> Subject: Re: PATCH: if_de.c #ifdef based version encoding To: jkh@time.cdrom.com (Jordan K. Hubbard) Date: Tue, 27 Jan 1998 18:24:46 +0000 (GMT) Cc: tlambert@primenet.com, current@FreeBSD.ORG In-Reply-To: <25064.885923992@time.cdrom.com> from "Jordan K. Hubbard" at Jan 27, 98 09:59:52 am X-Mailer: ELM [version 2.4 PL25] MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: owner-freebsd-current@FreeBSD.ORG Precedence: bulk > > This patch allows people to compile v3 kernels containing if_de.c on v2 > > systems. > > > > Please commit it. > > Why aren't you submitting these via send-pr(1) as discussed? As it > is, these patches will be lost almost immediately into the -current > mailing list archives unless someone gets to them right away. My patches to support server side fcntl() semantics for NFS locking were submitted via sendpr. When they are integrated, or rejected on the basis of failing a code review, then I will start believing that mechanism works. > The PR mechanism may not always be the best attended of our > facilities, but it's many times better than just sending patches via > email. If this latest batch from Terry vanishes into obscurity he'll > have noone to blame but himself for it since send-pr is the clearly > stated mechanism for submitting change requestes. I disagree. Unlike patches submitted by the sendpr mechanism, this batch of patches is now usable by a wide audience. It is my experience that patches submitted via sendpr tend to languish until after major upheavals, after which time they fail to apply cleanly, and then I get the blame. Regards, Terry Lambert terry@lambert.org --- Any opinions in this posting are my own and not those of my present or previous employers.