Skip site navigation (1)Skip section navigation (2)
Date:      Sat, 1 Jul 2023 17:10:17 GMT
From:      Warner Losh <imp@FreeBSD.org>
To:        src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org
Subject:   git: dc58675cfb18 - main - qlnxe: Fix unused but set variable warning
Message-ID:  <202307011710.361HAHs7046809@gitrepo.freebsd.org>

next in thread | raw e-mail | index | archive | help
The branch main has been updated by imp:

URL: https://cgit.FreeBSD.org/src/commit/?id=dc58675cfb18b1fcde4cdad95eae546c0d5f35cb

commit dc58675cfb18b1fcde4cdad95eae546c0d5f35cb
Author:     Mark O'Donovan <shiftee@posteo.net>
AuthorDate: 2023-07-01 17:06:51 +0000
Commit:     Warner Losh <imp@FreeBSD.org>
CommitDate: 2023-07-01 17:06:58 +0000

    qlnxe: Fix unused but set variable warning
    
    Signed-off-by: Mark O'Donovan <shiftee@posteo.net>
    Reviewed by: imp
    Pull Request: https://github.com/freebsd/freebsd-src/pull/779
---
 sys/dev/qlnx/qlnxe/bcm_osal.h   | 4 ++--
 sys/modules/qlnx/qlnxe/Makefile | 1 -
 2 files changed, 2 insertions(+), 3 deletions(-)

diff --git a/sys/dev/qlnx/qlnxe/bcm_osal.h b/sys/dev/qlnx/qlnxe/bcm_osal.h
index 3f7bb5234942..1cf4b8d06ff1 100644
--- a/sys/dev/qlnx/qlnxe/bcm_osal.h
+++ b/sys/dev/qlnx/qlnxe/bcm_osal.h
@@ -480,8 +480,8 @@ qlnx_test_and_change_bit(long bit, volatile unsigned long *var)
 #define OSAL_TEST_AND_FLIP_BIT qlnx_test_and_change_bit
 #define OSAL_TEST_AND_CLEAR_BIT test_and_clear_bit
 #define OSAL_MEMCMP memcmp
-#define OSAL_SPIN_LOCK_IRQSAVE(x,y) {y=0; mtx_lock(x);}
-#define OSAL_SPIN_UNLOCK_IRQSAVE(x,y) {y= 0; mtx_unlock(x);}
+#define OSAL_SPIN_LOCK_IRQSAVE(x, y) { (void)y; mtx_lock(x); }
+#define OSAL_SPIN_UNLOCK_IRQSAVE(x, y) { (void)y; mtx_unlock(x); }
 
 static inline u32
 OSAL_CRC32(u32 crc, u8 *ptr, u32 length)
diff --git a/sys/modules/qlnx/qlnxe/Makefile b/sys/modules/qlnx/qlnxe/Makefile
index d682192d18fc..42dbfc14bdf5 100644
--- a/sys/modules/qlnx/qlnxe/Makefile
+++ b/sys/modules/qlnx/qlnxe/Makefile
@@ -89,4 +89,3 @@ CFLAGS += -DCONFIG_ECORE_IWARP
 CFLAGS += -DCONFIG_ECORE_RDMA
 CFLAGS += -DQLNX_ENABLE_IWARP
 
-CWARNFLAGS.ecore_ll2.c+= ${NO_WUNUSED_BUT_SET_VARIABLE}



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?202307011710.361HAHs7046809>