From owner-freebsd-commit Thu Dec 14 07:08:56 1995 Return-Path: owner-commit Received: (from root@localhost) by freefall.freebsd.org (8.7.3/8.7.3) id HAA06832 for freebsd-commit-outgoing; Thu, 14 Dec 1995 07:08:56 -0800 (PST) Received: (from root@localhost) by freefall.freebsd.org (8.7.3/8.7.3) id HAA06634 for cvs-all-outgoing; Thu, 14 Dec 1995 07:06:10 -0800 (PST) Received: (from root@localhost) by freefall.freebsd.org (8.7.3/8.7.3) id HAA06624 for cvs-sys-outgoing; Thu, 14 Dec 1995 07:06:07 -0800 (PST) Received: from jhome.DIALix.COM (root@jhome.DIALix.COM [192.203.228.69]) by freefall.freebsd.org (8.7.3/8.7.3) with ESMTP id HAA06616 Thu, 14 Dec 1995 07:05:59 -0800 (PST) Received: (from peter@localhost) by jhome.DIALix.COM (8.7.3/8.7.3) id XAA07738; Thu, 14 Dec 1995 23:05:49 +0800 (WST) Date: Thu, 14 Dec 1995 23:05:48 +0800 (WST) From: Peter Wemm To: Bruce Evans cc: CVS-committers@freefall.freebsd.org, cvs-sys@freefall.freebsd.org Subject: Re: cvs commit: src/sys/pci bt9xx.c In-Reply-To: <199512141455.BAA18909@godzilla.zeta.org.au> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-commit@FreeBSD.ORG Precedence: bulk On Fri, 15 Dec 1995, Bruce Evans wrote: > > The correct isa vector line for the bt driver is "vector bt_isa_intr". > > Justin mentioned this in the commit message and updated LINT and > > GENERIC. This change is to enforce that.. :-) > > I think btintr should have been left as btintr so that old config files > don't need to be changed. Only config [-n :-] needs to be run. I guess bt_isa_intr(int) could be renamed to btintr(int) now that bt_intr(void *) is out of the way... > Can we agree on a naming scheme for drivers? I'd like all routines in > module xxx to begin with "xxx" (not "xxx_", unless one is used for > functions and the other for variables). It almost looks like there's a mini-convention of having driver "xx"'s devsw entry points called "xxFUNC" and the internal or otherwise referenced entry points called "xx_FUNC". I dont know if that makes sense or not, but I've seen that in a lot of drivers. As for having a convention.. Yeah, why not.. As long as it's the same as mine.... :-) :-) -Peter > Bruce >