Date: Thu, 16 Jul 2020 20:39:02 +0200 From: "Kristof Provost" <kp@FreeBSD.org> To: "Kajetan Staszkiewicz" <vegeta@tuxpowered.net> Cc: net@FreeBSD.org Subject: Re: Deadlocks when using pf tags or socket owner matching Message-ID: <5C947AE8-3A7A-4584-92CB-1266143792E6@FreeBSD.org> In-Reply-To: <7572280D-1808-46FE-AD72-06F827E1512A@FreeBSD.org> References: <48de3ee4-ba52-f6a7-b2d7-c7d77a635eb9@tuxpowered.net> <eb66e05f-2f0b-5a03-20b4-a769940cf18a@tuxpowered.net> <7572280D-1808-46FE-AD72-06F827E1512A@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 10 Jul 2020, at 22:29, Kristof Provost wrote: > On 8 Jul 2020, at 12:52, Kajetan Staszkiewicz wrote: >> I have forgot to mention my system: it's FreeBSD 11.3-RELEASE-p9 >> >> I have also managed to replicate this (or a similar) issue on a test >> system built with lock debugging and I got this: >> >> Jul 8 10:32:07 hwlb-aw-01 kernel: lock order reversal: >> Jul 8 10:32:07 hwlb-aw-01 kernel: 1st 0xffffffff81850760 pf rulesets >> (pf rulesets) @ >> /usr/home/kajetan.staszkiewicz/freebsd.git/sys/netpfil/pf/pf.c:6006 >> Jul 8 10:32:07 hwlb-aw-01 kernel: 2nd 0xfffff8011f7028a8 tcpinp >> (tcpinp) @ >> /usr/home/kajetan.staszkiewicz/freebsd.git/sys/netinet/in_pcb.c:1994 > > This lock order reversal is almost certainly the reason for the > deadlock you report in your previous e-mail. > > The problem relates to the UID filtering functionality, so not using > that feature will avoid the deadlock. > I believe I’ve seen previous reports about issues in this area as > well. > > I’ll try to put this on my short-sh term todo list, but I can’t > promise anything. Free time is exceptionally rare these days. > I can’t seem to reproduce the LOR (or the deadlock). Can you share a minimal ruleset that triggers this problem? Thanks, Kristof
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?5C947AE8-3A7A-4584-92CB-1266143792E6>