From nobody Fri Feb 28 15:59:15 2025 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4Z4CZC6Fjpz5m8W1; Fri, 28 Feb 2025 15:59:15 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R10" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Z4CZC49f5z3w70; Fri, 28 Feb 2025 15:59:15 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1740758355; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=MbhqWNKMSunNlAi+3ko0KeI4mNHw6fsxPsEVFLplDA8=; b=VXklQJVfTWfWEyLIF45kE3y2feZViDOzaWaJrqQDQlVprqfC370vv4vQYTDgp2w7BLOhwi RXIdwdect7hsmWVrltzbzwETnuxb8Z0yM9BLmtEuy4FF0yGuwJbMaV6l6YEG4jDGYJ3qMy SCNF/lug+ODZe8zwNCda9P5nOswzHkL7ZMxNGM946GO/4nxV4hjwaQWroHpGrMsT3eWniN EwcUVuLh7ofXWdmn01D4fNcp5X1oeb8iAG5sP18rq9BpcZgxCVYnN/e+mcmHb07Dl99cMs I752FZeWMfuD56CYZ66oyBnmrefFt0aYQJ5WviyJszOepQYBrBrQJEB+Xunt/w== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1740758355; a=rsa-sha256; cv=none; b=jPhtqqIp/lBmIuZu2jmwpvuYK0YmeAxz/L66u+oQsO7IIwAEOJsXM0/Zvid+mpRnWIonUC s/rMJVvkafG6soVzHo5KCNxG38XouTSeEkq89rrJKVELFHuzcHzkzhuIfPDoieU/sMJqXM gmFwgxsNbzr2bxQznxp6juru3CEdxbVyugq4FxFt9zhl5wO44ZQSczGB6rMOV2oEMWO80a nYGWKcUEo6SLlJ4k7q6JTW1FHa2qHzB6Q6eaijvLzgNKb/8J/nouj//F4eft7J85m3Nrh4 clVOPgSN4bFVt2ut7dBfyCRFbr2V8XTRGqm6ADIKVxGkRhulV7pUHZgI5xB9Ww== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1740758355; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=MbhqWNKMSunNlAi+3ko0KeI4mNHw6fsxPsEVFLplDA8=; b=tkJNVwfBN9guNJJ8eikGwqa1LTKSKWIFxfBGolcfszExQ7YfHwdd5+XlMwrmjWeZL/E1tr G/YD//bF6Nc+KvUNNEAeq/KZVlQ8WteVyUqPfHbA+GkPIi6icT3SgBVc2HYdk1zHZlvlwD wcJw+9MKo55D9JQhtuD0ackRNx/Q7Rj1eyERadvF1Ivso/XaWgFdITEM5d38R4XhAH482P ugYPC4ihSAlE6JFpimeE5MSAa98/CRaQEkI/m6P/f4LHGsZjDxda1LcbY7gBjQLq0mubQ3 KTGDfNUGKMuowEXgZl0S+C5xhFohuXo+D1K5NGFdepynSMsqL58k8aQEnyne8g== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4Z4CZC3Xpnzc5L; Fri, 28 Feb 2025 15:59:15 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 51SFxFNi001041; Fri, 28 Feb 2025 15:59:15 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 51SFxFrJ001038; Fri, 28 Feb 2025 15:59:15 GMT (envelope-from git) Date: Fri, 28 Feb 2025 15:59:15 GMT Message-Id: <202502281559.51SFxFrJ001038@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Cy Schubert Subject: git: a3d32f9e6033 - stable/13 - ntp: NULL pointer deref when create_interface() fails List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: cy X-Git-Repository: src X-Git-Refname: refs/heads/stable/13 X-Git-Reftype: branch X-Git-Commit: a3d32f9e6033a9083a22b7c9f25633430372e5b4 Auto-Submitted: auto-generated The branch stable/13 has been updated by cy: URL: https://cgit.FreeBSD.org/src/commit/?id=a3d32f9e6033a9083a22b7c9f25633430372e5b4 commit a3d32f9e6033a9083a22b7c9f25633430372e5b4 Author: Cy Schubert AuthorDate: 2025-02-28 15:46:23 +0000 Commit: Cy Schubert CommitDate: 2025-02-28 15:58:54 +0000 ntp: NULL pointer deref when create_interface() fails Fix NULL pointer dereference when create_interface() fails in update_interfaces(). The upstream bug report says a typo was introduced by https://bk.ntp.org/ntp-dev/ntpd/ntp_io.c?PAGE=diffs&REV=66175036PETA6g__fON8oNrjL54Ttw. ep should have been ep2. Fix obtained from upstream bug report. PR: 285065 Upstream bug: https://bugs.ntp.org/show_bug.cgi?id=3939 (cherry picked from commit 628715fdcc9f2226bfe0f4ebe381aaa7761cb6cc) --- contrib/ntp/ntpd/ntp_io.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/contrib/ntp/ntpd/ntp_io.c b/contrib/ntp/ntpd/ntp_io.c index 9d79fe493d9b..12a61ccb1d2c 100644 --- a/contrib/ntp/ntpd/ntp_io.c +++ b/contrib/ntp/ntpd/ntp_io.c @@ -1921,7 +1921,7 @@ update_interfaces( } else { DPRINT_INTERFACE(3, - (ep, "updating ", " new - FAILED")); + (ep2, "updating ", " new - FAILED")); msyslog(LOG_ERR, "cannot bind address %s",