Date: Mon, 9 Apr 2018 07:46:20 -0700 (PDT) From: "Rodney W. Grimes" <freebsd@pdx.rh.CN85.dnsmgr.net> To: Niclas Zeising <zeising+freebsd@daemonic.se> Cc: rgrimes@freebsd.org, Kyle Evans <kevans@freebsd.org>, svn-src-stable@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org, svn-src-stable-11@freebsd.org Subject: Re: svn commit: r331880 - stable/11/etc Message-ID: <201804091446.w39EkKdr019017@pdx.rh.CN85.dnsmgr.net> In-Reply-To: <9cfe34fc-196a-df96-7eaf-036cc4c17bdd@daemonic.se>
next in thread | previous in thread | raw e-mail | index | archive | help
> On 04/02/18 17:39, Rodney W. Grimes wrote: > >> Author: kevans > >> Date: Mon Apr 2 15:28:48 2018 > >> New Revision: 331880 > >> URL: https://svnweb.freebsd.org/changeset/base/331880 > >> > >> Log: > >> MFC r328331: Support configuring arbitrary limits(1) for any rc.conf daemon > >> > >> Usage is ${name}_limits, and the argument is any flags accepted by > >> limits(1), such as `-n 100' (e.g. only allow 100 open files). > >> > >> Modified: > >> stable/11/etc/rc.subr > >> Directory Properties: > >> stable/11/ (props changed) > >> > >> Modified: stable/11/etc/rc.subr > >> ============================================================================== > >> --- stable/11/etc/rc.subr Mon Apr 2 15:07:41 2018 (r331879) > >> +++ stable/11/etc/rc.subr Mon Apr 2 15:28:48 2018 (r331880) > >> @@ -773,6 +773,8 @@ check_startmsgs() > >> # > >> # ${name}_login_class n Login class to use, else "daemon". > >> # > >> +# ${name}_limits n limits(1) to apply to ${command}. > >> +# > > > > Caution, limits(1) is in /usr/bin, this code can fail if used before > > /usr is mounted. (Ie, our rc.initdiskless) is probably broken by > > this change if a call is made to limits. > > > > > > Sorry for jumping on this so late. This is also an issue in CURRENT, > and has been since at least 2016. I was aware that it was an issue and why I made a comment about it being MFC'ed. Though I had forgot a bug report existed. > See https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=206291 This bug is rat holed as it has no FreeBSD-foo@ in the cc list. -- Rod Grimes rgrimes@freebsd.org
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201804091446.w39EkKdr019017>