From owner-p4-projects@FreeBSD.ORG Mon Jun 9 01:37:51 2008 Return-Path: Delivered-To: p4-projects@freebsd.org Received: by hub.freebsd.org (Postfix, from userid 32767) id 58B3E1065673; Mon, 9 Jun 2008 01:37:51 +0000 (UTC) Delivered-To: perforce@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 1A9191065671 for ; Mon, 9 Jun 2008 01:37:51 +0000 (UTC) (envelope-from hselasky@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id 063C88FC13 for ; Mon, 9 Jun 2008 01:37:51 +0000 (UTC) (envelope-from hselasky@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.1/8.14.1) with ESMTP id m591bo1V041456 for ; Mon, 9 Jun 2008 01:37:50 GMT (envelope-from hselasky@FreeBSD.org) Received: (from perforce@localhost) by repoman.freebsd.org (8.14.1/8.14.1/Submit) id m591bolR041454 for perforce@freebsd.org; Mon, 9 Jun 2008 01:37:50 GMT (envelope-from hselasky@FreeBSD.org) Date: Mon, 9 Jun 2008 01:37:50 GMT Message-Id: <200806090137.m591bolR041454@repoman.freebsd.org> X-Authentication-Warning: repoman.freebsd.org: perforce set sender to hselasky@FreeBSD.org using -f From: Hans Petter Selasky To: Perforce Change Reviews Cc: Subject: PERFORCE change 143142 for review X-BeenThere: p4-projects@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: p4 projects tree changes List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 09 Jun 2008 01:37:51 -0000 http://perforce.freebsd.org/chv.cgi?CH=143142 Change 143142 by hselasky@hselasky_laptop001 on 2008/06/09 01:37:00 USB cache sync bugfix. After countless hours of debugging I finally saw the light why the OHCI did not work on ARM. I had switched flush and invalidate on the SETUP packet! Grrr. Now it finally works like it should! Affected files ... .. //depot/projects/usb/src/sys/dev/usb/usb_transfer.c#126 edit Differences ... ==== //depot/projects/usb/src/sys/dev/usb/usb_transfer.c#126 (text+ko) ==== @@ -1990,9 +1990,11 @@ xfer->flags_int.control_hdr) { /* special case */ if (xfer->flags_int.usb_mode == USB_MODE_DEVICE) { + /* The device controller writes to memory */ + xfer->frbuffers[0].isread = 1; + } else { + /* The host controller reads from memory */ xfer->frbuffers[0].isread = 0; - } else { - xfer->frbuffers[0].isread = 1; } } else { /* default case */