From owner-svn-ports-head@FreeBSD.ORG Thu Dec 26 22:48:19 2013 Return-Path: Delivered-To: svn-ports-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 9A8F17F2; Thu, 26 Dec 2013 22:48:19 +0000 (UTC) Received: from mail-wg0-x236.google.com (mail-wg0-x236.google.com [IPv6:2a00:1450:400c:c00::236]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 8A6CB1884; Thu, 26 Dec 2013 22:48:18 +0000 (UTC) Received: by mail-wg0-f54.google.com with SMTP id n12so7551022wgh.33 for ; Thu, 26 Dec 2013 14:48:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-type:content-disposition:in-reply-to:user-agent; bh=MQfuo1aKIN/aAICkPL5sOFAUrvPGM3bRfybcFVXpETQ=; b=W7uDfnmW4qjZwJvwTM8R8ZcV8OqDMH36AWy203b7wptdlXeGt13CBS+oe4UIq7RYQI EDTDYaM6kyqG0EMDP2uCOGqsULvcolxPMAZjkCEinu3cGCJIybKnImGQLjElZbY5yeZS CMgtAU/ywg8SIuYGQ4a/q/jQUTpJ/A/TOPsUO3lcw026PncSxEbyucF0xBYNlOWE4H4M eT+6zMJQWWMGcM8ymYNcLad4A5p70yjnD5uk7/HTftv0RXTpBMfxavrRN4c7w7Gywsh/ QIk8EDJAkbmtxCpHA5vRiG2TfP6tPfYWHteouEhhDMuTambqIWcqb0TaTDd16wj9w2cq a4PA== X-Received: by 10.194.236.9 with SMTP id uq9mr20334714wjc.31.1388098096890; Thu, 26 Dec 2013 14:48:16 -0800 (PST) Received: from ithaqua.etoilebsd.net (ithaqua.etoilebsd.net. [37.59.37.188]) by mx.google.com with ESMTPSA id ey3sm46107344wib.4.2013.12.26.14.48.15 for (version=TLSv1 cipher=RC4-SHA bits=128/128); Thu, 26 Dec 2013 14:48:15 -0800 (PST) Sender: Baptiste Daroussin Date: Thu, 26 Dec 2013 23:48:13 +0100 From: Baptiste Daroussin To: marino@freebsd.org Subject: Re: svn commit: r337624 - head/games/daimonin-music Message-ID: <20131226224813.GW40122@ithaqua.etoilebsd.net> References: <201312262215.rBQMF1ZF002032@svn.freebsd.org> <20131226223743.GV40122@ithaqua.etoilebsd.net> <52BCB084.3040504@marino.st> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="sL7C0a98p/u5aVah" Content-Disposition: inline In-Reply-To: <52BCB084.3040504@marino.st> User-Agent: Mutt/1.5.21 (2010-09-15) Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, Eitan Adler , ports-committers@freebsd.org X-BeenThere: svn-ports-head@freebsd.org X-Mailman-Version: 2.1.17 Precedence: list List-Id: SVN commit messages for the ports tree for head List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 26 Dec 2013 22:48:19 -0000 --sL7C0a98p/u5aVah Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Dec 26, 2013 at 11:41:08PM +0100, John Marino wrote: > On 12/26/2013 23:37, Baptiste Daroussin wrote: > > On Thu, Dec 26, 2013 at 10:15:01PM +0000, John Marino wrote: > >> Author: marino > >> Date: Thu Dec 26 22:15:01 2013 > >> New Revision: 337624 > >> URL: http://svnweb.freebsd.org/changeset/ports/337624 > >> > > The port itself is still wrong, NO_CHECKSUM is still being used, while > > bsd.port.mk specifically says it is not to be used inside a port, so th= is should > > either be fixed or the port should remain broken. > >=20 >=20 > I saw later this PR: http://www.freebsd.org/cgi/query-pr.cgi?pr=3D170052 >=20 > It is taken by eadler@. The patch itself is no longer good but at least > there was some attempt to fix it. I did not know NO_CHECKSUM was > internal use only. It built fine in poudriere, which is where I tested > it. Is eadler going to follow up? or at least release the PR? >=20 > John eadler is afk for a moment, just take the pr ;) if he complains tell him that s my fault Bapt --sL7C0a98p/u5aVah Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.15 (FreeBSD) iEYEARECAAYFAlK8si0ACgkQ8kTtMUmk6ExCaACeOG1TbjpwN7X0SyP0gSqfy8h2 4lgAoKWh4N0+CZg+NYdZG8zTl+usNTBG =cOYE -----END PGP SIGNATURE----- --sL7C0a98p/u5aVah--