From nobody Thu Oct 30 04:23:32 2025 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4cxrZr70rkz6Djgc; Thu, 30 Oct 2025 04:23:32 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R12" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4cxrZr5FhYz3FpY; Thu, 30 Oct 2025 04:23:32 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1761798212; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=I1FBMlwHjinp9jRgTEUg48ptNKwVEy1QospVZ0BqORo=; b=IUjKaTmUPF5uyVWhcXU7UQaXYeUOHczn7Omv9Fy06wKqDIPdAgA1Fiytjdk1Pybljr14Hd Jg4zbrS1PjX+KBMuz4OZJKIgwyREMlAh4l4D+WE0D1Ss2dajgZSzxGMwSvsx+5W4rSznUJ l10jyUXRZvKNQ4HBXp+J09S2ksBm7vPPg/yHxy3BT+pKHAYpte20N2JkC4XbuUGfTbFaNk 8ZdyT+qVB/i3v2UX0b2ExIfjXHavt4fhBkC5qO147yvvwY5C9PZeJaLaQO3Kqo+Ew4hO1S VeVxspaePqj1l6HouhpjvtmC1vKv7RzjCaZCzRIke+6kQMTIUmFXCdEtf7QtIA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1761798212; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=I1FBMlwHjinp9jRgTEUg48ptNKwVEy1QospVZ0BqORo=; b=YtHs/lUSyxdVK16pN4/J7TFBsBzHgvEPES5oHBagUC5lqDPE51bl08LqIJGf4KINQ+zPrE M3wuc4Q5cAKYjtOTB757Ptwn/1rODI3fDbZWWlyR2AXUseQJ0nMP0nhjXJB9ZJyeZloMs2 hvTSF6ALcPb7h8eTE9x2wpDruglk60ho3xVwlKn+apFePrts9pVJ5Ei6ZP3iqDdae2H8bn y1nKlD5AXBc5IXO/90C4A9kv1xCGmi/VGWnRPF9X1jkChCGocVhIxf0+YQeXf9rF/uvg0d yJF8Mu8vf8FX0aziNCl9TYowaH4lslftLwAmFBNDgUyHnYVrCfkJhOP2JfzX1g== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1761798212; a=rsa-sha256; cv=none; b=SFN1Shi/2AzYYQIXTZDprK3pWvun4aGQ8l70UseLZj2jOgCrt3jZHzpXiLh5R+Jjx+Wso7 0k6cgmzQ1UHNxYPhi6r7CbfpuTQblVMu4aRKHGF1q7ff5TaBQt1DEHYeb5EEP2xsaA6Kxw WjG5UF++gYIz+rrlJ4adueeTRfLCdX/UtnCAZ7jrJnvM+lEIqbFgy58blmn3aXpp5WmhJn GXmPK/QwLyEN7pleK036ZkftYk0fjzzkDnbBVyLdZGNq2HZ7383osm34FoTXuPQnlj145q nlNCdSZHyU/jveRebQGyZ9TI3H3jVJVdhscHaShUJpT4farNvXOO5yXfeBBgDQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4cxrZr4gV0z16c4; Thu, 30 Oct 2025 04:23:32 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 59U4NWFf084074; Thu, 30 Oct 2025 04:23:32 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 59U4NWRe084071; Thu, 30 Oct 2025 04:23:32 GMT (envelope-from git) Date: Thu, 30 Oct 2025 04:23:32 GMT Message-Id: <202510300423.59U4NWRe084071@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Colin Percival Subject: git: 245d95ce16f3 - releng/15.0 - sys/arm64: fix COMPAT_FREEBSD32 __syscall() List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: cperciva X-Git-Repository: src X-Git-Refname: refs/heads/releng/15.0 X-Git-Reftype: branch X-Git-Commit: 245d95ce16f366ebffaef3cdec938fa575979b68 Auto-Submitted: auto-generated The branch releng/15.0 has been updated by cperciva: URL: https://cgit.FreeBSD.org/src/commit/?id=245d95ce16f366ebffaef3cdec938fa575979b68 commit 245d95ce16f366ebffaef3cdec938fa575979b68 Author: Robert Clausecker AuthorDate: 2025-10-21 21:35:24 +0000 Commit: Colin Percival CommitDate: 2025-10-30 04:22:09 +0000 sys/arm64: fix COMPAT_FREEBSD32 __syscall() It seems like _QUAD_LOWWORD was incorrectly expanded into 1, which is correct for big endian but not little endian. This means we always grab the padding word for the syscall number, which is usually 0, causing SIGSYS to be delivered to the caller. Reintroduce _QUAD_LOWWORD to fix the syscall. Approved by: re (cperciva) PR: 290411 MFC after: 1 week Discussed with: jrtc27 Reviewed by: cognet, emaste Approved by: markj (mentor) Fixes: 8c9c3144ccfa3061879b8cec015ee7d1010e4766 Differential Revision: https://reviews.freebsd.org/D53250 (cherry picked from commit 1ca09538d94273601dac08204c1d0b3ca9115864) (cherry picked from commit c824960b89af082e5f083c0c4f141965d203eaa1) --- sys/arm64/arm64/elf32_machdep.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sys/arm64/arm64/elf32_machdep.c b/sys/arm64/arm64/elf32_machdep.c index 8f8a934ad520..4cb8ee5f57ef 100644 --- a/sys/arm64/arm64/elf32_machdep.c +++ b/sys/arm64/arm64/elf32_machdep.c @@ -210,7 +210,7 @@ freebsd32_fetch_syscall_args(struct thread *td) sa->code = *ap++; nap--; } else if (sa->code == SYS___syscall) { - sa->code = ap[1]; + sa->code = ap[_QUAD_LOWWORD]; nap -= 2; ap += 2; }