From owner-svn-src-head@freebsd.org Wed Sep 6 04:32:11 2017 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 0C90BE0CE83 for ; Wed, 6 Sep 2017 04:32:11 +0000 (UTC) (envelope-from jiashiun@gmail.com) Received: from mail-ua0-x22d.google.com (mail-ua0-x22d.google.com [IPv6:2607:f8b0:400c:c08::22d]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id A589366FBA; Wed, 6 Sep 2017 04:32:10 +0000 (UTC) (envelope-from jiashiun@gmail.com) Received: by mail-ua0-x22d.google.com with SMTP id l24so11925013uaa.5; Tue, 05 Sep 2017 21:32:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=h/xINvG3hEVdTCejmDAHDzu+7LbuOMlDEGr665pkYCQ=; b=J3ylCYmL+9Xh5IZSwlZBzsX1Qgj4tJIkk5XY1eDyIDffjCrW97lc9evw55UYohQKQ/ B9Xj8KeVSStJg1C9wJBa27Snop58KKQSsZZjF6B9MmPYxijGe2rzuVLSpITvhNjcvmyK mF7MQj0PjASqrp8wQ/0eHui7yudN2ZnS/hgGVCnyJyU8x0kbmzxAWUgRrYB5J8mZ/Dl5 1mNRAgdtRBcUfn5iTVgzGxoRXdgIAJpV2lbpe+8r9pUnWI9TSvwjmxjUbUw/znTxHebS 5UKzl3gVhZeOW7L2J0Y2uVvVfJCSUPLowVOScfWfHhHsdl4D+d/Giwvp2fbrdxfKE4hH 4/3Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=h/xINvG3hEVdTCejmDAHDzu+7LbuOMlDEGr665pkYCQ=; b=bjtY1RVvJhi4j5CGQMa0mNBCaYFnFeDGDWD07oSCixouAQJ41XTGMdZBpQLImiviDN SXlurISQ0uzPPJmf8+xyxN+qVmzBYoOPxdVesr3PG68Sx3SRdEfF5yGZZKuHrAOZkDbS aP4qT+0Co/hJ4c//CI7+g9nGP+Ub04LV4mGGiiGo2ikmvBjS1qYhJA+RGyHTabZ1VFz/ XOe2duD9p+/0HUuvQkwpd7Txw9ztU6H+7QGm9h57N1oYPegD+rd4Hi2F8SdKk+7y7xsB Qpl9xibP7x1318FaZ8JwSVrJPyyJPCPASKJiz9FaKNZ77JcbFnygvlS8sh6qqccNDAlK 0ieQ== X-Gm-Message-State: AHPjjUi7UWDCbgn/DjUoyDjQIgWg8QdDU9Up1B7FXkNVZlrgKtnkyZTh 8eLOwOMl/IIMmvnKBM1oEch49LjhOgaz3l8= X-Google-Smtp-Source: ADKCNb5wCiV07nVy+K3SnTbp2AkeInRMy9nzo9l8MmSQ+cMIkZoOmfk3jXfkdyjhSAGowiANZ4dVXNq1kjsWFg4K3Vw= X-Received: by 10.159.36.168 with SMTP id 37mr969822uar.116.1504672328863; Tue, 05 Sep 2017 21:32:08 -0700 (PDT) MIME-Version: 1.0 Received: by 10.103.68.87 with HTTP; Tue, 5 Sep 2017 21:31:38 -0700 (PDT) In-Reply-To: References: <201708311732.v7VHWEvs037245@repo.freebsd.org> From: Jia-Shiun Li Date: Wed, 6 Sep 2017 12:31:38 +0800 Message-ID: Subject: Re: svn commit: r323063 - head/sys/boot/efi/boot1 To: Warner Losh Cc: Warner Losh , "svn-src-head@freebsd.org" Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.23 X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 06 Sep 2017 04:32:11 -0000 On Tue, Sep 5, 2017 at 9:33 PM, Warner Losh wrote: > On Mon, Sep 4, 2017 at 11:51 PM, Jia-Shiun Li wrote: > >> Seems to cause armv6 crossbuild to fail. >> But did armv6 use efi anyway? >> > > Yea, this is just a command line flag. Will fix. Not sure why x86 doesn't > suffer from this, but it's a wchar_t size difference I'm sure. > amd64 has -fshort-wchar when compiling boot1.c. aarch64 has it too but armv6 doesn't. Looks it's missing from sys/boot/efi/Makefile.inc. from build log, amd64: --- boot1.o --- cc -target x86_64-unknown-freebsd12.0 --sysroot=/usr/obj/personal/freebsd/fbsdsrc/tmp -B/usr/obj/personal/freebsd/fbsdsrc/tmp/usr/bin -O2 -pipe -DSKEIN_LOOP=111 -I. -I/personal/freebsd/fbsdsrc/sys/boot/efi/boot1/../include -I/personal/freebsd/fbsdsrc/sys/boot/efi/boot1/../include/amd64 -I/personal/freebsd/fbsdsrc/sys/boot/efi/boot1/../../../contrib/dev/acpica/include -I/personal/freebsd/fbsdsrc/sys/boot/efi/boot1/../../.. -DEFI_UFS_BOOT -I/personal/freebsd/fbsdsrc/sys/boot/efi/boot1/../../zfs/ -I/personal/freebsd/fbsdsrc/sys/boot/efi/boot1/../../../cddl/boot/zfs/ -I/personal/freebsd/fbsdsrc/sys/boot/efi/boot1/../../../crypto/skein -DEFI_ZFS_BOOT -I/personal/freebsd/fbsdsrc/sys/boot/efi/boot1/../../common -fPIC -ffreestanding -Wformat -mno-mmx -mno-sse -mno-avx -msoft-float -fshort-wchar -mno-red-zone -mno-aes -g -MD -MF.depend.boot1.o -MTboot1.o -std=gnu99 -Wsystem-headers -Werror -Wall -Wno-format-y2k -W -Wno-unused-parameter -Wstrict-prototypes -Wmissing-prototypes -Wpointer-arith -Wreturn-type -Wcast-qual -Wwrite-strings -Wswitch -Wshadow -Wunused-parameter -Wcast-align -Wchar-subscripts -Winline -Wnested-externs -Wredundant-decls -Wold-style-definition -Wno-pointer-sign -Wmissing-variable-declarations -Wthread-safety -Wno-empty-body -Wno-string-plus-int -Wno-unused-const-variable -Qunused-arguments -c /personal/freebsd/fbsdsrc/sys/boot/efi/boot1/boot1.c -o boot1.o armv6: --- boot1.o --- cc -target armv6-gnueabihf-freebsd12.0 --sysroot=/usr/obj/arm.armv6/personal/freebsd/fbsdsrc/tmp -B/usr/obj/arm.armv6/personal/freebsd/fbsdsrc/tmp/usr/bin -O -pipe -DSKEIN_LOOP=111 -I. -I/personal/freebsd/fbsdsrc/sys/boot/efi/boot1/../include -I/personal/freebsd/fbsdsrc/sys/boot/efi/boot1/../include/arm -I/personal/freebsd/fbsdsrc/sys/boot/efi/boot1/../../../contrib/dev/acpica/include -I/personal/freebsd/fbsdsrc/sys/boot/efi/boot1/../../.. -DEFI_UFS_BOOT -I/personal/freebsd/fbsdsrc/sys/boot/efi/boot1/../../zfs/ -I/personal/freebsd/fbsdsrc/sys/boot/efi/boot1/../../../cddl/boot/zfs/ -I/personal/freebsd/fbsdsrc/sys/boot/efi/boot1/../../../crypto/skein -DEFI_ZFS_BOOT -I/personal/freebsd/fbsdsrc/sys/boot/efi/boot1/../../common -ffreestanding -Wformat -msoft-float -fPIC -g -MD -MF.depend.boot1.o -MTboot1.o -std=gnu99 -Wsystem-headers -Werror -Wall -Wno-format-y2k -W -Wno-unused-parameter -Wstrict-prototypes -Wmissing-prototypes -Wpointer-arith -Wreturn-type -Wcast-qual -Wwrite-strings -Wswitch -Wshadow -Wunused-parameter -Wcast-align -Wchar-subscripts -Winline -Wnested-externs -Wredundant-decls -Wold-style-definition -Wno-pointer-sign -Wmissing-variable-declarations -Wthread-safety -Wno-empty-body -Wno-string-plus-int -Wno-unused-const-variable -mno-movt -mfpu=none -Qunused-arguments -c /personal/freebsd/fbsdsrc/sys/boot/efi/boot1/boot1.c -o boot1.o aarch64: --- boot1.o --- cc -target aarch64-unknown-freebsd12.0 --sysroot=/usr/obj/arm64.aarch64/personal/freebsd/fbsdsrc/tmp -B/usr/obj/arm64.aarch64/personal/freebsd/fbsdsrc/tmp/usr/bin -O2 -pipe -DSKEIN_LOOP=111 -I. -I/personal/freebsd/fbsdsrc/sys/boot/efi/boot1/../include -I/personal/freebsd/fbsdsrc/sys/boot/efi/boot1/../include/arm64 -I/personal/freebsd/fbsdsrc/sys/boot/efi/boot1/../../../contrib/dev/acpica/include -I/personal/freebsd/fbsdsrc/sys/boot/efi/boot1/../../.. -DEFI_UFS_BOOT -I/personal/freebsd/fbsdsrc/sys/boot/efi/boot1/../../zfs/ -I/personal/freebsd/fbsdsrc/sys/boot/efi/boot1/../../../cddl/boot/zfs/ -I/personal/freebsd/fbsdsrc/sys/boot/efi/boot1/../../../crypto/skein -DEFI_ZFS_BOOT -I/personal/freebsd/fbsdsrc/sys/boot/efi/boot1/../../common -mgeneral-regs-only -ffreestanding -Wformat -fshort-wchar -fPIC -g -MD -MF.depend.boot1.o -MTboot1.o -std=gnu99 -Wsystem-headers -Werror -Wall -Wno-format-y2k -W -Wno-unused-parameter -Wstrict-prototypes -Wmissing-prototypes -Wpointer-arith -Wreturn-type -Wcast-qual -Wwrite-strings -Wswitch -Wshadow -Wunused-parameter -Wcast-align -Wchar-subscripts -Winline -Wnested-externs -Wredundant-decls -Wold-style-definition -Wno-pointer-sign -Wmissing-variable-declarations -Wthread-safety -Wno-empty-body -Wno-string-plus-int -Wno-unused-const-variable -Qunused-arguments -c /personal/freebsd/fbsdsrc/sys/boot/efi/boot1/boot1.c -o boot1.o -Jia-Shiun