Date: Fri, 25 Feb 2011 17:21:28 -0500 From: John Baldwin <jhb@freebsd.org> To: Dmitry Chagin <dchagin@freebsd.org> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r219042 - in head/sys: kern sys Message-ID: <201102251721.28461.jhb@freebsd.org> In-Reply-To: <201102252205.p1PM5Xlr013873@svn.freebsd.org> References: <201102252205.p1PM5Xlr013873@svn.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Friday, February 25, 2011 5:05:33 pm Dmitry Chagin wrote: > Author: dchagin > Date: Fri Feb 25 22:05:33 2011 > New Revision: 219042 > URL: http://svn.freebsd.org/changeset/base/219042 > > Log: > Introduce preliminary support of the show description of the ABI of > traced process by adding two new events which records value of process > sv_flags to the trace file at process creation/execing/exiting time. > > MFC after: 1 Month. Hmm, I don't find ktrace_submitrequest_ne() an intuitive name (took a bit to figure out 'not-entered', and it doesn't map well between getrequest() (where it means 'already-entered') and submitrequest ('don't exit')). I would rather only have submitrequest() and getrequest() and push the ktrace_enter() and ktrace_exit() into all the callers. -- John Baldwin
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201102251721.28461.jhb>