From owner-svn-src-all@freebsd.org Fri Jan 26 05:59:21 2018 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id A3E9FEC318F for ; Fri, 26 Jan 2018 05:59:21 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: from mail-wm0-x232.google.com (mail-wm0-x232.google.com [IPv6:2a00:1450:400c:c09::232]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 1B7E184A18 for ; Fri, 26 Jan 2018 05:59:21 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: by mail-wm0-x232.google.com with SMTP id 143so18709277wma.5 for ; Thu, 25 Jan 2018 21:59:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdimp-com.20150623.gappssmtp.com; s=20150623; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=LSVDUy81WptxnjQ2TI35iE+ycRTDDSbDQ7gtuPapuwQ=; b=bngr5OhTzCnO98s0yg2yg5/1YhDSPHhciQ3wX4lPeyHc6hXlZIlPzOiC+eX0CLMq/i pI76gYbKym3HdgsNwz25X7e0ptKXHmnY4zJ/6qnQyUD4YYgZEJpT1KwEOXNtQrhQ/DFP dxbyXYs7FK2ypKppM4C8DFXutBGIG0TJ5ZWRYoA1RNrS7bNBncptoE6M37/6mnTSYFQJ 6DFI7bY3sqk/fD8uXf0CuLkfeo0kTu/1hZbnpCxpcQAfPu/o4KppqDobAqjb/kzIwPoK SjsFngpEMEIHZooopcBCsOngj0azhoeBy7OHgMBWRwLs9hEI6JSOoMq+2Cuato5uY7xw CaKg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc; bh=LSVDUy81WptxnjQ2TI35iE+ycRTDDSbDQ7gtuPapuwQ=; b=KLOBMtqyDBGWS+xXhlrXB3sGDzAcEla2gB4RpyMPKgRwe5ugtn1kgB6xcjoEM+2xWO k354tookvqVQW1ABiE6BEv07pdWyPbG42TXvb6IQBfM3YCtEiDFeGMp2gaBEYKx18Nby oOUwG6zZHcBwESTVG1N0SHN8odOpE79E2D9yCJ3N9WCAHX3IUAWXjpTJY1OX5NCnq7sG ft5+6oefP7wtrhE8gCHtfzay4Oaz/5O/8mhFkM1bgxdCruNY/WWChjAREVlxg2R6euvp IfHyvPoFOkkD4ZWscA6MYNjOINMSXMt+kkh4s9pyeZZ08xBy9lHNLpbrjABC6lhLlXFj g0dw== X-Gm-Message-State: AKwxytfvX3IPCpxZkcWK5cPyniuM70z350nASpnSA8LxFGZqEsul2lMy b/6e2uL7PzBA6FzYnONIFrFB4QcOIstMarBS29JgKw== X-Google-Smtp-Source: AH8x224kMbAt9R5fXFgrUYw2hHRwXS/+1/23xZ+83Yj0C6Z9SMoJUJP4oQernFb4EVx4oXtxq0jKoK7BcTa4AvARc/w= X-Received: by 10.80.130.2 with SMTP id 2mr33217288edf.7.1516946359281; Thu, 25 Jan 2018 21:59:19 -0800 (PST) MIME-Version: 1.0 Sender: wlosh@bsdimp.com Received: by 10.80.133.195 with HTTP; Thu, 25 Jan 2018 21:59:18 -0800 (PST) X-Originating-IP: [50.253.99.174] In-Reply-To: References: <201801260440.w0Q4efhg008105@repo.freebsd.org> From: Warner Losh Date: Thu, 25 Jan 2018 22:59:18 -0700 X-Google-Sender-Auth: XFyX97u5N5zR2ARZ4OpRqYLtgsE Message-ID: Subject: Re: svn commit: r328430 - head/sbin/devd To: Matt Joras Cc: Eitan Adler , src-committers , svn-src-all@freebsd.org, svn-src-head@freebsd.org Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.25 X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 26 Jan 2018 05:59:22 -0000 On Thu, Jan 25, 2018 at 10:02 PM, Matt Joras wrote: > On Thu, Jan 25, 2018 at 8:52 PM, Warner Losh wrote: > > > > > > On Thu, Jan 25, 2018 at 9:40 PM, Eitan Adler wrote: > >> > >> Author: eadler > >> Date: Fri Jan 26 04:40:41 2018 > >> New Revision: 328430 > >> URL: https://svnweb.freebsd.org/changeset/base/328430 > >> > >> Log: > >> devd: minor nits > >> > >> - mark usage as noreturn > >> - config does not need a virtual destructor > > > > > > Everything needs a virtual destructor... Please back that part of this > > out... > > > > Warner > Needs? If there's not inheritance there's no _need_ to do it, and it's > arguably superfluous. That being said it's also an arguably > superfluous change to remove it. > OK. Needs might not be the proper word. It's a stylistic thing in all the C++ code I write. It keeps me from having to go back later and add it back when it really does need it after subclasses are derived from it. It's an important detail that often gets overlooked. The cost is minimal. And this isn't one of the rare cases where it's harmful to have it. Warner