From owner-svn-ports-all@freebsd.org Thu Jun 25 08:15:25 2015 Return-Path: Delivered-To: svn-ports-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id A021698CCE2; Thu, 25 Jun 2015 08:15:25 +0000 (UTC) (envelope-from freebsd.contact@marino.st) Received: from shepard.synsport.net (mail.synsport.com [208.69.230.148]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 3E113115F; Thu, 25 Jun 2015 08:15:24 +0000 (UTC) (envelope-from freebsd.contact@marino.st) Received: from [192.168.1.20] (254.Red-83-60-246.dynamicIP.rima-tde.net [83.60.246.254]) (using TLSv1 with cipher DHE-RSA-AES128-SHA (128/128 bits)) (No client certificate requested) by shepard.synsport.net (Postfix) with ESMTP id AD6CD43BB6; Thu, 25 Jun 2015 03:15:14 -0500 (CDT) Message-ID: <558BB890.9010102@marino.st> Date: Thu, 25 Jun 2015 10:15:12 +0200 From: John Marino Reply-To: marino@freebsd.org User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:24.0) Gecko/20100101 Thunderbird/24.5.0 MIME-Version: 1.0 To: Pavel Timofeev , koobs@freebsd.org CC: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org, Bryan Drewery , sunpoet@freebsd.org, Mathieu , Adam Weinberger , timur@freebsd.org Subject: Re: svn commit: r390526 - head/ftp/curl References: <201506250022.t5P0MURx089077@svn.freebsd.org> <558B5E47.6000409@FreeBSD.org> In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Mailman-Approved-At: Thu, 25 Jun 2015 21:38:31 +0000 X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 25 Jun 2015 08:15:25 -0000 On 6/25/2015 10:03, Pavel Timofeev wrote: > Hi! > I partly agree with @koobs, back in days I'd prefer to use > OPTIONS_RADIO instead of OPTIONS_SINGLE (FOO_NONE). > But when I was adding a choice to www/squid, I saw an example in > ports/Mk/Uses/gssapi.mk with OPTIONS_SINGLE. > And I'm not sure if OPTIONS_RADIO has an ability to say that nothing is chosen. > > At the other hand in the rest of the world 'radio buttons' allow you > to select only one option, not none of them. > So it is normal if one of the options is NO_PETS among CAT, DOG and PARROT. > But we, in ports tree, don't call it radio buttons. We call 'radio > buttons' something different. That's a mess I think. > > I can misunderstand something, sorry! > > P.S. Now I'd prefer to delete an old OPTIONS_RADIO macro then rename > OPTIONS_SINGLE to OPTIONS_RADIO. The single vs. radio naming issue is both unfortunate and well known. Basically we're stuck with it. It's one of those things you just have to know is badly named and do the right thing. John