From owner-freebsd-arch@FreeBSD.ORG Sun Mar 1 18:15:45 2009 Return-Path: Delivered-To: arch@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 7810110656DE; Sun, 1 Mar 2009 18:15:45 +0000 (UTC) (envelope-from sam@freebsd.org) Received: from ebb.errno.com (ebb.errno.com [69.12.149.25]) by mx1.freebsd.org (Postfix) with ESMTP id 4988C8FC17; Sun, 1 Mar 2009 18:15:45 +0000 (UTC) (envelope-from sam@freebsd.org) Received: from trouble.errno.com (trouble.errno.com [10.0.0.248]) (authenticated bits=0) by ebb.errno.com (8.13.6/8.12.6) with ESMTP id n21HdLfK062972 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Sun, 1 Mar 2009 09:39:23 -0800 (PST) (envelope-from sam@freebsd.org) Message-ID: <49AAC849.9060105@freebsd.org> Date: Sun, 01 Mar 2009 09:39:21 -0800 From: Sam Leffler Organization: FreeBSD Project User-Agent: Thunderbird 2.0.0.18 (X11/20081209) MIME-Version: 1.0 To: Luigi Rizzo References: <20090301153010.GA58942@onelab2.iet.unipi.it> In-Reply-To: <20090301153010.GA58942@onelab2.iet.unipi.it> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-DCC-x.dcc-servers-Metrics: ebb.errno.com; whitelist Cc: arch@freebsd.org, net@freebsd.org Subject: Re: spliting kernel ipfw source ? (also involves sctp) X-BeenThere: freebsd-arch@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussion related to FreeBSD architecture List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 01 Mar 2009 18:15:46 -0000 Luigi Rizzo wrote: > Hi, > I am planning to split netinet/ip_fw2.c in a number of smaller files > to make it more manageable, and while i do this I would also like > to move the files related to ipfw2 (namely ip_fw*c) to a better place. > Any objection to moving them to sys/netinet/ipfw2 ? > > Also, I can't help noticing that sys/netinet/ contains 36 files > related to sctp -- wouldn't it be the case to move them > (perhaps with the exception of the userland headers) > to a separate subdirectory ? > > (I know the same reasoning would apply to tcp, which has 23 files, > but the issue here is that there is 25 years of userland code expecting > the tcp headers in netinet/ and moving them would be a > nightmare for ports...) > I think sctp belongs in it's own directory. I'd vote for just ipfw; the "2" was an artifact of previous code. Sam