Date: Mon, 21 Feb 2022 22:37:15 +0000 From: bugzilla-noreply@freebsd.org To: ports-bugs@FreeBSD.org Subject: [Bug 262109] Mk/Uses/python.mk: coddle cmake with more hints Message-ID: <bug-262109-7788@https.bugs.freebsd.org/bugzilla/>
next in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D262109 Bug ID: 262109 Summary: Mk/Uses/python.mk: coddle cmake with more hints Product: Ports & Packages Version: Latest Hardware: Any OS: Any Status: New Severity: Affects Some People Priority: --- Component: Individual Port(s) Assignee: jbeich@FreeBSD.org Reporter: jcfyecrayz@liamekaens.com Assignee: jbeich@FreeBSD.org Flags: maintainer-feedback?(jbeich@FreeBSD.org) Created attachment 231998 --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=3D231998&action= =3Dedit [patch] suport FindPython.cmake, FindPython3.cmake, FindPython2.cmake modul= es cmake supports more than one way to search for python. Uses/python.mk passes -DPython_ADDITIONAL_VERSIONS=3D${PYTHON_VER} to help = cmake "find" the version of python that a port build wants to use. The FindPython{,2,3}.cmake modules don't know anything about Python_ADDITIONAL_VERSIONS. The FindPython{Interp,Libs}.cmake modules do. = The former use Python{,2,3}_EXECUTABLE as the hint. I didn't do the archeology= to see which flavor of FindPython*.cmake came first, but of course it makes se= nse in the bizarre world of cmake that you would not make a later flavor compatible. Oh cmake, how do I hate thee? Let me count the ways. Recently a couple ports broke when a newer version of python is installed in addition to the default version of python (currently 3.8). For instance, if python3.10 was installed in addition to python3.8 (and many packages installed in the lib/python3.8/site-packages area), multimedia/one= vpl broke before ports/0378719b21c61d5a5d3dc8f31be7781fd7ff11ef. See bug 26141= 5. Now graphics/libjxl has the same problem. I did not open a bug for graphics/libjxl yet. Instead it seems that we need to appease cmake's additional python support modules by adding more knobs to tell cmake what version of python to use in case the port uses a different flavor of FindPy= thon than the one that wants Python_ADDITIONAL_VERSIONS. Attached is a patch for Uses/python.mk that does that. Feedback please. --=20 You are receiving this mail because: You are the assignee for the bug.=
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-262109-7788>