From owner-freebsd-hackers@freebsd.org Tue Sep 3 03:47:29 2019 Return-Path: Delivered-To: freebsd-hackers@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 64AC0C8347 for ; Tue, 3 Sep 2019 03:47:29 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: from mail-qk1-x72e.google.com (mail-qk1-x72e.google.com [IPv6:2607:f8b0:4864:20::72e]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 46MtFD36Jnz3Fsj for ; Tue, 3 Sep 2019 03:47:28 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: by mail-qk1-x72e.google.com with SMTP id q203so5160755qke.1 for ; Mon, 02 Sep 2019 20:47:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdimp-com.20150623.gappssmtp.com; s=20150623; h=mime-version:from:date:message-id:subject:to; bh=sQdC/4msvGi9DKbli6i4kTmayJbHcrXLXZvFuVk1/Vs=; b=K5bHBcopur5JckZ2yB1wiZFxqaselJhFG7THcfOKD37uvx53c2gcv6xovIP2lb9CAA Va9B4YvIb2qiPeq0pqFOaQi1xl7r7nZS/8Zrd76g0SWTl86qB3LH8f/CpM3LSzLARcRe fDoDWlW5N33x/1BPKe/9vGTnzKShVMKRgHtSQg8yRIsSeuaZqZGYXacj/bH3BLHu3kFT 1QPAPso2R6gSU2T6Tiy8U1RRvhbep8qNZA6sLf1yC4iwcgN9lHfSBpaYIQkNQS0BKIZA NyzyJqZ3NSFU/fFQphCSwGSs5mpH9IyznhROKz+Ela/jWEmbPBJTiPOIvvJ2JCzdeTTb rJnw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=sQdC/4msvGi9DKbli6i4kTmayJbHcrXLXZvFuVk1/Vs=; b=Wgg8hoWNncTkalq61yOwlPUXjCwLKjBZwaurcGssoIPG+ZmwSUJordWTLTcsCWR+EL 3ODPkvdzu28YvsgfqRO8v9/otl/iii7lm/nEyZJA2WOp1Nf/ZYksxB/u9HdttEM3anKM qeIqB3TnEGeV/0G2emzZyzdSKmNtzV52EtW7GLLf157gWNMNfHF3Pyql+bWDTYqCysYT NoCVOe2lSaxx+qG1EjX//zQ7TNIYGw9heGcqWvAgeSwHMgQDfI1C/CvWxPNJitwB2mip XK0gFLiFBp2SNmwxTxzc9s5MbufNKy0uYm4xHQIqZcdbbaAO8juhuzgu5xGkgufru2Kf bl7A== X-Gm-Message-State: APjAAAX+mKuYgVZWu0s3pesi3Idhur1xKiIzj+qqM9MVE94QeDK4jqF9 ocav0qPTLaw7VlgDBKfAU5bVwsuZHUl79rJwrvY3nbX1vGcysA== X-Google-Smtp-Source: APXvYqyQHXN4nMb/jZkuzhZxqIWWuFbnuhwkwEpoI3pMwJcMklcNEmC9bipkrEkVkH31LUegQgnnxKj3baSEfPgqxA4= X-Received: by 2002:a37:8902:: with SMTP id l2mr30935950qkd.380.1567482446728; Mon, 02 Sep 2019 20:47:26 -0700 (PDT) MIME-Version: 1.0 From: Warner Losh Date: Mon, 2 Sep 2019 21:47:16 -0600 Message-ID: Subject: Looking for review / testing for nvme suspend / resume support To: FreeBSD Hackers X-Rspamd-Queue-Id: 46MtFD36Jnz3Fsj X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; dkim=pass header.d=bsdimp-com.20150623.gappssmtp.com header.s=20150623 header.b=K5bHBcop; dmarc=none; spf=none (mx1.freebsd.org: domain of wlosh@bsdimp.com has no SPF policy when checking 2607:f8b0:4864:20::72e) smtp.mailfrom=wlosh@bsdimp.com X-Spamd-Result: default: False [-4.90 / 15.00]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; R_DKIM_ALLOW(-0.20)[bsdimp-com.20150623.gappssmtp.com:s=20150623]; FROM_HAS_DN(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; MIME_GOOD(-0.10)[multipart/alternative,text/plain]; PREVIOUSLY_DELIVERED(0.00)[freebsd-hackers@freebsd.org]; DMARC_NA(0.00)[bsdimp.com]; URI_COUNT_ODD(1.00)[3]; RCPT_COUNT_ONE(0.00)[1]; TO_DN_ALL(0.00)[]; DKIM_TRACE(0.00)[bsdimp-com.20150623.gappssmtp.com:+]; NEURAL_HAM_SHORT(-0.99)[-0.993,0]; RCVD_IN_DNSWL_NONE(0.00)[e.2.7.0.0.0.0.0.0.0.0.0.0.0.0.0.0.2.0.0.4.6.8.4.0.b.8.f.7.0.6.2.list.dnswl.org : 127.0.5.0]; R_SPF_NA(0.00)[]; FORGED_SENDER(0.30)[imp@bsdimp.com,wlosh@bsdimp.com]; MIME_TRACE(0.00)[0:+,1:+,2:~]; IP_SCORE(-2.90)[ip: (-9.33), ipnet: 2607:f8b0::/32(-2.82), asn: 15169(-2.30), country: US(-0.05)]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US]; FROM_NEQ_ENVFROM(0.00)[imp@bsdimp.com,wlosh@bsdimp.com]; RCVD_TLS_ALL(0.00)[]; RCVD_COUNT_TWO(0.00)[2] Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.29 X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 03 Sep 2019 03:47:29 -0000 I've posted a review: https://reviews.freebsd.org/D21493 for NVMe suspend / resume support. This avoids issues where we come out of suspend and need to wait 30s for there to be a timeout and a reset of the device. It does so by completely shutting down the card before we suspend, and then assume it was in an unknown state when we come back up. Please leave comments about successful (or unsuccessful) tests and/or ways to improve the code. Thanks! Warner