From owner-freebsd-bugs@FreeBSD.ORG Mon Dec 29 07:40:03 2008 Return-Path: Delivered-To: freebsd-bugs@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id D8BBE106564A for ; Mon, 29 Dec 2008 07:40:03 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id C2A328FC16 for ; Mon, 29 Dec 2008 07:40:03 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.14.3/8.14.3) with ESMTP id mBT7e3Ur061824 for ; Mon, 29 Dec 2008 07:40:03 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.3/8.14.3/Submit) id mBT7e3SH061823; Mon, 29 Dec 2008 07:40:03 GMT (envelope-from gnats) Date: Mon, 29 Dec 2008 07:40:03 GMT Message-Id: <200812290740.mBT7e3SH061823@freefall.freebsd.org> To: freebsd-bugs@FreeBSD.org From: Dieter Cc: Subject: Re: kern/118093: firewire bus reset hogs CPU, causing data to be lost X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: Dieter List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 29 Dec 2008 07:40:03 -0000 The following reply was made to PR kern/118093; it has been noted by GNATS. From: Dieter To: freebsd-firewire@freebsd.org, bug-followup@freebsd.org Cc: Subject: Re: kern/118093: firewire bus reset hogs CPU, causing data to be lost Date: Sun, 28 Dec 2008 23:30:55 +0000 > > I'll rephrase my question. In the old days, locking was done with spl. > > The new way is with mutex. But with the spl calls being replaced with > > noops, and as far as I can tell the driver is not using mutex, there > > doesn't appear to be any locking. So the driver can step on itself. > > > Well, there is locking around a couple of mutex's via FW_GLOCK(). Ah, I wasn't grepping for the right string. So there *is* mutex locking. Although the lingering spl calls are still troubling.