From owner-svn-ports-all@FreeBSD.ORG  Thu Mar 28 03:07:57 2013
Return-Path: <owner-svn-ports-all@FreeBSD.ORG>
Delivered-To: svn-ports-all@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 1033)
 id E868095A; Thu, 28 Mar 2013 03:07:57 +0000 (UTC)
Date: Thu, 28 Mar 2013 03:07:57 +0000
From: Alexey Dokuchaev <danfe@FreeBSD.org>
To: Eitan Adler <eadler@freebsd.org>
Subject: Re: svn commit: r315222 - in head: devel/qdevelop games/warmux
 graphics/xaos math/qtiplot multimedia/minitube print/hplip
 textproc/qstardict
Message-ID: <20130328030757.GB83712@FreeBSD.org>
References: <201303251359.r2PDxIXf035701@svn.freebsd.org>
 <20130328025321.GC72629@FreeBSD.org>
 <CAF6rxgkipVS-gneKbOO-zFyUm=W3AeffBDGd2EegcUt8iXufDw@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=koi8-r
Content-Disposition: inline
In-Reply-To: <CAF6rxgkipVS-gneKbOO-zFyUm=W3AeffBDGd2EegcUt8iXufDw@mail.gmail.com>
User-Agent: Mutt/1.5.21 (2010-09-15)
Cc: svn-ports-head@freebsd.org, Max Brazhnikov <makc@freebsd.org>,
 svn-ports-all@freebsd.org, ports-committers@freebsd.org
X-BeenThere: svn-ports-all@freebsd.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: SVN commit messages for the ports tree <svn-ports-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-ports-all>,
 <mailto:svn-ports-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-ports-all>
List-Post: <mailto:svn-ports-all@freebsd.org>
List-Help: <mailto:svn-ports-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-ports-all>,
 <mailto:svn-ports-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 28 Mar 2013 03:07:58 -0000

On Wed, Mar 27, 2013 at 10:57:34PM -0400, Eitan Adler wrote:
> On 27 March 2013 22:53, Alexey Dokuchaev <danfe@freebsd.org> wrote:
> > On Mon, Mar 25, 2013 at 01:59:18PM +0000, Max Brazhnikov wrote:
> >> New Revision: 315222
> >> URL: http://svnweb.freebsd.org/changeset/ports/315222
> >>
> >> - Remove OPTIONS_DEFINE, if it contains only global options
> >
> > Can you elaborate on this one?  Given that there is no clear policy,
> > personally I've been always including OPTIONS_DEFINE, even if just for,
> > say, DOCS.
> 
> Options such as IPV6, DOCS, EXAMPLES, and NLS are generally set
> globally (e.g., OPTIONS_UNSET= NLS) and not per port.  As such, it can
> reduce user annoyance if the dialog box is not shown for such options.

Yes, I've heard that reasoning.  I'm not particularly against it, but I
am also worried about certain inconsistency: it means, that for a port
with at least one "local" option, users can toggle all of them, while for
others they had to rely on their /etc/make.conf settings (or defaults).

./danfe