From owner-freebsd-ports-bugs@FreeBSD.ORG Fri May 21 03:20:26 2004 Return-Path: Delivered-To: freebsd-ports-bugs@hub.freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 21A9616A4CE for ; Fri, 21 May 2004 03:20:26 -0700 (PDT) Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21]) by mx1.FreeBSD.org (Postfix) with ESMTP id 029D043D55 for ; Fri, 21 May 2004 03:20:26 -0700 (PDT) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) i4LAKLfj033858 for ; Fri, 21 May 2004 03:20:21 -0700 (PDT) (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.12.11/8.12.11/Submit) id i4LAKL8C033857; Fri, 21 May 2004 03:20:21 -0700 (PDT) (envelope-from gnats) Date: Fri, 21 May 2004 03:20:21 -0700 (PDT) Message-Id: <200405211020.i4LAKL8C033857@freefall.freebsd.org> To: freebsd-ports-bugs@FreeBSD.org From: Roman Neuhauser Subject: Re: ports/66844: [PATCH] devel/pccts: avoid "installation successful" in the build target X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list Reply-To: Roman Neuhauser List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 21 May 2004 10:20:26 -0000 The following reply was made to PR ports/66844; it has been noted by GNATS. From: Roman Neuhauser To: Volker Stolz Cc: freebsd-gnats-submit@FreeBSD.org Subject: Re: ports/66844: [PATCH] devel/pccts: avoid "installation successful" in the build target Date: Fri, 21 May 2004 12:16:01 +0200 # vs@FreeBSD.org / 2004-05-21 11:11:09 +0200: > Once I again I have to disagree ;) You should simply remove the > offending @echo from the applications Makefile instead of creating an > explicit do-build-target. > You are making maintenance harder, e.g. if there's an update which > changes the "inner" machinery (though I think pccts is EOL). Would a patch like the one below please you more? This would clearly make maintenance harder, e. g. there's an update which changes the banner, and the patch doesn't apply anymore. Plus it's roughly 40 lines instead of 5 or 6. But this is all moot, pccts has been superceded by antlr, and doesn't seem to be developed any more. See http://www.antlr.org/ > This would also avoid touching the do-install-part, right? No it would not. The upstream makefile is... very unorthodox. --- makefile.orig Fri May 21 12:06:12 2004 +++ makefile Fri May 21 12:06:54 2004 @@ -20,41 +20,11 @@ #COPT=-O2 pccts: - @echo " " - @echo " Welcome to PCCTS 1.33MR33 installation" - @echo " " - @echo " (Version 1.33 Maintenance Release #33)" # mrxxx - @echo " " - @echo " Released 19 April 2002" - @echo " " - @echo " Featuring" - @echo " ANTLR -- ANother Tool for Language Recognition" - @echo " DLG -- DFA-based Lexical Analyzer Generator" - @echo " SORCERER -- Source-to-source translator (tree walker)" - @echo " " - @echo " http://www.antlr.org" - @echo " " - @echo " Trouble reports to tmoog@polhode.com" - @echo " Additional PCCTS 1.33 information at" - @echo " http://www.polhode.com" - @echo - @echo - @echo "To substitute gcc for CC to invoke compiler: make CC=gcc" - @echo "If there are problems with cr and lf try: unzip -a ..." - @echo -# @if [ ! -d $(BINDIR) ] ; then mkdir $(BINDIR) ; fi - @echo Making executables... (cd ./antlr; $(MAKE) CC="$(CC)" COPT="$(COPT)") - @echo antlr executable now in $(BINDIR) (cd ./dlg; $(MAKE) CC="$(CC)" COPT="$(COPT)") - @echo dlg executable now in $(BINDIR) (cd ./sorcerer; $(MAKE) CC="$(CC)" COPT="$(COPT)") - @echo sorcerer executable now in $(BINDIR) (cd ./support/genmk; $(MAKE) CC="$(CC)" COPT="$(COPT)"; mv genmk ../../$(BINDIR)) - @echo genmk executable now in $(BINDIR) - @echo - @echo " PCCTS 1.33MR33 installation complete" # MRXXX clean: (cd ./antlr; $(MAKE) -s clean) -- FreeBSD 4.9-RELEASE-p2 12:07PM up 4:02, 8 users, load averages: 0.00, 0.01, 0.00