Date: Thu, 7 Feb 2019 12:14:31 +0100 From: Tobias Kortkamp <tobik@freebsd.org> To: Rodrigo Osorio <rodrigo@freebsd.org> Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r492359 - head/graphics/ufraw Message-ID: <20190207111431.GA66860@urd.tobik.me> In-Reply-To: <201902071102.x17B2ksi050848@repo.freebsd.org> References: <201902071102.x17B2ksi050848@repo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--45Z9DzgjV8m4Oswq Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Feb 7, 2019, at 12:02, Rodrigo Osorio wrote: > Author: rodrigo > Date: Thu Feb 7 11:02:46 2019 > New Revision: 492359 > URL: https://svnweb.freebsd.org/changeset/ports/492359 >=20 > Log: > Be able to build ufraw without GTK2 option > =20 > Add gnome to the uses to make testport happy > Bump portrevision > =20 > PR: 234436 > Reported by: Thomas Guymer <t.m.guymer@thomasguymer.co.uk> >=20 > Modified: > head/graphics/ufraw/Makefile > head/graphics/ufraw/pkg-plist >=20 > Modified: head/graphics/ufraw/Makefile > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D > --- head/graphics/ufraw/Makefile Thu Feb 7 10:55:09 2019 (r492358) > +++ head/graphics/ufraw/Makefile Thu Feb 7 11:02:46 2019 (r492359) > @@ -3,7 +3,7 @@ > =20 > PORTNAME=3D ufraw > PORTVERSION=3D 0.22 > -PORTREVISION=3D 8 > +PORTREVISION=3D 9 > CATEGORIES=3D graphics > =20 > MAINTAINER=3D rodrigo@FreeBSD.org > @@ -20,7 +20,7 @@ LIB_DEPENDS=3D libtiff.so:graphics/tiff \ > =20 > GNU_CONFIGURE=3D yes > CONFIGURE_ARGS=3D --enable-extras > -USES=3D compiler:c++11-lang gettext gmake jpeg pkgconfig autoreconf > +USES=3D compiler:c++11-lang gettext gmake jpeg pkgconfig autoreconf gno= me > =20 > CPPFLAGS+=3D -I${LOCALBASE}/include > LDFLAGS+=3D -lpthread -L${LOCALBASE}/lib > @@ -58,6 +58,13 @@ GTK2_CONFIGURE_WITH=3D gtk > GNOME_USE=3D GNOME=3Dgconf2 > GNOME_CONFIGURE_ENABLE=3D mime > GNOME_VARS=3D CATEGORIES+=3Dgnome GCONF_SCHEMAS=3D${PORTNAME}.schemas > + > +.include <bsd.port.options.mk> > +.if ${PORT_OPTIONS:MGTK2} > +PLIST_SUB+=3D NOGTK2=3D"" > +.else > +PLIST_SUB+=3D NOGTK2=3D"@comment " > +.endif Naming it NOGTK2 is very confusing. OPTIONS_SUB=3Dyes already adds something like this just named after the option directly. Why not just use %%GTK2%% in pkg-plist to achieve the same thing? --45Z9DzgjV8m4Oswq Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGTBAEBCgB9FiEElXvTEJc6ePgdQuobpPCftzzFH2EFAlxcExJfFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDk1 N0JEMzEwOTczQTc4RjgxRDQyRUExQkE0RjA5RkI3M0NDNTFGNjEACgkQpPCftzzF H2FM+gf/a3CEqRMQy2MaoomVEIqG6kC80eLvHVPBbpioVUes4G0DDTVuWjS6kgZu bLYcPHBdAT51Uqkq1+UhKZLfOfc6XiL9OSizARjvhSMjhRemBqFTSV604ipvc1Ca 9zPGZxgcDJm/+favp+hgM5QGkg1osHy1wdqLiLMnQYxMN52qqQRE+XegMNRBo/29 VMPUglKZYrBgYScfpjs/R99/NVBEZPF9+0QYWV/Oxip7tqimVLg/Q7twQKZ3Peyh 9aWwZIK4+deydKHTwygfvk7EA/y9uGD+UAD9i1wLOzjn/0OE1Ij5CBjeu7mxZxOA MQyC5VsO1jptHdOHFrvaL+N8275tNg== =9FiR -----END PGP SIGNATURE----- --45Z9DzgjV8m4Oswq--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20190207111431.GA66860>