From owner-freebsd-ports@FreeBSD.ORG Tue Nov 22 19:30:39 2011 Return-Path: Delivered-To: freebsd-ports@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 5B8CC1065679; Tue, 22 Nov 2011 19:30:39 +0000 (UTC) (envelope-from m.seaman@infracaninophile.co.uk) Received: from smtp.infracaninophile.co.uk (smtp6.infracaninophile.co.uk [IPv6:2001:8b0:151:1:3cd3:cd67:fafa:3d78]) by mx1.freebsd.org (Postfix) with ESMTP id B81778FC1E; Tue, 22 Nov 2011 19:30:38 +0000 (UTC) Received: from seedling.black-earth.co.uk (seedling.black-earth.co.uk [81.187.76.163]) (authenticated bits=0) by smtp.infracaninophile.co.uk (8.14.5/8.14.5) with ESMTP id pAMJUTDG079297 (version=TLSv1/SSLv3 cipher=DHE-RSA-CAMELLIA256-SHA bits=256 verify=NO); Tue, 22 Nov 2011 19:30:30 GMT (envelope-from m.seaman@infracaninophile.co.uk) X-DKIM: OpenDKIM Filter v2.4.1 smtp.infracaninophile.co.uk pAMJUTDG079297 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=infracaninophile.co.uk; s=201001-infracaninophile; t=1321990230; bh=VB5hdP5GyjFuHKxc9mRSQybLO8WKRNFGr4hxGZVuq8s=; h=Message-ID:Date:From:MIME-Version:To:CC:Subject:References: In-Reply-To:Content-Type; b=zTYplcq1OtRzNz8+IllvO6qsXAois8BQuTmrrhQO08VzSjmlKCI4EFEfZSgg4zfNB H2lq3Gtz8S/4axQE8/DEq+HuQ9K6mIpjX7EhOmjfWJAEg8vsG2Z5eMECgVO/+VkFQf Pw4hvrKR09rFLHXKTBH4GPwFg5oK7TzXoPcJWQ8s= Message-ID: <4ECBF84C.4050209@infracaninophile.co.uk> Date: Tue, 22 Nov 2011 19:30:20 +0000 From: Matthew Seaman User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:8.0) Gecko/20111105 Thunderbird/8.0 MIME-Version: 1.0 To: Jason Helfman References: <4EC8CC53.5000806@infracaninophile.co.uk> <20111122132922.GC56180@atarininja.org> <4ECBC36F.6040607@infracaninophile.co.uk> <20111122154924.GD56180@atarininja.org> <20111122172941.GA67967@dormouse.experts-exchange.com> In-Reply-To: <20111122172941.GA67967@dormouse.experts-exchange.com> X-Enigmail-Version: 1.3.3 OpenPGP: id=60AE908C Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="------------enig4558AC5DA2E1A8CB242E9F9C" X-Virus-Scanned: clamav-milter 0.97.3 at lucid-nonsense.infracaninophile.co.uk X-Virus-Status: Clean X-Spam-Status: No, score=-0.6 required=5.0 tests=BAYES_05,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,SPF_FAIL autolearn=no version=3.3.2 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on lucid-nonsense.infracaninophile.co.uk Cc: Wesley Shields , freebsd-ports Subject: Re: More nitpicks from the department of redundancy department... X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 22 Nov 2011 19:30:39 -0000 This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enig4558AC5DA2E1A8CB242E9F9C Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable On 22/11/2011 17:29, Jason Helfman wrote: > On Tue, Nov 22, 2011 at 10:49:24AM -0500, Wesley Shields thus spake: >> On Tue, Nov 22, 2011 at 03:44:47PM +0000, Matthew Seaman wrote: >>> On 22/11/2011 13:29, Wesley Shields wrote: >>> > On Mon, Nov 21, 2011 at 12:42:59AM -0500, Eitan Adler wrote: >>> >> On Sun, Nov 20, 2011 at 10:18 AM, Eitan Adler >>> wrote: >>> >>> On Sun, Nov 20, 2011 at 4:45 AM, Matthew Seaman >>> >>> wrote: >>> >>>> >>> >>>> PORT_DBDIR?=3D /var/db/ports is the default setting in >>> bsd.ports.mk -- the >>> >>>> following ports redefine it to exactly the same value: >>> >>>> [ snip ] >>> >>> >>> >>> Thanks for the report - I'll handle these. >>> >> >>> >> Sorry for the empty promise. Something came up and I won't have th= e >>> >> time to look at these :( - maybe someone else can take them up >>> > >>> > Hi Matthew! >>> > >>> > If you could please file these in a PR and CC me I will try and wor= k >>> > through all of these. >>> >>> Done: http://www.freebsd.org/cgi/query-pr.cgi?pr=3D162754 >> >> Thank you! I will try and clean all this up, but as I'm sure you're >> aware we are coming up on a holiday in the states so my time is limite= d >> for the next few days. I will look at this as time permits though! >> >> -- WXS >=20 > I did have a brief look at some of these and it was a great catch. One = item > I did find interesting is a number of these define LATEST_LINK, but it = just > matches ${PORTNAME}, so the LATEST_LINK can more than likely be dropped= > -- on > a case-by-case basis, of course. Yes -- in fact, all the ports where PORT_DBDIR was redefined also set OPTIONSFILE to what would be the default value in any case. About half the ports mentioned were essentially clones of one of the phpX-extensions ports or borrowed heavily from them. I did a bit of checking to see if there were any other common cases with OPTIONSFILE but couldn't find anything obvious. Haven't searched for people setting LATEST_LINK to what would be the default in any case. Hmmm... just by inspection, there's a lot of ports that essentially set LATEST_LINK to ${PKGNAMEPREFIX}${PORTNAME}${PKGNAMESUFFIX} -- and that is actually the default value already. I'll stick looking into that on the queue. Cheers, Matthew --=20 Dr Matthew J Seaman MA, D.Phil. 7 Priory Courtyard Flat 3 PGP: http://www.infracaninophile.co.uk/pgpkey Ramsgate JID: matthew@infracaninophile.co.uk Kent, CT11 9PW --------------enig4558AC5DA2E1A8CB242E9F9C Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG/MacGPG2 v2.0.16 (Darwin) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iEYEARECAAYFAk7L+FUACgkQ8Mjk52CukIyjiwCeNVTAbHo4sNm4scYZNXsxTNes 36QAnjVvFNOcbdZ7bmt3XgMdgwh4otCi =bRvf -----END PGP SIGNATURE----- --------------enig4558AC5DA2E1A8CB242E9F9C--