From owner-svn-ports-all@freebsd.org Wed Jun 20 19:07:51 2018 Return-Path: Delivered-To: svn-ports-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id B68381004D3C; Wed, 20 Jun 2018 19:07:51 +0000 (UTC) (envelope-from bdrewery@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2610:1c1:1:6074::16:84]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "freefall.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 525046DDC2; Wed, 20 Jun 2018 19:07:51 +0000 (UTC) (envelope-from bdrewery@FreeBSD.org) Received: from mail.xzibition.com (unknown [127.0.1.132]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by freefall.freebsd.org (Postfix) with ESMTPS id E38B01514B; Wed, 20 Jun 2018 19:07:50 +0000 (UTC) (envelope-from bdrewery@FreeBSD.org) Received: from mail.xzibition.com (localhost [172.31.3.2]) by mail.xzibition.com (Postfix) with ESMTP id DD7A1F74; Wed, 20 Jun 2018 19:07:49 +0000 (UTC) X-Virus-Scanned: amavisd-new at mail.xzibition.com Received: from mail.xzibition.com ([172.31.3.2]) by mail.xzibition.com (mail.xzibition.com [172.31.3.2]) (amavisd-new, port 10026) with LMTP id erPRaF46_7Qd; Wed, 20 Jun 2018 19:07:46 +0000 (UTC) Subject: Re: svn commit: r472896 - in head/sysutils: . ssd_report DKIM-Filter: OpenDKIM Filter v2.10.3 mail.xzibition.com 71454F6E To: Devin Teske , ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org References: <201806201831.w5KIVl4G026127@repo.freebsd.org> From: Bryan Drewery Openpgp: id=F9173CB2C3AAEA7A5C8A1F0935D771BB6E4697CF; url=http://www.shatow.net/bryan/bryan2.asc Autocrypt: addr=bdrewery@FreeBSD.org; prefer-encrypt=mutual; keydata= xsBNBFJphmsBCADiFgmS4bIzwZijrS31SjEMzg+n5zNellgM+HkShwehpqCiyhXdWrvH6dTZ a6u50pbUIX7doTR7W7PQHCjCTqtpwvcj0eulZva+iHFp+XrbgSFHn+VVXgkYP2MFySyZRFab D2qqzJBEJofhpv4HvY6uQI5K99pMqKr1Z/lHqsijYYu4RH2OfwB5PinId7xeldzWEonVoCr+ rfxzO/UrgA6v/3layGZcKNHFjmc3NqoN1DXtdaEHqtjIozzbndVkH6lkFvIpIrI6i5ox8pwp VxsxLCr/4Musd5CWgHiet5kSw2SzNeA8FbxdLYCpXNVu+uBACEbCUP+CSNy3NVfEUxsBABEB AAHNJEJyeWFuIERyZXdlcnkgPGJkcmV3ZXJ5QEZyZWVCU0Qub3JnPsLAgAQTAQoAKgIbAwUL CQgHAwUVCgkICwUWAwIBAAIeAQIXgAIZAQUCWujOIgUJCmB7NwAKCRA113G7bkaXz/xpB/9b /UWIPbieY1IeIuHF2pyYPE7Hytkh3HVsxMA0F5Ma2AYQsXZZeKNKWrF7RPyDyDwUklLHJkhm k3EfClBbHxf08kMIm1vWCJRtgxic9knY/bzYGiWMpHjg3cSd1XfrYH1autYqTZAjDwIkgOjU dR//Tbn4V36sY7y2jz+kdMVWvK53U32aZqiwBbCn4DPe1wSZcUs17mV/0uZdIoGdj74B1orN A/0py5vHYo6HcbBNoaR8pKRLf5VZNRsxqGIMhTucx4SJWcHpuRBWYyvJSFzwvxdK4ZD4Yqoc kFGPVtOXktVMai9exrLvP3G77fKMu8DI6j4QRU4wCesnHuIfRPFuzsBNBFJphmsBCACiVFPf kNfaFtUSuY0395ueo/rMyHPGPQ2iwvERFCpeFGSQSgagpenNHLpFQKTg/dl6FOoST5tqyxMq fyHGHDzzU51bvA/IfaGoNi/BIhTe/toZNMRvpcI3PLjiGcnJnuwCCbAVOAGdb+t5cZtpNdOI cKYmrYG3u9RiBpe6dTF+qLrD/8Bs1wjhduQ8fcNNgnkXu8xDH4ZxY0lIc3QgvYWp9vimlQe6 iKjUd2/DX28ETZcD5h6pYV331KMPTrEI0p0yvFijUZce8c1XHFyL1j9sBAha5qpszJl6Uq5i LolhKRcGfcdmtD72vHQjUYglUyudSJUVyo2gMYjdbiFKzJulABEBAAHCwGUEGAEKAA8CGwwF AlrozigFCQpgez0ACgkQNddxu25Gl8+m5Af/R3VEdxNMAcDIes9ADhQyofj20SPV3eCJ3HYR OebTSuNdOudGt4AAyA8Ks94u9hiIp5IGsc6RDsT9W7O2vgXhd6eV3eiY5Oif5xLIYrIDVu1Y 1GyRxRrPEn/QOqDN6uFZCPwK1aOapGcYCrO9lB0gMuTVfgHanU61rgC9tMX0OoAOyRd+V3/M 8lDNhjJdF/IpO3SdYzKfkwduy4qamw4Gphcx/RfYQvYLq/eDkP8d50PphWdboqWBwNRHayro W/07OGzfxM5fJ5mBsXPQcO2QcRjkyHf6xCM6Hi1qQL4OnXMNE/ZTX0lnOj1/pH93TlzSHZMP TaiiA/MBD3vGsXBmBg== Organization: FreeBSD Message-ID: <7fb99590-249d-0edb-cf43-c7f25a00f6cd@FreeBSD.org> Date: Wed, 20 Jun 2018 12:07:45 -0700 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.8.0 MIME-Version: 1.0 In-Reply-To: <201806201831.w5KIVl4G026127@repo.freebsd.org> Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="P0BT40gfjtersT2az12nprst10Cz61qCX" X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.26 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 20 Jun 2018 19:07:52 -0000 This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --P0BT40gfjtersT2az12nprst10Cz61qCX Content-Type: multipart/mixed; boundary="3clO3OmFTE818BhBn63rfJq3dk4MWlVCA"; protected-headers="v1" From: Bryan Drewery To: Devin Teske , ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Message-ID: <7fb99590-249d-0edb-cf43-c7f25a00f6cd@FreeBSD.org> Subject: Re: svn commit: r472896 - in head/sysutils: . ssd_report References: <201806201831.w5KIVl4G026127@repo.freebsd.org> In-Reply-To: <201806201831.w5KIVl4G026127@repo.freebsd.org> --3clO3OmFTE818BhBn63rfJq3dk4MWlVCA Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: quoted-printable On 6/20/2018 11:31 AM, Devin Teske wrote: > Author: dteske > Date: Wed Jun 20 18:31:47 2018 > New Revision: 472896 > URL: https://svnweb.freebsd.org/changeset/ports/472896 >=20 > Log: > [New Port] sysutils/ssd_report > =20 > Report SSD health by looking at SMART data. Supports `smartctl' from > sysutils/smartmontools but prefers `smart' from sysutils/smart. Also > supports JSON output upon request. > =20 > Reviewed by: mat (mentor) > Approved by: portmgr (mat), mat (mentor) > Sponsored by: Smule, Inc. > Differential Revision: https://reviews.freebsd.org/D15876 >=20 > Added: > head/sysutils/ssd_report/ > head/sysutils/ssd_report/Makefile (contents, props changed) > head/sysutils/ssd_report/distinfo (contents, props changed) > head/sysutils/ssd_report/pkg-descr (contents, props changed) > Modified: > head/sysutils/Makefile >=20 > Modified: head/sysutils/Makefile > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D > --- head/sysutils/Makefile Wed Jun 20 18:25:02 2018 (r472895) > +++ head/sysutils/Makefile Wed Jun 20 18:31:47 2018 (r472896) > @@ -1202,6 +1202,7 @@ > SUBDIR +=3D spinner > SUBDIR +=3D spiped > SUBDIR +=3D squashfs-tools > + SUBDIR +=3D ssd_report > SUBDIR +=3D sshsudo > SUBDIR +=3D ssid > SUBDIR +=3D ssync >=20 > Added: head/sysutils/ssd_report/Makefile > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D > --- /dev/null 00:00:00 1970 (empty, because file is newly added) > +++ head/sysutils/ssd_report/Makefile Wed Jun 20 18:31:47 2018 (r472896= ) > @@ -0,0 +1,36 @@ > +# $FreeBSD$ > + > +PORTNAME=3D ssd_report > +DISTVERSION=3D 0.2 > +CATEGORIES=3D sysutils > + > +MAINTAINER=3D dteske@FreeBSD.org > +COMMENT=3D SSD health report > + > +LICENSE=3D BSD2CLAUSE > +LICENSE_FILE=3D ${WRKSRC}/LICENSE > + > +FLAVORS=3D smart smartmontools FLAVORS requires that each flavor has a unique PKGNAME because *every version of the package* will be built and stored on the package repository. It can't work to have 2 packages with the same name that have different functionality. So you must handle PKGNAMESUFFIX here somehow for at least the non-default flavors. smartmontools_PKGNAMESUFFIX=3D -smartmontools > +FLAVOR?=3D ${FLAVORS:[1]} Why put FLAVOR? here? It is not needed. FLAVOR is a user-specified option that already has a default in bsd.port.mk. > + > +smart_RUN_DEPENDS=3D smart:sysutils/smart > +smartmontools_RUN_DEPENDS=3D smartctl:sysutils/smartmontools > + > +USE_GITHUB=3D yes > +GH_ACCOUNT=3D FrauBSD > +NO_ARCH=3D yes > +NO_BUILD=3D yes > + > +PLIST_FILES=3D sbin/ssd_report > +PORTDOCS=3D README.md > + > +OPTIONS_DEFINE=3D DOCS > + > +do-install: > + ${INSTALL_SCRIPT} ${WRKSRC}/ssd_report ${STAGEDIR}${PREFIX}/sbin > + > +do-install-DOCS-on: > + @${MKDIR} ${STAGEDIR}${DOCSDIR} > + ${INSTALL_DATA} ${PORTDOCS:S,^,${WRKSRC}/,} ${STAGEDIR}${DOCSDIR} > + > +.include >=20 > Added: head/sysutils/ssd_report/distinfo > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D > --- /dev/null 00:00:00 1970 (empty, because file is newly added) > +++ head/sysutils/ssd_report/distinfo Wed Jun 20 18:31:47 2018 (r472896= ) > @@ -0,0 +1,3 @@ > +TIMESTAMP =3D 1529303779 > +SHA256 (FrauBSD-ssd_report-0.2_GH0.tar.gz) =3D a56a76277dc095ef24dd954= 447e6ad86140838308e667d6143a84202a8c17f2c > +SIZE (FrauBSD-ssd_report-0.2_GH0.tar.gz) =3D 7715 >=20 > Added: head/sysutils/ssd_report/pkg-descr > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D > --- /dev/null 00:00:00 1970 (empty, because file is newly added) > +++ head/sysutils/ssd_report/pkg-descr Wed Jun 20 18:31:47 2018 (r47289= 6) > @@ -0,0 +1,5 @@ > +Report SSD health by looking at SMART data. Supports `smartctl' from > +sysutils/smartmontools but prefers `smart' from sysutils/smart. Also > +supports JSON output upon request. > + > +WWW: https://fraubsd.org/ssd_report/ >=20 --=20 Regards, Bryan Drewery --3clO3OmFTE818BhBn63rfJq3dk4MWlVCA-- --P0BT40gfjtersT2az12nprst10Cz61qCX Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBAgAGBQJbKqYBAAoJEDXXcbtuRpfPa4cH/Ahsx2nBybmECkna5nS412i5 pOv4vKtmcTVB/z4D4Myg4BoNo1wR4UBRawRiI05l8/jgq/Fp8h+ozguPYikpUzmf uJIn0fDqcPtXo82RHRUmQdExkYO7M87ECBP5JEGIQxm1EQ2+HnL+f0dBuElUOrwC 02AFL91+T5+ArzGqihgz0t8TrVKFhE3xQNFCV3MqjIrjy0WjGiL19RKjMft2mqo1 K06Ux+7D5ry7B0kfLZVHD8Cn1koBy47Hee2dhdkvsoNx+JH8BVrstr7OvUcgCzfN zY7oSSJnQaKSOtGyqE/gjXJtFiBCejFv6X20ErnVkyH5vQ9ULVXSn1T7G/Hwkmw= =M+oa -----END PGP SIGNATURE----- --P0BT40gfjtersT2az12nprst10Cz61qCX--